Commit Graph

2678 Commits

Author SHA1 Message Date
80fc13fc1f Merge pull request #16976 from peppy/dont-expose-mark-as-read-errors-to-user
Don't expose "mark as read" errors to the user via notifications
2022-02-24 23:20:34 +09:00
16a3bbbcb4 Merge pull request #16944 from peppy/rooms-request-faster
Update playlists/multiplayer to use new compact response
2022-02-24 23:20:07 +09:00
35302aa297 Merge pull request #16980 from smoogipoo/fix-union-workaround-resolver
Fix SignalR union workaround resolver failing on multiple union'd types
2022-02-24 22:24:48 +09:00
c5b1e5cbf8 Fix union resolver failing on multiple derived types 2022-02-24 20:27:22 +09:00
d69446ff6e Merge pull request #16979 from smoogipoo/fix-playlists-partial-mod
Fix playlists not allowing entry with partial mods
2022-02-24 19:37:10 +09:00
2acaffd5e7 Fix APIMod storing bindables instead of value 2022-02-24 17:01:12 +09:00
c6d78b9325 Fix several oversights in data linking causing drawable rooms not updating as expected 2022-02-24 16:12:15 +09:00
b4a54b38e7 Remove redundant parameter specification 2022-02-24 16:02:16 +09:00
3f6bdc5585 Don't expose "mark as read" errors to the user via notifications
This can happen if the user leaves the channel before the request is
fired. You can't mark a channel as read when you're not in the channel.

Addresses https://github.com/ppy/osu/discussions/16973.
2022-02-24 15:40:07 +09:00
29d77a29aa Merge branch 'master' into startup-protocol-handling 2022-02-23 21:10:27 +01:00
3f2ef030e4 Group SpectatorClient private fields together 2022-02-24 02:31:55 +09:00
5ffdd57895 Rename weirdly named parameter 2022-02-24 02:28:13 +09:00
694c6ad872 Fix frames potentially getting lost due to non-matching Schedule usage 2022-02-24 02:28:13 +09:00
47b84295a6 Fix bundle send logic not correctly waiting for task completion (due to nested schedule) 2022-02-24 02:23:48 +09:00
cff6f85472 Add note about reconnection being insufficient currently 2022-02-24 02:23:48 +09:00
5ff4d3f8e5 Add support to SpectatorClient to resend failed frame bundles 2022-02-24 02:21:29 +09:00
53bbd00675 Also make APIUser opt-in and remove the remaining serialization exclusion rule 2022-02-23 17:12:38 +09:00
43c83d2de1 Add note about why RoomID is nulled in DeepClone 2022-02-23 17:10:11 +09:00
f14a9af801 Make Room opt-in rather than opt-out for json serialization 2022-02-23 17:10:10 +09:00
28c9c5ab6a Remove unnecessary ShouldSerialize rules in Room 2022-02-23 17:10:10 +09:00
7bdcb5952e Fix handling badly-formatted osu:// urls 2022-02-23 00:36:56 +01:00
1a358698fb Merge branch 'master' into startup-protocol-handling 2022-02-22 22:42:16 +01:00
ed008267d7 Fix one more case of escaping not being present
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-22 16:45:18 +09:00
ca0a041153 Fix missing escaping causing test failures
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-22 16:45:04 +09:00
61b3280de1 Add missing property copies in Room.CopyFrom implementation 2022-02-22 15:47:00 +09:00
71ae425fb2 Merge branch 'master' into rooms-request-faster 2022-02-22 15:45:05 +09:00
f12044b03e Add mention of PlaylistItem.Beatmap being a placeholder in many cases 2022-02-22 15:31:08 +09:00
e3ae52360e Merge branch 'master' into leaderboard-score-timeref 2022-02-21 20:50:00 +01:00
b43008b9f6 Add cover and count handling from newer response version 2022-02-21 19:05:22 +09:00
39d64e779c Handle API returned difficulty range for rooms 2022-02-21 19:05:19 +09:00
7f4cc221d2 Add API versioning 2022-02-21 19:02:03 +09:00
1737128334 Allow room category to be copied even if Spotlight
I remember that this conditional copy was added to support making copies
of spotlight rooms without carrying across the `Spotlight` type, but in
testing this is already handled web side to the point that it's not
required.

The rationale for allowing the copy is that this method is used for
tests, where it was not being copied correctly from the input as
expected (used at
bdc3b76df0/osu.Game/Tests/Visual/OnlinePlay/TestRoomManager.cs (L38)).
2022-02-21 17:47:56 +09:00
fc1877b6fa Move to extension method and revert logic to match previous implementation 2022-02-21 13:42:26 +09:00
79408f6afc Add xmldoc and clean up ScoreboardTimeUtils extension methods a touch 2022-02-21 13:30:58 +09:00
2ded7d281b Remove unused using statement 2022-02-21 13:17:19 +09:00
abe1a3990a Merge branch 'master' into leaderboard-score-timeref 2022-02-21 12:11:10 +09:00
262751a98a Revert highlighting recent scores 2022-02-19 21:23:35 +01:00
31b7ce053d Fix CI issues 2022-02-19 21:18:26 +01:00
0d83c5a39a Add colour highlighting recent scores 2022-02-19 20:47:30 +01:00
15ed9ec4fa Merge scoreboard and leaderboard implementations together 2022-02-19 20:47:02 +01:00
98aaf83177 Add a centralised constant for the osu URL schema protocol 2022-02-18 15:57:37 +09:00
1abbb9ab39 Align the bar to be on baseline of score components
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-17 21:26:59 +01:00
9d0023c750 Fix incorrect mappings 2022-02-17 21:12:51 +09:00
3d5ed24e20 Fix beatmap overlay leaderboards and links not working
Completely aware that this isn't how it should be done, but would like
to get this out in a hotfix release today. Maybe changes opinions on
https://github.com/ppy/osu/pull/16890 structure?
2022-02-17 21:05:00 +09:00
f4d1e6f600 Add tests for timerefs 2022-02-17 10:38:29 +01:00
7bd731ae08 Move the date next to the flag icon 2022-02-17 10:12:35 +01:00
333a305af3 Use floor instead of ceiling 2022-02-17 00:09:17 +01:00
c124034cf3 Add text displaying recent score time 2022-02-16 23:18:14 +01:00
55d9f0b44b Store beatmap to a field instead 2022-02-16 16:03:08 +09:00
7e24b36f26 Merge branch 'master' into remove-playlistitem-beatmap 2022-02-16 14:24:57 +09:00