Commit Graph

2678 Commits

Author SHA1 Message Date
b434e29a7c Move loading hide operation inside early return to ensure not hidden too early
It should only be hidden after the async load completes.
2022-01-30 03:10:15 +09:00
dad9cc9315 Ensure Reset/Scores_Set run inline where possible 2022-01-30 03:06:29 +09:00
9b573fbc2b Add missing entries to switch statement and guard against out of range 2022-01-30 02:58:53 +09:00
d21464ea61 Fix assertions to work in both directions 2022-01-30 02:54:51 +09:00
d3cb910cf8 Convert inline math to not so inline to make operation more explicit 2022-01-30 02:37:01 +09:00
3d771c0fc7 Remove unnecessary loading hide call from PlaceholderState_Set and add more assertiveness 2022-01-30 02:34:31 +09:00
6f54f8ad78 Add more safety around CancellationToken usage 2022-01-29 23:58:57 +09:00
d0b74a91fb Fix edge cases with score drawable loading 2022-01-29 23:58:57 +09:00
0293d95f82 Simplify IsOnlineScope usage 2022-01-29 23:58:57 +09:00
daea13f491 Simplify flow of cancellation token 2022-01-29 23:58:57 +09:00
3d59bab7c6 Remove fetch callback logic completely 2022-01-29 23:58:57 +09:00
13f445ddd5 Move score update code into own method 2022-01-29 23:58:57 +09:00
c48e9f2bbd Remove more unnecessary schedule/cancel logic 2022-01-29 23:58:57 +09:00
a700ad3849 Remove scoresLoadedOnce weirdness 2022-01-29 23:58:57 +09:00
661fec7c8a Make score setter private 2022-01-29 23:58:57 +09:00
b85b2c01fb Reorder based on accessibility and add regions 2022-01-29 23:58:57 +09:00
c548658662 Remove move unused pieces 2022-01-29 23:58:57 +09:00
17aa9f3040 Remove pointless level of schedule/cancel logic 2022-01-29 23:58:57 +09:00
64925b3fea Remove unused Content override 2022-01-29 23:58:57 +09:00
b9dac6c3b2 Reorder and tidy up bindable flows 2022-01-29 23:58:57 +09:00
aee93934d5 Rename methods to make more sense (and always run through AddOnce) 2022-01-29 23:58:57 +09:00
c6d303a5b4 Add xmldoc to Leaderboard class 2022-01-29 23:58:57 +09:00
3037a3a769 Purge final spectator frames before ending play 2022-01-28 22:26:05 +09:00
397971c631 Change FrameDataBundle.Frames into an IList 2022-01-28 22:06:34 +09:00
c953a5d503 Ensure PollingComponent.Poll is always called from the update thread
Not strictly required since all `Poll` implementations are now
threadsafe, but extra safety is never a bad thing?
2022-01-28 13:44:11 +09:00
465e7d29fe Avoid showing the external link warning 2022-01-27 14:53:11 +09:00
d7342880f5 Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications 2022-01-25 13:09:48 +09:00
6eb2c28e41 Rename RealmContextFactory to RealmAccess 2022-01-24 20:38:07 +09:00
40aa873190 Rename register methods to better explain their purpose 2022-01-24 14:37:36 +09:00
e9e3e024a1 Update all usages of QueryAsyncWithNotifications to use new Register pathway 2022-01-23 20:28:04 +09:00
1f157d729d Update existing subscriptions to new style
Fix missing detach calls in `MusicController`
2022-01-21 20:05:03 +09:00
73a1f27ce5 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-18 17:31:37 +09:00
d26f4d50bd Add test coverage of aggregate room scores displaying correctly 2022-01-18 14:00:12 +09:00
03e4ec4214 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-15 14:45:42 +01:00
916b591b1b Fix watch replay button not working immediately after playing 2022-01-14 18:03:06 +09:00
4f8d29c1c0 Merge branch 'master' into realm-integration/score-and-beatmaps 2022-01-13 18:25:09 +09:00
4012ef7e7b Reduce polling rate when idle even if HighPollRate is requested 2022-01-13 17:33:55 +09:00
46d2f305b5 Log chat polling rate changes 2022-01-13 17:31:59 +09:00
2de0c34bc9 Reduce exposure of ChannelManager 2022-01-13 17:10:48 +09:00
66773f6d7d Use comments to disable identifier typos instead 2022-01-12 15:49:28 -08:00
b245ffefc1 Merge remote-tracking branch 'upstream/master' into fix-remaining-identifier-names 2022-01-12 15:05:07 -08:00
4c79145c11 Fix potential mod nullref in APIUserScoreAggregate's CreateScoreInfo implementation 2022-01-13 00:28:16 +09:00
51251e3204 Fix CI reported warnings 2022-01-12 22:39:00 +09:00
7dba3c3551 Fix most remaining test issues 2022-01-12 17:49:11 +09:00
a7958b1d31 Fix edge cases in online availability tracker and combine query code 2022-01-12 17:49:10 +09:00
c15efaeff2 Fix OnlinePlayBeatmapAvailabilityTracker not correctly tracking beatmap import changes 2022-01-12 17:49:10 +09:00
b531cd0207 Fix donwload trackers not considering deleted scores 2022-01-12 17:49:10 +09:00
f4a1fa85a1 Fix incorrect conditional for deciding whether scores can be deleted from UI 2022-01-12 17:49:10 +09:00
a3c70ccdfc Fix OnlineAvailabilityTracker referencing a value in query that could potentially be null 2022-01-12 17:00:17 +09:00
e1f77b87de "Fix" OnlinePlayBeatmapAvailabilityTracker 2022-01-12 17:00:16 +09:00