Commit Graph

1031 Commits

Author SHA1 Message Date
6c9594ee35 Simplify and rearrange SkinSelectionHandler
The file has been restructured and reworded such that there are as few
differences as possible from b36b40cb34.
2021-06-07 02:40:15 -04:00
29fa4fdf57 Refactor unacceptable syntax 2021-06-07 01:08:39 -04:00
133d72a8c0 Rename UsingClosestAnchor
It is now "OverridesClosestAnchor". The logic is inverted accordingly.
2021-06-07 00:14:36 -04:00
f28916e30f Remove all UsingClosestAnchor() extension logic
It is replaced with ISkinnableDrawable.UsingClosestAnchor.
2021-06-07 00:04:53 -04:00
ce635af83e Add UsingClosestAnchor to ISkinnableDrawable
Also implement it as an auto property in its inheritors.
The auto properties default to true.
2021-06-06 23:47:47 -04:00
d26c9a66c2 Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-06-07 12:01:19 +09:00
6a456e53f4 Rename overly long method 2021-06-06 13:28:17 -04:00
888882ac63 Remove first-person comment 2021-06-06 13:27:13 -04:00
e10dfab2e8 Ensure scorebar marker lookup is performed on the source the background is retrieved from 2021-06-06 23:23:35 +09:00
da1c38d5a9 Uninvert logic of SkinnableInfo.UsingClosestAnchor
Also rename "IsUsingClosestAnchor" to simply "UsingClosestAnchor".
2021-06-06 10:13:35 -04:00
b5f145cfa9 Use null propagation for animation lookups 2021-06-06 23:01:37 +09:00
63346f6b75 Refactor getTieredComponent 2021-06-06 09:40:58 -04:00
c9f5808bf2 Move lookup logic to DrawableExtensions
This is now a global lookup to be shared by serialization and editor.
2021-06-06 06:58:21 -04:00
4aee76456f Replace localised strings with static English 2021-06-06 05:34:32 -04:00
c452715bf1 Allow skin elements to find closest anchor
- Resolves ppy/osu#13252
- Add localisation strings for the context menu instead of using enum
2021-06-06 01:32:04 -04:00
b904fa6615 Revert "Ensure all frames in an animation are retrieved from the same skin"
This reverts commit 37c8c63fc5.
2021-06-06 12:37:42 +09:00
b87a5956dd Add fallback logic to SkinManager 2021-06-06 12:17:55 +09:00
39f99bf785 Move FindProvider to ISkinSource 2021-06-06 12:17:32 +09:00
ae2165b3be Fix incorrect xmldoc 2021-06-04 16:44:04 +09:00
37c8c63fc5 Ensure all frames in an animation are retrieved from the same skin 2021-06-04 16:18:04 +09:00
c065f761c7 Merge branch 'master' into legacy-skin-default-fallback 2021-06-02 19:08:52 +09:00
2e2281c7d2 Revert disabling taiko sample tests and fix logic 2021-06-01 18:57:19 +09:00
3a6d081d82 Remove duplicated taiko fallback 2021-06-01 18:04:49 +09:00
ea4644be90 Revert "Fix weird taiko logic failing for weird reasons that probably should not have been a thing"
This reverts commit 69c4ccad05.
2021-06-01 18:04:49 +09:00
a837fc9e3b Remove duplicated taiko fallback 2021-06-01 18:00:24 +09:00
df0a5689e4 Revert "Fix weird taiko logic failing for weird reasons that probably should not have been a thing"
This reverts commit 69c4ccad05.
2021-06-01 17:13:13 +09:00
ff815cb4b4 Fix incorrect xmldoc 2021-06-01 16:57:41 +09:00
7c6400735f Merge branch 'master' into remove-hud-component-lookup 2021-06-01 10:17:52 +03:00
00b3eea840 Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup 2021-05-31 21:39:04 +09:00
69c4ccad05 Fix weird taiko logic failing for weird reasons that probably should not have been a thing 2021-05-31 21:29:47 +09:00
1161378b6b Fix incorrect fallback logic in LegacyBeatmapSkin 2021-05-31 21:29:47 +09:00
282c5a9177 Fix potential nullref in SkinProvidingContainer 2021-05-31 21:29:47 +09:00
3ff9f9c89d Make FindProvider non-default 2021-05-31 21:29:47 +09:00
8e489754cc Add ability for LegacySkins to customise the fallback provider 2021-05-31 21:29:47 +09:00
88ed95e012 Add FindProvider lookup function 2021-05-31 21:29:47 +09:00
1d30791ab0 Add potential pathway for legacy lookups 2021-05-31 21:29:47 +09:00
4b27d43e26 Add new parameter for default fallback logic in LegacySkin 2021-05-31 21:29:47 +09:00
17fa2426d4 Merge branch 'master' into legacy-skin-resource-improvements 2021-05-31 19:36:09 +09:00
65709ec7d7 Move leagcy resource store construction local to DefaultLegacySkin 2021-05-31 19:14:49 +09:00
b16d10bd95 Provide game-wide resources via IStorageResourceProvider 2021-05-31 18:57:47 +09:00
de0e51a81d Merge branch 'master' into fix-skin-sample-lookup 2021-05-31 15:27:39 +09:00
02d18c7a49 Merge branch 'master' into remove-hud-component-lookup 2021-05-31 09:23:04 +03:00
fb81e5133f Merge branch 'master' into catch-hide-combo-workaround 2021-05-30 14:16:46 +03:00
53cbf369d7 Fix potential nullref 2021-05-29 21:22:46 +03:00
42618c713f Merge branch 'master' into legacy-beatmap-skin-hud-fallback 2021-05-29 20:56:05 +03:00
70a844ac10 Remove allowFallback parameters completely 2021-05-27 14:50:42 +09:00
4fd89faaa4 Fix default skin not having resources or providing samples 2021-05-27 14:09:01 +09:00
b36b40cb34 Remove unnecessary double specification 2021-05-26 15:20:47 +09:00
65649e5a62 Prevent skin editor crash when scaling 0 area drawables
Some skinnable drawables can have 0 width or height in certain
cases, leading to division by 0 and a crash when the position is
updated.
2021-05-24 21:36:42 +02:00
caa2c5638e Fix legacy combo counter not accounting for song progress bar 2021-05-23 16:46:57 +09:00