31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
97fcf8cec9
Merge pull request #18668 from smoogipoo/editor-controlpoint-undo-redo
2022-06-23 04:02:24 +09:00
950551f4fd
Fix metronome arm being stuck white when paused 'close enough' to center
2022-06-22 15:33:42 +09:00
a40ad6f784
Add slight transform when resetting arm from almost-zero
2022-06-21 15:07:35 +09:00
82c4d855d4
Rename sample variable to be easier to discern from other fields
2022-06-21 15:05:17 +09:00
16a9e18815
Adjust timing of latch to be more in sync with visuals
2022-06-21 15:02:53 +09:00
7b46d38318
Move colour fade back to where it was
2022-06-21 15:02:43 +09:00
3b79c632f5
Merge branch 'master' into new-metronome-sfx
2022-06-21 14:58:58 +09:00
42701757c3
Fix latch reset logic
2022-06-21 14:52:57 +09:00
72c0fc3fec
Merge pull request #18753 from frenzibyte/prevent-mistimed-metronome-beats
...
Fix metronome playing mistimed beat sounds on editor clock resume
2022-06-21 13:48:42 +09:00
046b848bcd
Split group selection to separate method
2022-06-21 12:53:06 +09:00
9763a58392
Change to use ReferenceEquals
2022-06-21 12:05:52 +09:00
e0c82d11ab
Convert == usages to ReferenceEquals
2022-06-20 16:56:19 +09:00
ca287d0936
Fix group deselected when table is recreated
2022-06-20 16:56:19 +09:00
a922ea9b01
Fix selection by directly comparing control points
...
Previously, all control points would get replaced, which led to
performance issues that was worked around in this PR. By comparing
control points, we're able to get good performance without requiring the
workaround.
2022-06-20 15:29:29 +09:00
468e5fcbed
Merge branch 'master' into editor-controlpoint-undo-redo
2022-06-20 13:47:01 +09:00
3902dc64f0
Fix adjusting offset via button seeking to timing point's offset unexpectedly
...
This was added with the intention of tracking the offset when already at
the start (the most common case when you're using the tap timing
wizard), but was also seeking when the user may be much further beyond
or before it.
Addresses https://github.com/ppy/osu/discussions/18741#discussioncomment-2975051 .
2022-06-19 01:35:45 +09:00
204348f327
Fix metronome playing mistimed beat sounds on editor clock resume
2022-06-18 04:49:44 +03:00
8a1d11fefb
Cancel previous metronome sound playback on pause
2022-06-18 04:07:21 +03:00
1f78a4fadd
New audio feedback for metronome
2022-06-17 16:56:09 +09:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
c30644328c
Fix timing adjustment repeat buttons firing one change per repeat invocation
2022-06-14 19:21:02 +09:00
776e7c0c71
Work around performance issues
2022-06-13 15:45:08 +09:00
fcf51a6f51
Merge pull request #18530 from peppy/add-cloen-button
...
Change text on timing group add button when it is going to clone instead
2022-06-03 22:23:04 +09:00
debd1a59b0
Merge pull request #18539 from frenzibyte/repeating-button-behaviour
...
Share repeat implementation in `TimingAdjustButton` for timeline zoom buttons
2022-06-03 18:18:23 +09:00
1c738e22ae
Merge pull request #18523 from peppy/tap-button
...
Add tap for BPM button
2022-06-03 18:11:10 +09:00
e779b460e4
Use Component instead of CompositeDrawable
2022-06-03 16:49:08 +09:00
dd93fc283b
Merge pull request #18531 from peppy/track-groups-better
...
Improve group tracking logic to avoid switching which point type unnecessarily
2022-06-03 13:04:54 +09:00
efbde06c11
Split button repeating logic from TimingAdjustButton to own component
2022-06-03 05:23:49 +03:00
87ec2e490d
Merge branch 'master' into deselect-control-group
2022-06-03 00:47:06 +02:00
ad3c093a08
Improve group tracking logic to avoid switching which point type unnecessarily
2022-06-02 18:33:09 +09:00
2fa4d46f73
Change text on timing group add button when it is going to clone instead
...
Also disables the button when it would otherwise have no effect.
2022-06-02 18:28:16 +09:00
0b125ade4c
Allow clicking away to deselect the current control point group
2022-06-02 18:18:18 +09:00
5a0f716bf2
Fix timing screen crash when attempting to add group to self
...
Closes #18527 .
2022-06-02 18:14:28 +09:00
ee4beefd95
Increase max taps to 128 for now
...
Will revisit this in the future with a more sound algorithm.
2022-06-02 17:27:52 +09:00
e75609dfb9
Increase taps to consider for better results for longer tap periods
2022-06-02 17:03:48 +09:00
4abfb35611
Improve light rotational alignment and increase light count to 8
2022-06-02 16:58:14 +09:00
060372a129
Split out transition length constants
2022-06-02 13:16:31 +09:00
15f8d318eb
Add note about glow code (please look away)
2022-06-02 13:13:00 +09:00
ac3793f340
Move inline class to end and apply NRT
2022-06-02 13:10:50 +09:00
d99d37c0a6
Apply current track rate to calculated BPM
2022-06-02 13:06:18 +09:00
943e904c71
Fix reset happening on mouse down instead of mouse up
...
Also some reorganisation of file content for legibility
2022-06-02 12:58:44 +09:00
0c493dd359
Add key binding for tap button
2022-06-02 12:58:44 +09:00
781a1527b1
Adjust button metrics and move surrounding buttons to be more integrated
2022-06-02 12:58:43 +09:00
d4e88441ec
Adjust metrics to make timing section fit better in editor
2022-06-02 11:57:06 +09:00
f3f7e28353
Ignore initial taps as they are generally inaccurate
2022-06-02 11:57:06 +09:00
b88bce9b8b
Restart track playback when tapping to time
2022-06-02 11:57:06 +09:00
96ccd29bdc
Don't play metronome click when tapping for timing
2022-06-02 11:57:06 +09:00
d47a3bb8e4
Use NRT and transfer BPM
2022-06-02 11:57:06 +09:00
a2d177d7d2
Add BPM display and tracking
2022-06-02 11:57:06 +09:00
