Commit Graph

54710 Commits

Author SHA1 Message Date
a260d7872d Update framework 2022-08-25 21:50:10 +09:00
a546aa2673 Clamp SpectatorPlayerClock's elapsed calculation to avoid player clocks getting too far ahead 2022-08-25 21:33:33 +09:00
a8c699610a Fix lead in tests not waiting for player to start running
The tests are only meant to ensure that gameplay eventually starts.

The case where failures can occur is where the master clock is behind
the player clock (due to being in lead-in time). Because the test is
running in real-time, it can take arbitrary amounts of time to catch up.

If it took too long, the test would fail.
2022-08-25 18:00:14 +09:00
ddb434f47a Rename asserts to method names to make it easier to track in logs 2022-08-25 17:30:13 +09:00
a5c61d9a52 Improve understandability of TestMostInSyncUserIsAudioSource 2022-08-25 16:47:33 +09:00
3a17c6df08 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-25 16:24:55 +09:00
bb0701c457 Merge pull request #19939 from smoogipoo/maximum-statistics-2
Add `maximum_statistics` to `ScoreInfo`
2022-08-25 09:45:33 +03:00
3ac8b6779b Merge branch 'master' into maximum-statistics-2 2022-08-25 14:53:18 +09:00
bf43f1d076 Merge pull request #19956 from peppy/fix-beatmap-carousel-interactive-test-run
Fix some `BeatmapCarousel` tests not correctly reinitialising local data per run
2022-08-25 14:52:22 +09:00
85705d97a5 Merge pull request #19853 from Lawtrohux/pp-rescale-effective-misses
osu!taiko performance point adjustments & effective misses
2022-08-25 14:43:03 +09:00
146cc62f00 Merge branch 'master' into maximum-statistics-2 2022-08-25 08:18:44 +03:00
1032b2a68c Fix some BeatmapCarousel tests not correctly reinitialising local data per run
Closes https://github.com/ppy/osu/issues/19949.
2022-08-25 14:03:26 +09:00
8eab36f8c9 Actually fix possible NaN value 2022-08-25 14:02:10 +09:00
17029f0b92 Ensure clones don't reference to MaximumStatistics 2022-08-25 13:58:58 +09:00
136dcee3b5 Merge pull request #19571 from vunyunt/colour-encoding-2
Rewrite of the colour skill & refactoring of difficulty calculation within osu!taiko
2022-08-25 13:56:50 +09:00
804a752062 Merge pull request #19951 from o-dasher/no-mod-gameplayclock
No "gameplayClock" usage with playfield update mods
2022-08-25 11:14:22 +09:00
4de6df71c5 No "gameplayClock" usage with playfield update mods 2022-08-24 20:59:32 -04:00
55f1865c03 Merge pull request #19937 from novialriptide/copyexternalurl-dialog
Add option to copy URL rather than open an external link
2022-08-24 21:55:41 +02:00
968f656585 Merge branch 'master' into copyexternalurl-dialog 2022-08-24 21:21:11 +02:00
e7cbb6c63d Fix test failures/nullability 2022-08-24 19:53:16 +09:00
2af8c4a2ea Merge pull request #19904 from novialriptide/add-date-created-sort
Add date submitted sorting
2022-08-24 17:43:28 +09:00
6a0d23cf96 Nest dialog class and apply NRT 2022-08-24 17:39:22 +09:00
9f9deef438 Reword slightly 2022-08-24 17:37:41 +09:00
cc648a90bc Actually save maximum statistics 2022-08-24 17:28:41 +09:00
d947a6cb59 Add Realm migration 2022-08-24 17:28:41 +09:00
f70af779a4 Add maximum statistics to ScoreInfo/SoloScoreInfo 2022-08-24 17:28:41 +09:00
ddccf4defe Remove dollar sign 2022-08-24 17:17:59 +09:00
854121c600 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-24 17:16:04 +09:00
0fd6f90848 Merge pull request #19934 from novialriptide/copyexternalurl-user
Add profile url context menu to user container
2022-08-24 17:14:06 +09:00
27b57947e4 Rename PlayerArea.GameplayClock to SpectatorPlayerClock for clarity 2022-08-24 17:13:14 +09:00
5f01f461b3 Ensure elapsed time is always non-zero when advancing SpectatorPlayerClock 2022-08-24 17:13:14 +09:00
9ee26c575d Made button blue 2022-08-24 04:04:44 -04:00
af56cd0126 Fix merge breakage 2022-08-24 16:52:36 +09:00
5079e0d83d Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-24 16:52:10 +09:00
b5c244e624 Merge pull request #19936 from peppy/catch-up-woes-2
Move `MasterClockState` handling in to `SpectatorSyncManager`
2022-08-24 16:48:28 +09:00
ec5fd7ac1d Remove possible 'System.NullReferenceException' 2022-08-24 03:42:16 -04:00
b24513038c Add popupdialog button to copy url 2022-08-24 03:35:19 -04:00
a8867d4245 Merge branch 'master' into add-date-created-sort 2022-08-24 03:23:27 -04:00
6344b87b14 Merge branch 'master' into copyexternalurl-user 2022-08-24 03:12:00 -04:00
7f9246637a Simplify MultiSpectatorScreen hierarchy construction 2022-08-24 16:08:48 +09:00
edd50dc05b Add profile url context menu to user container 2022-08-24 03:07:03 -04:00
7c1fc4814e Remove unused CreateMasterGameplayClockContainer method 2022-08-24 16:03:38 +09:00
871365bbb0 Inline ReadyToStart action binding for added safety 2022-08-24 16:03:38 +09:00
6c50f618a3 Don't use bindable flow for masterState 2022-08-24 16:03:38 +09:00
683d49c608 Move MasterClockState handling in to SpectatorSyncManager 2022-08-24 16:03:38 +09:00
d33d705684 Make WaitingOnFrames non-bindable 2022-08-24 16:03:38 +09:00
d05d8aeb22 Simplify interface implementations 2022-08-24 16:03:38 +09:00
2f5be6efca Tidy up ProcessFrame and privatise const 2022-08-24 16:03:38 +09:00
b564c34dbc Don't process master clock (is a noop) 2022-08-24 16:03:38 +09:00
f5a71ecdfe Merge pull request #19933 from peppy/catch-up-woes
Tidy up spectator clock/manager naming and interfaces
2022-08-24 16:03:29 +09:00