a2affefb0a
Avoid checking gameplay clock time in Update method
2022-02-02 14:33:17 +09:00
c7a192cc5f
Only handle LeftButton and RightButton actions
...
There are definitely going to be other actions used in the future, which
would immediately cause this mod to fail. Limiting handling to
left/right buttons only is the correct way forward.
2022-02-02 14:04:12 +09:00
fed63abd83
Sanitise interceptor logic to now require two separate check paths
2022-02-02 14:02:48 +09:00
0036d0e26d
Move alternate mod to "conversion" category
2022-02-02 13:58:13 +09:00
9227211a44
Privatise shouldAlternate
2022-01-31 22:56:27 +01:00
40f43344f1
remove unused using
2022-01-29 23:31:26 +08:00
535216a0d3
rename CanIntercept to ShouldAlternate
2022-01-29 23:20:31 +08:00
e408d8ef0e
rename Frames to ReplayFrames
2022-01-29 23:19:51 +08:00
a8eb3f95df
add readonly modifier
2022-01-29 22:54:17 +08:00
1087d8b1ce
add tests
2022-01-29 22:31:31 +08:00
b4e516c535
allow test scenes to specify replays manually
2022-01-29 22:31:24 +08:00
24f9ef4005
make xmldoc more verbose
2022-01-29 22:31:04 +08:00
98d8b26a9c
move ModAlternate to OsuModAlternate and check if intro has ended
2022-01-29 21:49:40 +08:00
2326c36836
remove unused method and fix description
2022-01-29 21:09:36 +08:00
aa582fb0e1
add Alternate Mod
2022-01-29 20:38:12 +08:00
8883505eed
Merge pull request #16686 from peppy/fix-ar-on-old-maps
...
Fix approach rate not being transferred from OD on older beatmaps
2022-01-28 20:17:37 +09:00
261cc6d031
Merge pull request #16687 from peppy/update-framework
...
Update framework
2022-01-28 20:17:23 +09:00
bda3cdc9a7
Add tests
2022-01-28 19:29:30 +09:00
4f2e98f3ef
Merge pull request #16683 from peppy/no-scope-test-lenience
...
Increase lenience of alpha check in `TestSceneOsuModNoScope`
2022-01-28 19:13:00 +09:00
53ca597e2b
Update framework
2022-01-28 19:12:32 +09:00
142a67e163
Fix approach rate not being transferred from OD on older beatmaps
2022-01-28 18:53:28 +09:00
17f0d7897b
Increase lenience of alpha check in TestSceneOsuModNoScope
...
I believe the [test
failures](https://github.com/ppy/osu/runs/4977283066?check_suite_focus=true )
we're seeing here are due to the implementation of interpolation of the
alpha being frame dependent (in a way that doesn't interact well with
tests). The reason for never hitting the expected value is that the
beatmap ends, causing the cursor to become fully visible again.
It's probably already good-enough for most cases, so let's attempt to
silence these test failures by not checking so precisely for the alpha
value.
We're checking for either 1 or 0 so it's not too important how close it
is to either.
2022-01-28 18:36:00 +09:00
f021a274d2
Merge pull request #16681 from peppy/fix-delete-local-scores
...
Fix delete local scores via "Clear all scores" button crashing the game
2022-01-28 17:01:31 +09:00
bdc9ca40f2
Merge pull request #16676 from peppy/fix-editor-custom-ruleset
...
Fix editor crashing on custom rulesets due to `ChangeHandler` not being supported
2022-01-28 16:26:56 +09:00
c7f8528d63
Merge pull request #16673 from peppy/fix-polling-component-thread-safety
...
Fix occasional non-fatal errors from polling API requests incorrectly getting queued twice
2022-01-28 16:26:47 +09:00
b94984bd2d
Merge pull request #16678 from peppy/hold-for-menu-always-fade
...
Ensure hold for menu button fades out if the cursor is never moved
2022-01-28 15:55:41 +09:00
0d3ac4fd9c
Fix delete local scores crashing the game
2022-01-28 15:54:53 +09:00
2453bf5ed0
Add test coverage of the same thing but via "clear all scores" button
2022-01-28 15:54:53 +09:00
778eebc94d
Add test coverage of local score import and deletion
2022-01-28 15:50:36 +09:00
cb7ae413fe
Ensure test game is always active
2022-01-28 15:50:35 +09:00
0bba8a52c6
Merge pull request #16663 from bdach/beatmap-info-defaults
...
Change some beatmap info/metadata defaults in a backwards compatible manner
2022-01-28 15:41:20 +09:00
ea716194e9
Merge pull request #16677 from peppy/fix-incorrect-null-null-equality
...
Fix a couple of cases of incorrect equality checks in the case both values are null
2022-01-28 15:41:09 +09:00
32f9299fe0
Remove unused using
2022-01-28 15:26:29 +09:00
28c8e07e3f
Ensure hold for menu button fades out if the cursor is never moved
...
Closes https://github.com/ppy/osu/discussions/16669 .
2022-01-28 14:48:35 +09:00
f32d56e213
Bring HoldForMenuButton tests up-to-date in code quality
2022-01-28 14:48:17 +09:00
b7d8c9bf06
Fix a couple of cases of incorrect equality checks in the case both values are null
2022-01-28 14:29:56 +09:00
b3856c9005
Fix editor crashing on custom rulesets due to ChangeHandler not being supported
...
As per https://github.com/ppy/osu/discussions/16668 , even without proper
saving support some ruleset developers do want to work on the editor.
This brings things back into a workable state.
2022-01-28 14:03:31 +09:00
91be77ad3d
Fix null ref in ComposeScreen when ruleset doesn't provide a composer
2022-01-28 14:01:10 +09:00
c953a5d503
Ensure PollingComponent.Poll is always called from the update thread
...
Not strictly required since all `Poll` implementations are now
threadsafe, but extra safety is never a bad thing?
2022-01-28 13:44:11 +09:00
c44af4853d
Add thread safety to PollingComponent.Poll implementations
2022-01-28 13:43:53 +09:00
6674567af1
Use -1 as the default preview time globally in metadata
2022-01-27 21:51:51 +01:00
1b8136e3e0
Change some BeatmapInfo defaults in a backwards compatible manner
2022-01-27 21:49:37 +01:00
7dc3940dee
Add test coverage for preserving legacy beatmap info defaults
2022-01-27 21:49:26 +01:00
d1158acb82
Merge pull request #16647 from peppy/song-select-scroll-position-during-delete
...
Ensure beatmap carousel scroll position is maintained during deletion operations
2022-01-27 21:22:15 +01:00
04d6ca59a3
Merge branch 'master' into song-select-scroll-position-during-delete
2022-01-27 20:46:19 +01:00
6beb0ff2a4
Merge pull request #16657 from peppy/skip-scores-missing-beatmap
...
Skip scores missing beatmaps during realm migration
2022-01-28 01:33:12 +09:00
8508e0d512
Merge pull request #16659 from bdach/fix-tournament-not-loading
...
Fix tournament client not loading
2022-01-28 01:32:59 +09:00
9deeaee404
Fix tournament client not loading
...
Caused by a `LoadComponentsAsync()` call being fired from a worker
thread, which will throw exceptions since the recent addition of safety
checks around that method.
2022-01-27 17:31:12 +01:00
942ea896f1
Skip scores missing beatmaps during realm migration
2022-01-28 01:20:32 +09:00
96f86d035d
Merge pull request #16652 from peppy/skip-beatmaps-missing-ruleset
2022-01-27 19:09:28 +03:00
