Commit Graph

48478 Commits

Author SHA1 Message Date
a5d422e82c Merge branch 'master' into ruleset-id-fixes 2022-01-27 17:07:18 +09:00
29a4ec949f Merge pull request #16637 from bdach/editor-changes-not-resetting
Fix changes to beatmap info made in editor persisting after exit without save
2022-01-27 17:02:42 +09:00
54d18bd7ac Merge pull request #16642 from peppy/ruleset-private-info-set
Make `Ruleset.RulesetInfo` get only
2022-01-27 16:41:52 +09:00
81ba1558de Merge pull request #16643 from peppy/ruleset-silly-ctor
Remove pointless constructor in `RulesetInfo`
2022-01-27 16:41:38 +09:00
9ff2b9eb95 Merge pull request #16640 from peppy/realm-migration-always-delete
Improve realm migration UX to give users a recovery path on error
2022-01-27 15:43:14 +09:00
5288eedd31 Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID 2022-01-27 15:38:03 +09:00
714177cce1 Remove pointless constructor in RulesetInfo 2022-01-27 15:37:27 +09:00
e67b1fe0ec Make Ruleset.RulesetInfo get only 2022-01-27 15:36:35 +09:00
cc0a8db76a Merge pull request #16639 from peppy/ef-db-delete-retry
Add more attempts to delete EF database
2022-01-27 15:31:40 +09:00
67ccb87992 Add exception message to discussion template url 2022-01-27 14:56:04 +09:00
fb081384e1 Add safety against zip creation potentially failing (probably can't but still) 2022-01-27 14:55:52 +09:00
465e7d29fe Avoid showing the external link warning 2022-01-27 14:53:11 +09:00
31abb372e5 Automatically zip and show the backup archive to the user 2022-01-27 14:52:58 +09:00
08948f60f3 Move backups to "backups" subfolder to make them easier to find 2022-01-27 14:39:13 +09:00
b745252962 Show notification when migration fails to give users a recovery path 2022-01-27 14:39:11 +09:00
deb5d75b5f Change migration process to always delete old EF database
It is already backed up, so this is probably fine.
2022-01-27 14:33:46 +09:00
587c0f965c Add more attempts to delete EF database
Just noticed in passing. Probably best we do this since it was known to
fail on windows in some rare cases.
2022-01-27 14:32:21 +09:00
e0616476e2 Fix test gameplay tests failing due to beatmap refetch on suspend 2022-01-26 21:15:49 +01:00
d760283665 Ensure edited beatmap is restored to a baseline state on exit 2022-01-26 21:15:49 +01:00
4382adad82 Add test coverage for editor changes not resetting after exit without save 2022-01-26 21:15:49 +01:00
de5ac7ad83 Merge pull request #16632 from LumpBloom7/Third-party-ruleset-filter-fix
Fix ruleset filters not working correctly on song select
2022-01-26 19:24:06 +01:00
df9658641c Merge branch 'master' into Third-party-ruleset-filter-fix 2022-01-26 18:54:20 +01:00
b7aa26bc5f Merge pull request #16633 from peppy/fix-collection-migration
Block collection loading until realm migration has completed
2022-01-26 18:12:19 +01:00
f70e10e8a4 Fix ruleset filter matching using OnlineID instead of ShortName 2022-01-27 01:25:57 +09:00
0c2ed2f9a7 Add failing test coverage of incorrect filter ruleset matching 2022-01-27 01:25:57 +09:00
f21e3d0d86 Block collection loading until realm migration has completed 2022-01-27 00:34:51 +09:00
6ec9c5c21a Use default custom ruleset ID 2022-01-26 16:23:00 +01:00
e712fab299 Add test for custom ruleset conversion filtering 2022-01-26 16:14:07 +01:00
873d367615 Fix custom rulesets not being able to convert maps 2022-01-26 15:51:39 +01:00
bab337591f Merge pull request #16630 from peppy/fix-null-mod-json-parse-fail
Fix some score imports failing due to null string attempted to be parsed as json
2022-01-26 23:15:23 +09:00
70acc4d0bd Merge pull request #16631 from frenzibyte/make-test-abstract
Mark `EditorSavingTestScene` as abstract to not appear in visual test browser
2022-01-26 23:10:09 +09:00
7f34085baa Mark EditorSavingTestScene as abstract 2022-01-26 17:04:30 +03:00
378173cc66 Fix some score imports failing due to null string attempted to be parsed as json 2022-01-26 22:46:29 +09:00
cf9ee43b17 Merge pull request #16608 from peppy/playlist-overlay-optimisations
Optimise `PlaylistOverlay` and reduce startup overhead of `MusicController`
2022-01-26 20:28:33 +09:00
a07fce55d4 Merge pull request #16606 from peppy/fix-out-of-order-events-on-block-fail
Fix notification reset events potentially arriving out of order if a block operation times out
2022-01-26 20:28:21 +09:00
0dd2de3e1e Merge pull request #16628 from peppy/fix-realm-ruleset-ordering
Fix custom rulesets being displayed before official ones
2022-01-26 19:19:01 +09:00
94d3e2c90c Merge branch 'master' into fix-out-of-order-events-on-block-fail 2022-01-26 19:08:55 +09:00
b3f2392358 Resolve compilation error due to removed method 2022-01-26 19:04:18 +09:00
abe2cccaae Fix completely invalid method of testing realm migration 2022-01-26 19:03:26 +09:00
cdca1285ab Merge branch 'master' into playlist-overlay-optimisations 2022-01-26 19:01:33 +09:00
b1a23486c5 Merge pull request #16626 from peppy/fix-skin-section-realm-usage
Refactor `SkinSection` to avoid unnecessary realm queries
2022-01-26 19:01:15 +09:00
f3924522a2 Merge pull request #16627 from peppy/fix-ruleset-import-failure
Fix realm migration failures with presence of databased EF rulesets that don't exist on disk
2022-01-26 18:59:20 +09:00
57e624d8e7 Fix custom rulesets being displayed before official ones 2022-01-26 18:46:32 +09:00
473c4d00ca Fix grouped difficulty icons using incorrect lookup for ruleset grouping 2022-01-26 18:38:44 +09:00
45636ce04b Remove collection ToLive helper method to avoid confusion 2022-01-26 18:26:37 +09:00
3aa681005b Skip importing scores which have no matching realm ruleset
There's no real way to recover these unless we want to start importing
rulesets into realm. And that seems counter productive. This can only
happen if users don't have the dll present any more, and it was removed
far before realm was tracking rulesets (else it would have an
`Available=0` entry in realm to match).
2022-01-26 18:04:54 +09:00
f2d48d088d Fix realm migration failures with presence of databased EF rulesets that don't exist on disk 2022-01-26 17:57:03 +09:00
d1a2256262 Refactor SkinSection to avoid unnecessary realm queries 2022-01-26 17:48:11 +09:00
885fb92aad Move final empty result set sending to post-compact 2022-01-26 17:21:57 +09:00
791ea0308f Add flag to guard against deadlocks during blocking operations 2022-01-26 17:09:28 +09:00