a7f40dc6d4
Merge branch 'remove-synchronous-prepare-score-method' into storyboard-outro-logic-refactor
2021-06-18 16:45:01 +09:00
45122594e5
Remove the synchronous version of PrepareScoreForResults
...
Replaces all existing usages with the `async` version.
2021-06-18 16:24:08 +09:00
f3426e38b4
Add note about delay parameter
2021-06-18 16:18:20 +09:00
3819a1f03b
Remove exit override behaviour
...
I don't actually know under what scenario this could have been hit, and
actually caused expected behaviour. Consider that in the scenario I
describe in the comment (which I added yesterday), the user is
requesting a pause or exit which would be "cancelled showing the results
instead". But in such a scenario, `PerformExit` would first be run,
which cancels the `resultsDisplayDelegate` in the first place.
The only special case would be pressing the close button on the window
decoration? Which I don't think should be a special case in the first
place, so I'm just going to remove this for the time being to keep
things simple.
2021-06-18 16:12:35 +09:00
06d1bd971c
Default DrawableStoryboard to a completed state to avoid state change on empty storyboards
2021-06-18 16:08:49 +09:00
7ef8eac773
Remove unnecessary (and no longer correct) exception
2021-06-18 16:08:31 +09:00
2bf855fcca
Move all storyboard outro skip logic out of updateCompletionState
...
This method should only be called to trigger the score completion
portion of player progression. The storyboard skip/end logic is now
handled separately in `progressToResults`.
2021-06-18 15:50:43 +09:00
2cd72a92e8
Merge pull request #13499 from ekrctb/fix-mania-editor-crash
...
Rewrite mania selection blueprint to use only `HitObject` (no `DrawableHitObject`) for layout
2021-06-18 15:10:28 +09:00
93eec009f8
Merge pull request #13544 from smoogipoo/split-files
...
Move IApplicableToDrawableHitObjects to its own file
2021-06-18 13:54:03 +09:00
cdc1c60fab
Merge branch 'master' into fix-mania-editor-crash
2021-06-18 13:49:25 +09:00
97cd1217a4
Move IApplicableToDrawableHitObjects to its own file
2021-06-18 13:06:13 +09:00
d238c7ff9c
Merge pull request #13541 from peppy/player-completion-refactoring
2021-06-18 10:47:50 +09:00
f282326f9a
Move score preparations back below ShowResults check
2021-06-17 19:04:52 +02:00
3a1444e75d
Fix malformed xmldoc tag
...
Oops. Made a typo in the PR suggestion.
2021-06-17 19:02:56 +02:00
9facfe8964
Apply suggestions from code review
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2021-06-18 01:07:54 +09:00
e0a3696145
Merge branch 'master' into player-completion-refactoring
2021-06-17 23:51:42 +09:00
880a008e01
Merge pull request #13540 from peppy/player-pause-exit-results-flow-refactoring
2021-06-17 16:42:18 +02:00
aae2923e14
Merge branch 'master' into player-pause-exit-results-flow-refactoring
2021-06-17 16:05:09 +02:00
10b0d066be
Reword comments slightly
2021-06-17 16:04:58 +02:00
561dbea9e1
Use xmldoc-specific syntax for nicer formatting
2021-06-17 15:26:50 +02:00
6cec1145e3
Merge pull request #13523 from ekrctb/applicable-to-dho
...
Reduce boilerplate of `IApplicableToDrawableHitObjects` by taking a single DHO instead of an enumerable
2021-06-17 19:59:06 +09:00
77a0e9145d
Merge pull request #13539 from peppy/improve-updateable-avatar-tooltip-handling
...
Fix edges of participant tiles showing incorrect tooltip
2021-06-17 19:14:40 +09:00
d03c6da60c
Refactor and redocument updateCompletionState() and surrounding methods
2021-06-17 19:13:53 +09:00
246ab41cc6
Remove special casing for user exit during storyboard outro
2021-06-17 18:11:15 +09:00
7cbebe6d11
Rewrite xmldoc and inline comments for PerformExit
2021-06-17 18:10:59 +09:00
a72151d4e1
Merge pull request #13535 from peppy/fix-hitcircle-approach-circle-early-hit
...
Fix approach circle fade not running early on an early user hit
2021-06-17 16:37:11 +09:00
79af80833f
Merge pull request #13537 from peppy/fix-author-info
...
Improve code quality of `AuthorInfo`
2021-06-17 16:34:45 +09:00
b043f63fe4
Merge pull request #13538 from peppy/remove-redundant-not-null
...
Remove redundant `NotNull` attributes in `nullable` classes
2021-06-17 16:34:32 +09:00
a0e5301c9f
Update usages of showGuestOnNull
2021-06-17 16:33:43 +09:00
808b2baa41
Consume new behaviour to fix UserTile discrepancy
...
Closes https://github.com/ppy/osu/issues/13522 .
2021-06-17 16:31:12 +09:00
d9cc1c227b
Allow UpdateableAvatar to handle displaying username as tooltip
2021-06-17 16:31:12 +09:00
ccba6b5ac2
Fix test failures
2021-06-17 16:13:47 +09:00
9495f87f04
Remove redundant NotNull attributes in nullable classes
2021-06-17 16:07:32 +09:00
8da0431fa0
Improve code quality of AuthorInfo
2021-06-17 16:05:50 +09:00
8e45f26617
Merge branch 'master' into applicable-to-dho
2021-06-17 15:23:56 +09:00
a46f730a69
Fix approach circle fade not running early on an early user hit
...
Regressed in https://github.com/ppy/osu/pull/12153 .
Closes https://github.com/ppy/osu/issues/13531 .
2021-06-17 15:09:05 +09:00
6d0b3efa23
Reorganise existing tests into hits and misses
2021-06-17 15:08:09 +09:00
249ae3141e
Add early/late tests for hit circles
2021-06-17 15:06:56 +09:00
a4f362dca6
Remove lifetime override of DrawableManiaHitObject
...
The `AlwaysAlive` logic is now in all DHOs and it is now not necessary (and potentially conflicting).
2021-06-17 10:15:24 +09:00
9dcd0bf311
Remove IPlayfieldProvider by caching Playfield
2021-06-17 10:15:24 +09:00
418dbf3f3e
Merge branch 'master' into fix-mania-editor-crash
2021-06-16 18:26:33 +02:00
044ff9d1d2
Merge pull request #13516 from smoogipoo/beatmap-listing-enum-localisation
2021-06-16 18:26:02 +02:00
191f47f5ee
Merge branch 'master' into beatmap-listing-enum-localisation
2021-06-16 17:44:16 +02:00
a8b65d8417
Merge pull request #13430 from pavlukivan/taiko-hd-mod
...
Add osu!taiko "Hidden" mod
2021-06-16 23:24:04 +09:00
90a13b8ed3
Use IApplicableToDrawableHitObject for OsuModApproachDifferent
...
Replacing the obsolete interface.
2021-06-16 22:05:40 +09:00
b6a9fa9999
Merge branch 'master' into applicable-to-dho
2021-06-16 22:04:10 +09:00
bacb916c03
Merge pull request #13524 from smoogipoo/fix-hud-test-failure
...
Fix intermittent HUD test failure
2021-06-16 21:53:58 +09:00
0eb0c66140
Merge pull request #13525 from smoogipoo/high-performance-session
...
Add HighPerformanceSession and use LowLatency GC in gameplay
2021-06-16 21:39:14 +09:00
19f0e3d695
Add HighPerformanceSession
2021-06-16 20:53:48 +09:00
a295421b64
Use language-specific lookup key for Other filter
2021-06-16 13:27:02 +02:00
