a8ffc4fc2a
Add editor override to respect IsolateSavingFromDatabase
2022-02-02 21:57:21 +01:00
47429fb0c6
Fix same-name safety firing wrongly
2022-02-02 21:57:21 +01:00
afc48d86df
Add failing test coverage for save after safeties addition
2022-02-02 21:57:10 +01:00
4f1aac9345
Add safeties preventing creating multiple difficulties with same name
2022-02-02 21:57:09 +01:00
87e2e83288
Add test coverage for difficulty name clash cases
2022-02-02 21:55:34 +01:00
54bb6ad40c
Fix working beatmaps not seeing new difficulties after add
2022-02-02 21:55:34 +01:00
0d51c015ad
Add basic test coverage for new difficulty creation
2022-02-02 21:55:34 +01:00
dc96c4888b
Add support for creating new blank difficulties
2022-02-02 21:55:33 +01:00
b613aedeb8
Fix menu item width changing when hovered
2022-02-02 21:23:35 +01:00
3386f038ba
Add new difficulty creation menu
2022-02-02 21:23:35 +01:00
e2fcdc394b
Extract method for difficulty switch menu creation
2022-02-02 21:23:35 +01:00
3a5099cf06
Merge pull request #16748 from frenzibyte/explicit-diffadjust-keyboard-step
...
Use `0.1` keyboard step for "Difficulty Adjust" sliders
2022-02-03 00:22:23 +09:00
074a691635
Set keyboard step to 0.1 for difficulty adjust sliders
2022-02-02 17:43:08 +03:00
f777347aaf
Merge pull request #16742 from smoogipoo/fix-multi-swap-mod-crash
...
Fix crash when selecting non-osu! ruleset mods as freemod
2022-02-02 19:14:10 +09:00
b5fb3b7dae
Fix crash when selecting swap mod as freemod
2022-02-02 18:42:22 +09:00
db0f3b7f5e
Merge pull request #16738 from peppy/fix-ruleset-incorrectly-loading
...
Fix rulesets potentially being marked `Available` even when methods are missing
2022-02-02 18:03:04 +09:00
6260c5fc13
Merge pull request #16739 from nekodex/cursor-tap
...
Add cursor 'tap' audio feedback
2022-02-02 17:02:33 +09:00
cb31ce812c
Merge branch 'master' into cursor-tap
2022-02-02 16:34:34 +09:00
4758de226b
Update resources
2022-02-02 16:27:59 +09:00
0c5da9370a
Fix rulesets potentially being marked Available even when methods are missing
...
Came up when running the game after the recent breaking changes
(https://github.com/ppy/osu/pull/16722 ), where two template rulesets I
had loaded were erroring on startup but still being marked as available,
allowing them to crash the game on attempting to initiate relpay logic.
These cases are already handled for first-time ruleset loading via the
`GetTypes()` enumeration in `RulesetStore.addRuleset`, but when
consistency checking already present rulesets the only runtime
validation being done was `ruleset.CreateInstance()`, which does not
handle missing types or methods.
2022-02-02 14:52:01 +09:00
6e60e68b80
Change from click to mousedown+mouseup and only play when cursor is visible
2022-02-02 14:44:06 +09:00
6d962e7925
Merge pull request #16726 from dekrain/leaderboard-score-tooltip
...
Add basic tooltip for leaderboard scores
2022-02-02 13:56:45 +09:00
4b646709c1
Merge pull request #16658 from Spooghetti420/no-long-notes-mod
...
Add "Hold Off" mod (no long notes)
2022-02-02 13:35:44 +09:00
ddc8094a75
Update description
2022-02-02 13:34:23 +09:00
d065e32ca1
Fix crash due to MatchLeaderboardScores not having populated rulesets
2022-02-02 13:23:49 +09:00
35b7653290
Revert mod flow changes and add visual test coverage showing an overflow case
2022-02-02 09:13:19 +09:00
6033c89e7b
Merge pull request #16734 from bdach/war-on-unused-params
...
Fix several cases of unused constructor and method parameters
2022-02-02 07:40:58 +09:00
3674ed15ce
Remove unused game host parameter
...
No longer used since eeccf836ec
2022-02-01 21:53:21 +01:00
b978010b48
Remove unused allowMissing parameter in audio file check test
...
No longer used since 7f95400f46
2022-02-01 21:53:21 +01:00
7cdf63c654
Remove unused FindProvider() methods
...
No longer needed since 39f99bf785
2022-02-01 21:53:21 +01:00
e4028b8fc1
Remove index ctor param from ColumnHitObjectArea
...
No longer used since 5692cecaa4
2022-02-01 21:49:52 +01:00
e042f29ee3
Remove skin ctor param from LegacyCatchComboCounter
...
No longer used since 004798d61d
2022-02-01 21:49:52 +01:00
75101b1105
Remove unused ruleset ctor params from test beatmap model managers
...
No longer used since 00e3af3366
2022-02-01 21:49:41 +01:00
994fb966b6
Remove Host ctor param from SkinModelManager
...
No longer used since 29d074bdb8
2022-02-01 21:37:19 +01:00
07d09b3520
Remove unused parameter from createGameplayComponents()
...
No longer used since 136843c8e4
2022-02-01 21:35:41 +01:00
a94702b3ae
Remove unused parameters in LegacyComboCounter
...
No longer used since 9bb8a43bce
2022-02-01 21:35:41 +01:00
1fa2bf5d69
Remove unused parameter from createColourBars()
...
No longer used since b61aa660c6
2022-02-01 21:35:40 +01:00
c6a65ccfed
Remove unused parameter from createContent()
...
No longer used since 513e470b52
2022-02-01 21:35:40 +01:00
16e0cc6a2b
Remove IIpcHost param from ScoreManager
...
No longer used since 3e3b9bc963
2022-02-01 21:35:40 +01:00
a378e78ced
Fix RealmLive unnecessarily passing ID around
...
Appears to have never been needed. When the `retrieveFromID` method was
created in 81b5717ae7
2022-02-01 21:35:12 +01:00
3d7af805a3
Fix BeatmapMetadata not using its user param correctly
2022-02-01 21:16:28 +01:00
eee020f8e4
Cleanup tooltip layout
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2022-02-01 20:26:52 +01:00
b75c08c9ab
Improve beat length logic
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2022-02-01 13:36:36 +00:00
2c0c44a950
Merge pull request #16722 from smoogipoo/spectator-consistency-frames
...
Implement spectator consistency frames
2022-02-01 17:28:13 +09:00
15479ae046
Add test coverage of no header doing nothing
2022-02-01 16:55:28 +09:00
0f83f77d2b
Add xmldoc for new ResetFromReplayFrame method
2022-02-01 16:52:53 +09:00
f87920cd83
Remove unnecessary GridContainer and list mods verticall to give more space
2022-02-01 16:43:26 +09:00
8eace12fe3
Synchronise (roughly) backgrounds of all custom tooltips
2022-02-01 16:35:25 +09:00
3ca2c90684
Add test scores in BeatmapLeaderboard test scene with more mods
2022-02-01 16:35:25 +09:00
fdb52a8fd7
Remove gap in tooltip display between statistics
2022-02-01 16:35:25 +09:00
