8ebc2ae03d
Never run subtree masking
2020-04-20 20:48:35 +09:00
6f233917b1
Centralize updating HasCompleted bindable logic
2020-04-20 06:40:51 +03:00
1dcb0f53a2
Fix whitespace formatting
2020-04-19 16:29:32 +02:00
ba1c465edf
Add comment in regards to the attaching of event handler to the assembly lookup event before call to loadUserRulesets().
2020-04-19 15:26:00 +02:00
a7179d1c87
Fix comment wording
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2020-04-19 15:15:04 +02:00
fc6c245de5
Replace all judged event logic with HasCompleted bindable
2020-04-19 05:36:04 +03:00
ae210d567d
Add temporary solution for tick hit/miss count
2020-04-16 18:16:08 +09:00
9dda7da489
Fix spinners being considered the "first object" for increased visibility in hidden
2020-04-16 14:11:38 +09:00
4eefe47ce3
Merge branch 'master' into fix-0-customsampleset
2020-04-16 11:20:31 +09:00
44981431c5
Remove suffix hackery
2020-04-14 21:33:32 +09:00
6935221463
Improve logic for CSB transfer
2020-04-14 21:05:07 +09:00
06407a1081
Merge branch 'master' into fix-classic-scoring
2020-04-14 02:13:45 +02:00
13c81db0cf
Fix incorrect classic score formula
...
Upon closer inspection the classic score formula was subtly wrong. The
version given in the wiki is:
Score = Hit Value + (Hit Value * ((Combo multiplier * Difficulty
multiplier * Mod multiplier) / 25))
The code previously used:
bonusScore + baseScore * ((1 + Math.Max(0, HighestCombo.Value - 1)
* scoreMultiplier) / 25);
which is not equivalent to the version on the wiki. The error is in the 1
factor, as in the above version it is being divided by 25, while it should
be outside the division to keep parity with the previous formula.
The tests attached in the previous commit demonstrate that this change
causes a single hit without combo to increase total score by its exact
numeric value.
2020-04-14 01:09:58 +02:00
63de493c85
Merge branch 'master' into fix-red-point-placement
2020-04-13 20:56:50 +09:00
58a7313091
Fix fallback for file hit samples
2020-04-13 20:09:17 +09:00
cee4b005e6
Fix custom sample set 0 not falling back to default samples
2020-04-13 20:00:06 +09:00
f38b64d201
Fix placement blueprints handling double clicks
2020-04-13 13:57:15 +09:00
c51bad0e35
Cache ManiaPlayfield instead
2020-04-13 13:42:21 +09:00
cdff6060d3
Remove recursive hierarchy traversal for mania sample balance
2020-04-13 13:01:27 +09:00
65b96079a0
Move dampening to base implementation and change range to 0..1
2020-04-13 13:01:02 +09:00
22d89dbff7
Merge branch 'master' of https://github.com/ppy/osu into stereo-shifted-playback
2020-04-12 01:46:32 +02:00
f274ec297c
Add positional sound support for all rulesets
...
The SamplePlaybackBalance is calculated in a way that the balance
remains between -0.4 and 0.4.
Positional sound is not supported in osu!taiko.
2020-04-12 01:33:25 +02:00
97340da2f2
Add null-conditional to acesses in dispose methods
...
Such a terrible mistake, the finalizer may be called while the dependencies have an instance but the local itself doesn't have a value yet.
2020-04-12 02:24:36 +03:00
31b494b0b7
Merge branch 'master' into cache-ruleset-dependencies-for-tests
2020-04-11 22:56:47 +03:00
a84fe2525b
Fix nested hitobjects potentially indirectly masked away
2020-04-11 16:53:45 +09:00
a314a6119a
Fix CI issues
2020-04-11 05:13:04 +03:00
2b4208bebf
Cache ruleset dependencies if the scene tests ruleset-specific components
2020-04-11 04:23:31 +03:00
235d3046c6
Move ruleset dependencies caching to its own container
2020-04-11 04:22:23 +03:00
c17e470266
Fix PositionalSound calculation implementation
...
The position used to calculate the stereo balance is now the position of
the drawable (as opposed to the position specified in the beatmap file
previously).
2020-04-10 00:01:35 +02:00
2201e9b4ae
Add stereo shifted hitsound playback support
...
There is now a setting in the general settings called "Positional
hitsounds". If the setting is enabled, the hitsounds playback will be
shifted according to their position on the beatmap.
2020-04-09 18:12:15 +02:00
ee6ea08cf8
Cleanup handling of hitobject updates
2020-04-09 20:16:44 +09:00
2087d8d09e
Don't search for user rulesets if rulesetsStorage isn't set (Testing environnment)
2020-04-07 16:01:47 +02:00
08308e07e7
Apply review suggestions
2020-04-07 12:22:09 +02:00
7fab07670e
Remove no longer necessary usage of IsBreakTime
2020-04-05 21:35:09 +03:00
e71a9668a5
Disallow draining in non-draining sections
2020-04-05 21:34:53 +03:00
0e45a4d54e
Add back cached ruleset assembly lookup
2020-04-04 20:13:46 +02:00
8cdae790c3
Load user rulesets from the game data directory
2020-04-03 21:40:09 +02:00
7b2144a1a7
Fix merge mishap
2020-04-03 23:31:46 +09:00
3289fa7c66
Merge branch 'master' into better-mania-scrollspeed
2020-04-03 23:25:14 +09:00
eacbb20d87
Merge branch 'master' into fix-convert-scroll-speed
2020-04-03 22:47:53 +09:00
d90db5649d
Improve comment slightly
2020-04-03 18:32:07 +09:00
1ff2cc31d1
Implement more familiar scroll speed options in mania
2020-04-03 18:25:01 +09:00
b42d1104b7
Fix mania converts scrolling at incorrect speeds
2020-04-03 13:16:01 +09:00
1f797207f7
Rework lookups to not require total playfield columns
2020-04-03 12:31:05 +09:00
66486b094c
Remove unnecessary dependency, allow null mods
2020-04-01 13:31:17 +09:00
03cd9aa060
Merge branch 'master' into spun-out
2020-03-30 12:31:53 +09:00
7db9bd798c
Remove handle overrides
2020-03-30 11:59:51 +09:00
2abb8a37df
Merge branch 'master' into show-mod-settings-tooltip
2020-03-29 14:35:04 +09:00
a2b3fe180e
Add the ability to disable user input on specific DrawableHitObjects
2020-03-29 14:30:45 +09:00
005a818f32
Merge branch 'master' into fix-slider-end-sounds
2020-03-27 19:26:32 +09:00
