aa9e642e40
Merge branch 'master' into pin-multiplayer-host
2022-03-25 16:49:35 +09:00
8553adc401
Merge pull request #17443 from peppy/fix-unexpected-immediate-exit
...
Fix game unexpectedly exiting without outro sequence occasionally on macOS
2022-03-25 15:57:57 +09:00
478174dd58
Merge pull request #17416 from peppy/skin-fuck
...
Refactor skin construction
2022-03-25 15:36:06 +09:00
416b57ea69
Fix main menu buttons handling keys when super (cmd) is held
2022-03-25 15:13:22 +09:00
816fcae3a1
Rename Button to MainMenuButton to differentiate better
2022-03-25 15:12:39 +09:00
c6182c2b09
Merge pull request #17432 from peppy/realm-subscription-any-thread
...
Allow realm subscriptions to be initiated from any thread
2022-03-25 14:05:03 +09:00
09c5325b08
Update resources
2022-03-25 13:18:49 +09:00
b4c0155b3d
Update framework
2022-03-25 13:07:21 +09:00
def2ce243f
Merge pull request #17431 from peppy/fix-participants-panel-null-ref
...
Guard against potential null `CurrentItem` in `ParticipantPanel`
2022-03-25 11:47:43 +09:00
e58b742728
Merge pull request #17429 from peppy/fix-old-legacy-replays
...
Fix replays set on old beatmaps having incorrect timing
2022-03-24 23:45:42 +01:00
5f730c0cd4
Merge branch 'master' into fix-old-legacy-replays
2022-03-24 23:21:50 +01:00
959f200638
Merge pull request #17425 from peppy/fix-realm-import-test-assert-failure
...
Fix realm potentially not being refreshed in time for test asserts in `BeatmapImporterTests`
2022-03-24 22:16:25 +01:00
878e8d21a3
Remove assertion to fix "expression always true" inspection
2022-03-24 21:51:10 +01:00
b76cd2beae
Merge branch 'master' into fix-realm-import-test-assert-failure
2022-03-24 21:48:10 +01:00
b04ca111c6
Allow realm subscriptions to be initiated from a non-update thread
2022-03-24 23:41:07 +09:00
2938f44e6c
Update PresentExternally usages in line with framework changes
2022-03-24 23:41:07 +09:00
2d58feebb1
Guard against potential null CurrentItem in ParticipantPanel
2022-03-24 17:54:21 +09:00
e889d93441
Add asserts of playlist being non-empty after client operations
2022-03-24 17:52:20 +09:00
d7faff15c0
Merge pull request #17326 from smoogipoo/multiplayer-countdown-timers-2
...
Implement multiplayer countdown timers
2022-03-24 17:50:53 +09:00
0275e974e5
Merge branch 'master' into multiplayer-countdown-timers-2
2022-03-24 17:24:00 +09:00
e3f8bc0588
Revert Availability to private
2022-03-24 17:15:17 +09:00
528ffea38d
Fix incorrect event binding
2022-03-24 17:11:08 +09:00
d6fc53579e
Split out shared code for encode-decode cycle (and remove unrelated culture set)
2022-03-24 17:00:49 +09:00
a7554dcdf7
Use a constant for the early version timing offset
2022-03-24 16:43:41 +09:00
2efae031c9
Add test coverage of decode specifically
2022-03-24 16:39:56 +09:00
59a7eb5322
Add test coverage ensuring offsets are correct before and after legacy replay encode
2022-03-24 16:34:21 +09:00
dfa076c169
Refactor cancellation logic
2022-03-24 16:29:59 +09:00
a7d5f2281c
Apply beatmap offsets to legacy replay frame handling
2022-03-24 16:16:40 +09:00
4c0d76573c
Asserate code is running on update thread
2022-03-24 15:51:30 +09:00
f0d132b16e
Rename FinishCountdown() -> SkipToEndOfCountdown()
2022-03-24 15:21:46 +09:00
d2ecc100e5
Revert unnecessary async change
2022-03-24 15:07:24 +09:00
8f3a4df70a
Add explanation for try-catch
2022-03-24 15:07:24 +09:00
d36944ac95
Dispose token manually
...
Cover more branches with cancellation source disposal
2022-03-24 15:07:24 +09:00
96a447f68b
Rename Multiplayer prefix to button classes
2022-03-24 14:28:38 +09:00
90c7945bca
Re-remove PopoverButton class with better test fix
2022-03-24 14:26:31 +09:00
4d0b4c2541
Fix realm potentially not being refreshed in time for test asserts in BeatmapImporterTests
...
As seen at https://github.com/ppy/osu/runs/5659368512?check_suite_focus=true
Went through every usage of `.Import` and added either an
`EnsureLoaded`, or where that provides too many checks, an explicit
`realm.Refresh()`.
2022-03-24 12:59:17 +09:00
e243a7c55d
Reword storage param xmldoc to use stronger and better defined langauge
2022-03-24 12:45:11 +09:00
0cd29a73b9
Fix typo in xmldocs
2022-03-24 12:39:47 +09:00
a4d17a915f
Fix incorrect HUD component fallback
...
Legacy skins should now always show the legacy hud components. The
conditional here is no longer valid as fallback lookups happen at a
*skin*-fallback level rather than internal *source*-fallback.
Put another way, `LegacyDefaultSkin` (with user customisations) should
still display the classic HUD components even if a font is not provided,
as that font will be available via the skin lookup hierarchy.
The TODO removed in this commit has been already resolved so this code
is no longer required.
2022-03-24 12:36:20 +09:00
3b97de04b7
Merge pull request #17419 from peppy/fix-hitsound-regresssssssion
...
Fix hitsounds not always playing when they should
2022-03-24 11:53:18 +09:00
547418e47e
Revert "Remove PopoverButton class"
...
This reverts commit 6b712be97d
2022-03-24 11:15:51 +09:00
05c7e09d79
Make Textures and Samples read-only
2022-03-24 00:02:38 +09:00
c079a9cd32
Add comment regarding equality check importance in LegacyHitSampleInfo
2022-03-23 20:18:44 +09:00
997c091a8d
Revert "Remove IsLayered from LegacyHitSampleInfo comparison"
...
This reverts commit 4523393208
2022-03-23 20:15:17 +09:00
2ea9e5245c
Revert "Remove IsLayered from GetHasCode implementation"
...
This reverts commit 16ee6b5fc7
2022-03-23 20:15:13 +09:00
34a367b369
Merge branch 'master' into multiplayer-countdown-timers-2
2022-03-23 15:40:50 +09:00
6542f974f2
Merge branch 'master' into skin-fuck
2022-03-23 15:30:22 +09:00
a83a90e675
Rename countdown Delay -> Duration
2022-03-23 15:21:16 +09:00
f7c0047206
Send time remaining in countdowns instead
2022-03-23 15:19:43 +09:00
078288a616
Make "skin.ini" the default skin filename and remove redundant parameters
2022-03-23 15:05:01 +09:00
