Commit Graph

38966 Commits

Author SHA1 Message Date
ab6239fd5f change math for displaying volume "MAX" 2021-05-10 00:51:58 +02:00
2bcf1ed306 Merge pull request #12715 from Cublibre/fix-early-exit-crash
Fix InvalidOperationException when exiting a map at the end
2021-05-09 23:21:19 +09:00
a480e530fb Merge pull request #12706 from peppy/skin-components-bind-outwards-accuracy
Update `AccuracyCounter` components to use DI to attach data source
2021-05-09 20:10:23 +09:00
eb716455b7 Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-09 12:13:18 +02:00
a669f90ae7 Merge pull request #12727 from EVAST9919/news-fix
Hide "Show More" button in news overlay if returned cursor is null
2021-05-09 18:50:35 +09:00
879c08e666 Use UntilStep instead of Assert to check button visibility 2021-05-09 10:06:36 +03:00
f0c1784d05 Use FirstOrDefault instead of First 2021-05-09 09:12:37 +03:00
8868439ce4 Another approach to fix test scene failure 2021-05-09 06:49:12 +03:00
0818deac17 Fix potential test scene failure due to showMoreButton not being loaded in time 2021-05-09 06:06:34 +03:00
ae2b5a0806 Actually test that player was exited 2021-05-08 22:42:14 -04:00
dde9fd28e6 Hide ShowMore button if there's nothing to load 2021-05-09 04:57:24 +03:00
342c5a5938 Add tests to indicate the issue 2021-05-09 04:49:40 +03:00
0e91e6a155 Merge pull request #12724 from bdach/remove-current-from-legacyscorecounter
Remove vestigial `Current` reimplementation from `LegacyScoreCounter`
2021-05-09 05:01:53 +09:00
ea066cddc9 Merge pull request #12722 from bdach/fix-beatmap-listing-temporary-files
Fix temporary files from beatmap downloads not being cleaned up
2021-05-09 04:51:48 +09:00
67cea6e762 Remove explicit binding to accuracy counter from overlay 2021-05-08 21:38:06 +02:00
efb9164658 Restore previous test scene logic 2021-05-08 21:35:12 +02:00
0bc6a026eb Merge branch 'master' into skin-components-bind-outwards-accuracy 2021-05-08 21:08:53 +02:00
c3bf6a0287 Remove weird vestigial Current reimplementation
Has no functional purpose anymore since the changes in the HUD element
data binding flow.
2021-05-08 21:01:37 +02:00
b4a9c7095f Merge pull request #12705 from peppy/skin-components-bind-outwards-score-display 2021-05-08 21:00:29 +02:00
dec5400c0a Merge branch 'master' into skin-components-bind-outwards-score-display 2021-05-08 19:58:19 +02:00
d5efab0648 Merge pull request #12670 from peppy/skin-components-bind-outwards 2021-05-08 19:57:51 +02:00
9e0ea494fd Merge branch 'master' into skin-components-bind-outwards 2021-05-08 19:04:56 +02:00
25312b3e88 Don't restart completion delegate on exit, revert exit behavior to lazer 2021-05-08 11:47:44 -04:00
fe86ee629e Fix temp files from beatmap listing imports not being cleaned up
As reported in #12718, it turns out that temporary files from beatmap
set downloads performed via the beatmap listing overlay could remain in
the user's filesystem even after the download has concluded.

The reason for the issue is a failure in component integration.
In the case of online downloads, files are first downloaded to a
temporary directory (`C:/Temp` or `/tmp`), with a randomly generated
filename, which ends in an extension of `.tmp`.

On the other side, `ArchiveModelManager`s have a `ShouldDeleteArchive()`
method, which determines whether a file should be deleted after
importing. At the time of writing, in the case of beatmap imports the
file is only automatically cleaned up if the extension of the file is
equal to `.osz`, which was not the case for temporary files.

As it turns out, `APIDownloadRequest` has a facility for adjusting the
file's extension, via the protected `FileExtension` property. Therefore,
use it in the case of `DownloadBeatmapSetRequest` to specify `.osz`,
which then will make sure that the `ShouldDeleteArchive()` check in
`BeatmapManager` picks it up for clean-up.
2021-05-08 17:09:14 +02:00
13bd3e95a9 Merge pull request #12698 from peppy/fix-editor-slider-input-handling 2021-05-08 17:08:48 +02:00
01d732bb65 Revert "Refactor SliderSelectionBlueprint to not reference blueprint pieces for input handling"
This reverts commit 54fe10c82a.
2021-05-08 23:33:03 +09:00
63e267a3be Revert "Trim redundant this qualifier"
This reverts commit df630d9428.
2021-05-08 23:32:52 +09:00
942281d6b0 Merge branch 'master' into fix-editor-slider-input-handling 2021-05-08 14:56:18 +02:00
df630d9428 Trim redundant this qualifier 2021-05-08 14:53:19 +02:00
8c564a69ed Fix InvalidOperationException when exiting a map at the end 2021-05-07 21:11:03 -04:00
495eb04e2f Merge pull request #12488 from Denrage/add-missing-author-links
Add missing author links in Beatmap Details
2021-05-08 05:41:40 +09:00
b475c1a364 Merge pull request #12709 from peppy/update-framework
Update framework
2021-05-07 20:44:59 +09:00
5b2f786f97 Update framework 2021-05-07 19:16:00 +09:00
4ac234bf7f Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy 2021-05-07 17:15:57 +09:00
6dc591fc44 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display 2021-05-07 17:15:37 +09:00
8d04eba960 Merge pull request #12703 from frenzibyte/editor-wrong-track
Fix editor clock not using the beatmap's virtual track when creating one
2021-05-07 17:12:16 +09:00
9d27b11e49 Update skin editor test scene to cache a ScoreProcessor 2021-05-07 17:10:31 +09:00
01eff7f316 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-score-display 2021-05-07 16:30:08 +09:00
93f10330e3 Merge branch 'skin-components-bind-outwards' into skin-components-bind-outwards-accuracy 2021-05-07 16:29:10 +09:00
ad398165a2 Update AccuracyCounter components to use DI to attach data source 2021-05-07 16:27:25 +09:00
17b93361d5 Merge branch 'master' into skin-components-bind-outwards 2021-05-07 16:20:24 +09:00
a2e4fb5b6b Update ScoreCounter components to bind outwards 2021-05-07 16:16:48 +09:00
fc2a527e9d Revert "Guard against potentially null track if ever"
This reverts commit b1134c3857.
2021-05-07 09:57:08 +03:00
7c4e54a1d4 Unrevert null-colaescing/conditionals removal 2021-05-07 09:54:14 +03:00
165f443ab5 Merge branch 'master' into add-missing-author-links 2021-05-07 14:32:44 +09:00
b1134c3857 Guard against potentially null track if ever 2021-05-07 08:30:50 +03:00
37f44d2e37 Revert wrong not-null track changes
This reverts commit f9d99a9882.
This reverts commit 71547bece0.
2021-05-07 08:28:44 +03:00
71547bece0 Remove any null-coalescing/conditionals in WorkingBeatmap.Track usages 2021-05-07 07:46:23 +03:00
f9d99a9882 Mark WorkingBeatmap.Track as not null 2021-05-07 07:25:14 +03:00
539643c72b Set loadable beatmap track to clock immediately in BDL
This reverts commit 84da247002.

Use loadable beatmap track for clock directly in BDL
2021-05-07 07:21:56 +03:00