Commit Graph

2745 Commits

Author SHA1 Message Date
8706b51b77 Merge pull request #10717 from smoogipoo/dho-apply 2020-11-11 10:54:24 +09:00
88112801eb Remove result storage from hitobject 2020-11-10 18:56:16 +09:00
f5076fe3b8 Revert unnecessary change 2020-11-10 18:15:11 +09:00
109abc0e29 Always store standardised score when populating ScoreInfo 2020-11-10 08:41:00 +01:00
d4d3a6621e Disable automatic lifetime management 2020-11-10 01:30:25 +09:00
ac47399e6e Update state after OnApply() 2020-11-10 00:30:23 +09:00
ec8b726ea8 Re-privatise start time bindable 2020-11-09 21:51:58 +09:00
33c3b07101 Fix events not being bound correctly
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-11-09 19:06:48 +09:00
d93cf08570 Merge branch 'master' into dho-apply 2020-11-07 01:18:46 +09:00
91c627c22d Revert HOC changes 2020-11-07 00:57:33 +09:00
b1e039bcec Prevent overrides from messing with application/freeing 2020-11-07 00:40:26 +09:00
3a4bd73823 Fix DHOs being freed when not expected 2020-11-07 00:25:26 +09:00
7eceda242b Change derived class to use property 2020-11-06 23:04:28 +09:00
2d892c7407 Allow Apply() to be called multiple times sequentially 2020-11-06 23:03:29 +09:00
248d342a2f Initial Apply()/FreeAfterUse() DHO implementation 2020-11-06 23:02:37 +09:00
f230250faf Merge branch 'master' into editor-slider-control-point-quick-delete 2020-11-06 21:47:37 +09:00
44c6457c85 Merge branch 'master' into add-spinner-spin 2020-11-06 15:40:40 +09:00
71a1165209 Merge branch 'master' into drawable-hit-object-hit-state-fix 2020-11-06 13:19:25 +09:00
a0b3379909 Fix judgement offsets being zero when windows are empty 2020-11-05 18:58:37 +09:00
2bbdbfda5c Merge pull request #10696 from smoogipoo/visibility-adjustment-mod 2020-11-05 18:18:57 +09:00
2d50a7b616 Fix a few xmldoc typos 2020-11-05 17:38:02 +09:00
0cadb31947 Merge branch 'master' into drawable-hit-object-hit-state-fix 2020-11-05 17:07:52 +09:00
9d5b1ec28c Add removal dates 2020-11-05 17:04:11 +09:00
cc518feca7 Make methods abstract 2020-11-05 16:03:10 +09:00
a219aa7ba2 Add xmldoc 2020-11-05 15:53:35 +09:00
628b8be15d Implement ModWithVisibilityAdjustment 2020-11-05 15:40:25 +09:00
9a7fcadabc Use BDL for top-level osu! DHOs 2020-11-05 13:51:46 +09:00
68b7efe4d5 Change order of execution to be chronological 2020-11-04 17:14:23 +09:00
831325978a Always execute UpdateHitStateTransforms (even for idle) 2020-11-04 17:14:23 +09:00
3b6cf95f49 Remove parameter from StartTime method and add obsoleted previous version 2020-11-04 16:39:52 +09:00
7f30140b7e Add new method handling hit state specifically
Until now UpdateStateTransforms was applying results offsets to
StartTime. This didn't cover the case of a HitObject with duration,
where the call would be made with `StartTime + hitOffset` rather than
`EndTime + hitOffset`.

To resolve this, a new method has been added which should be used to
handle hit-specific state transforms.
2020-11-04 16:13:14 +09:00
9f333ac58a Add the ability to delete slider control points using shift+right click
Closes https://github.com/ppy/osu/issues/10672.

In two minds about how this should be implemented but went in this
direction initially. The other way would be to add local handling of
Shift-Right Click inside PathControlPointPiece (which is already doing
mouse handling itself).
2020-11-03 20:46:33 +09:00
04178e9458 Merge branch 'master' into spectator-replay-watcher 2020-11-02 14:54:51 +09:00
1b53e6c782 Merge branch 'master' into sample-lookup-improvements 2020-11-02 13:04:35 +09:00
2b0bea535e Resolve CA1805 inspections
"Member is explicitly initialized to its default value"
2020-11-01 18:47:40 +01:00
b7696c85ad Add more xmldocs 2020-11-01 15:23:03 +01:00
b4e5311014 Move initial state set inside updateClock 2020-10-30 20:39:25 +09:00
1bd461f229 Move clock logic back to inside updateClock method 2020-10-30 20:21:14 +09:00
32e68a6a3c Fix FramedReplayInputHandler incorrectly blocking in streaming mode when time requested is before the first frame
Most of this is just tidying up the logic to (hopefully) be better to
follow, again (again (again)).

The actual fix is that we now allow interpolation/playback when the
incoming time is less than the first frame's time, regardless of
receiving status.
2020-10-30 16:09:03 +09:00
0f997386ae Fix direction and IsRunning not updating on first frame after becoming valid
The parent clock will not unpause until WaitingForFrames becomes false,
so I've moved the set of that before we start to propagate its values
across. Doesn't fix any visible issue but should make propagation one
game loop faster.
2020-10-30 15:26:23 +09:00
326fd03525 Fix loop not exiting after first valid frame 2020-10-30 15:25:53 +09:00
8e6c803900 Avoid running full updateClock loop when waiting on frames 2020-10-30 12:39:11 +09:00
2ea4aa0a37 Fix incorrect specification on some sample lookups 2020-10-30 11:59:41 +09:00
87be7d162b Merge branch 'master' into spectator-replay-watcher 2020-10-30 00:25:17 +09:00
335d150a13 Fix aim time being mutated inside update loop 2020-10-29 18:11:50 +09:00
2671d371da Move clock retrieval to new correct location 2020-10-29 15:28:39 +09:00
3ea27e23e8 Update namespace references 2020-10-29 15:20:10 +09:00
db2b00068f Avoid sourcing parent clock when in a paused state 2020-10-29 14:48:56 +09:00
d91456dc29 Move initial validity check out of loop for clarity 2020-10-29 14:25:47 +09:00
2e5a8b2287 Fix xmldoc to read better in new context 2020-10-29 13:16:31 +09:00