Commit Graph

2835 Commits

Author SHA1 Message Date
59d0bac728 Hook up update flow to metadata stream 2022-07-05 21:32:00 +09:00
aab4dcefbd Remove unnecessary invalidation handling flow 2022-06-30 17:13:26 +09:00
0698471627 Move BeatmapOnlineLookupQueue to inside BeatmapUpdater 2022-06-30 17:03:19 +09:00
ef42c6ecdf Add missing xmldoc 2022-06-30 16:51:31 +09:00
e34c2f0aca Remove unnecessary nullable-enable 2022-06-30 16:47:26 +09:00
82134ad1a6 Allow null parameter to GetWorkingBeatmap for now 2022-06-30 16:46:28 +09:00
98938821e5 Merge branch 'master' into beatmap-update-flow 2022-06-30 16:44:17 +09:00
18d465eff7 Guard against NaN star difficulty results 2022-06-29 21:02:29 +09:00
396e7fc166 Merge pull request #18862 from peppy/empty-beatmap-file-fix-2
Fix second case of empty beatmaps being reported to sentry as errors
2022-06-27 20:37:57 +09:00
f6a6538e96 Add more properties to IBeatmapOnlineInfo 2022-06-27 16:07:15 +09:00
13c8d33009 Fix second case of empty beatmaps being reported to sentry as errors 2022-06-27 15:29:01 +09:00
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
7692bac35a Simplify refetch (and ensure to invalidate after processing) 2022-06-24 21:02:38 +09:00
0c3d890f76 Fix reprocessing not working on import due to realm threading woes 2022-06-24 21:02:38 +09:00
30b3973c9f Difficulty cache invalidation flow 2022-06-24 21:02:38 +09:00
66a01d1ed2 Allow song select to refresh the global WorkingBeatmap after an external update 2022-06-24 21:02:38 +09:00
6999933d33 Split updater process into realm transaction and non-transaction 2022-06-24 21:02:38 +09:00
021b16f2f3 Ensure WorkingBeatmap is invalidated after update 2022-06-24 21:02:38 +09:00
fe570d8052 Queue beatmaps for update after editing 2022-06-24 21:02:38 +09:00
06d59b717c Move beatmap processing tasks to new BeatmapUpdater class 2022-06-24 21:02:37 +09:00
2ca4184eda Merge pull request #18834 from bdach/ban-implicit-to-lower-upper
Disallow usage of `string.To{Upper,Lower}()` without explicit culture
2022-06-24 20:39:58 +09:00
7eb49dac7a Merge pull request #18832 from peppy/bdc-remove-unused-path
Remove unused bindable retrieval flow in `BeatmapDifficultyCache`
2022-06-24 20:20:23 +09:00
823b3c1c0f Ensure WorkingBeatmap is always using a detached instance 2022-06-24 19:07:54 +09:00
2ae48d5a87 Rename incorrect parameter name in BeatmapManager.GetWorkingBeatmap 2022-06-24 19:07:54 +09:00
26c5b59f6d Replace usages of string.To{Lower,Upper}() 2022-06-24 11:57:45 +02:00
c179127670 Remove unused bindable retrieval flow 2022-06-24 17:09:56 +09:00
0755430006 Use AddOnce for update calls 2022-06-24 17:09:56 +09:00
8912f07745 Merge branch 'master' into difficulty-icon-refactor-pass 2022-06-24 16:34:35 +09:00
28837693e5 Nuke calculating everything
The whole component is pointless so I'm just going to nuke for now I
guess. Kind of makes the whole refactor effort pointless but oh well?

To expand on this, the implementation was actually incorrect as pointed
out at https://github.com/ppy/osu/pull/18819#pullrequestreview-1017886035.
2022-06-24 14:24:06 +09:00
12ea8369ee Update retriever to be relatively sized 2022-06-24 14:06:31 +09:00
d9c1a9d71f Use new property to specify no tooltip, rather than passing only ruleset 2022-06-24 14:06:18 +09:00
129c907092 Remove unused parameters 2022-06-24 13:58:02 +09:00
ef258122d2 Move GetDifficultyRating helper method to StarDifficulty 2022-06-23 19:51:58 +09:00
b068df2149 Enable NRT on BeatmapDiffiultyCache 2022-06-23 19:51:58 +09:00
01da6f20b3 Tidy up all remaining usages 2022-06-23 19:27:35 +09:00
7dec530ca5 Split out simple DifficultyIcon with no calculation overhead and update usages 2022-06-23 19:27:35 +09:00
3a83e5684c Tidy up DifficultyIcon 2022-06-23 19:27:35 +09:00
d6b073ebad Move DifficultyRetrieve to own class and split both pathways into separate constructors 2022-06-23 19:27:35 +09:00
97fcf8cec9 Merge pull request #18668 from smoogipoo/editor-controlpoint-undo-redo 2022-06-23 04:02:24 +09:00
6a26461683 Compare by reference in ControlPoint.Equals() 2022-06-21 12:05:28 +09:00
dbae4c6f5a PostImport -> PresentImport 2022-06-20 18:36:29 +09:00
c402e90598 Merge pull request #18777 from peppy/output-directory-on-import-failure
Silence exception and provide more log output when import fails due to empty `.osu` files
2022-06-20 17:36:21 +09:00
16281f4a48 Properly annotate method to allow null 2022-06-20 16:56:19 +09:00
d38defada4 Silence exception and provide more log output when import fails due to empty .osu files 2022-06-20 16:07:10 +09:00
03ab6fc141 Implement IEquatable on ControlPoint 2022-06-20 15:27:43 +09:00
92f1a2958c Rename Import(TModel) to ImportModel to differentiate from other import methods 2022-06-20 15:18:07 +09:00
a6c8a832aa Remove Import(ArchiveReader) and redirect existing usages to Import(ImportTask) 2022-06-20 15:14:57 +09:00
468e5fcbed Merge branch 'master' into editor-controlpoint-undo-redo 2022-06-20 13:47:01 +09:00
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
d48fbdb439 Merge branch 'bmm-cleanup' into bmm-cleanup-2 2022-06-16 19:48:54 +09:00