99bea6b8e9
Add missing null check (player construction is potentially delayed now)
2020-08-13 12:52:35 +09:00
27cd9e119a
Delay beatmap load until after transition has finished
...
Previously the beatmap would begin loading at the same time the
`PlayerLoader` class was. This can cause a horribly visible series of
stutters, especially when a storyboard is involved.
Obviously we should be aiming to reduce the stutters via changes to the
beatmap load process (such as incremental storyboard loading,
`DrawableHitObject` pooling, etc.) but this improves user experience
tenfold in the mean time.
2020-08-13 12:04:32 +09:00
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
4d4ec3515d
Fix player loading sequence continuing even when a priority overlay is visible
2020-02-14 19:16:08 +09:00
2808f8167d
Use more regions
2020-02-14 18:28:58 +09:00
b69d1ad678
Reorder and clean up PlayerLoader
2020-02-14 18:22:57 +09:00
be30ef3cca
Move BeatmapMetadataDisplay to its own class
2020-02-14 18:13:52 +09:00
f0fe3bc804
Pass bindable to BeatmapMetadataDisplay
...
It was reported that mods selected in song select would show up during
loading of replays which were recorded under a different set of mods.
This was caused by BeatmapMetadataDisplay accepting a plain read-only
value of the Mods bindable in PlayerLoader.load(), therefore making the
mod value assignment in ReplayPlayerLoader.OnEntering() have no effect
on that component.
To resolve this issue, make BeatmapMetadataDisplay accept the
higher-level bindable, bind to it locally and pass it down the hierarchy
to ModDisplay.
2020-01-08 20:10:43 +01:00
a3f7d3c445
Add failing test
...
Add test case demonstrating the lack of update of the metadata display's
mods upon setting the Mods property in PlayerLoader.
2020-01-08 19:55:35 +01:00
ca862124a5
Fix replay import from main menu causing a hard crash
2019-12-27 19:36:48 +09:00
54798b134e
Add accessibility modifiers
2019-12-08 03:16:41 +09:00
de23364608
Add failing test
2019-12-06 13:47:34 +09:00
636913a4a6
Refactor PlayerLoader changes
2019-10-03 19:22:41 +09:00
6929847b08
Remove redundant override
2019-10-02 17:22:34 +02:00
5f399add82
Resolve @iiSaLMaN 's suggested changes
2019-10-01 18:15:40 +02:00
2ac5e0bfa0
Make use of SessionStatics
2019-10-01 17:39:01 +02:00
f4f5a7e9c8
Fix test regressions
2019-09-27 13:20:17 +08:00
b50ef8ffa4
Allow null NotificationManager
2019-09-27 13:15:33 +08:00
f11156c2dc
Fix tests not working correctly
2019-09-25 19:30:25 +09:00
c3221e1a36
Prepare classes for player loader test scene
2019-09-18 23:27:26 +02:00
220fdd0a04
Make muteWarningShownOnce static
...
... so it will actually get an instance per osu session.
2019-09-16 06:56:52 +02:00
ecce12981e
Use block body for constructor to fix remaining code inspection issue
2019-09-15 17:47:44 +02:00
e3884658af
Resolve code inspection errors
2019-09-15 17:36:53 +02:00
ec788ac09d
Make notification only show up once per session
2019-09-15 17:20:07 +02:00
811a08d18f
Use Bindable instead of bool
2019-09-15 16:50:01 +02:00
00e46fdefe
Add check if game is muted by MuteButton
2019-09-15 16:32:23 +02:00
4a10e6c44e
Use ResolvedAttribute for NotificationOverlay
2019-09-15 16:11:45 +02:00
78931c8e23
Implement notification when user has track or master volume muted
...
This took around under a hour to implement, it has the same behavior and content from osu!stable.
A notification will show up when the user has either its master or track volume set to the minimum, clicking it will set it to the default values.
2019-09-15 15:59:46 +02:00
b902457f8d
Allow PlayerLoader to proceed even if the mouse is hovering an overlay panel
2019-07-05 15:32:07 +09:00
7bc7df2249
Reduce background brightness at PlayerLoader
2019-06-25 17:22:10 +09:00
20b43c20c8
Rename variables to remove redundant "screen" terminology
2019-06-12 16:33:15 +09:00
a5f758b977
Merge remote-tracking branch 'upstream/master' into user-status-wiring
2019-05-07 18:27:14 +02:00
d5d31282e5
Rename InitialScreenStatus to InitialScreenActivity in Editor / Player classes
2019-05-05 20:55:42 +02:00
5d4aa5a12e
Add ScreenStatus property to change the OsuScreen's status + Renamed old ScreenStatus property to InitialScreenStatus
2019-05-02 20:51:19 +02:00
7e42068a14
Merge remote-tracking branch 'upstream/master' into user-status-wiring
2019-04-28 19:48:35 +02:00
5a9277ec0e
Merge branch 'master' into fix-retry-sound
2019-04-28 23:38:14 +09:00
a680a38e81
Merge pull request #4675 from nyquillerium/playerloader-tracking
...
Prevent PlayerLoader from tracking the logo after it has been exited.
2019-04-26 13:21:13 +09:00
0bd35ab7bb
Turn on warnings, resolve issues
2019-04-25 17:36:17 +09:00
6fdcd98caa
Don't play screen "back" sample when retrying
2019-04-25 14:15:07 +09:00
8222923ab8
Only track logo if we're still the current screen
2019-04-24 16:20:51 +09:00
fe8c705f1b
Merge remote-tracking branch 'upstream/master' into user-status-wiring
2019-04-20 09:42:32 +02:00
12b6bc48bd
Use .With() wherever possible
2019-04-17 17:24:09 +09:00
09568be270
Merge remote-tracking branch 'origin/master' into facade-container
...
# Conflicts:
# osu.Game/Screens/Play/PlayerLoader.cs
2019-04-17 17:17:33 +09:00
5887008fb3
Merge branch 'master' into user-status-wiring
2019-04-15 11:43:53 +02:00
361c0ec9f2
Allow UserStatusSoloGame to provide metadata such as the ruleset the current beatmap is played in
2019-04-13 13:18:44 +02:00
0222424aef
Make mods IReadOnlyList<Mod> gamewide
...
Prevents potential multiple evaluations of enumerable.
2019-04-10 17:20:36 +09:00
4310f07a5c
Rename SelectedMods -> Mods
2019-04-10 12:03:57 +09:00
c584967eb1
Remove mods from workingbeatmap
2019-04-09 12:59:32 +09:00
a690302d00
Apply reviews
2019-04-08 15:24:09 +09:00
7047f305a1
Apply reviews, add safety for multiple facades
2019-04-05 12:02:47 +09:00
