Commit Graph

36143 Commits

Author SHA1 Message Date
b00c6a1d60 Make first non-default skin index a property
The previous code was very brittle - it was not always updating
properly, and seems to have worked either by a carefully crafted set of
circumstances, or just plain coincidence.

Having this be a get-only property avoids potential error in the future
caused by not updating the index properly, at the expense of an added
linear lookup.
2021-01-19 18:31:37 +01:00
206a0b8bac Fix firstNonDefault staying as -1 2021-01-19 16:55:50 +00:00
741d51893d Merge branch 'sort-skins-alphabetically' of https://github.com/rednir/osu into sort-skins-alphabetically 2021-01-19 16:17:06 +00:00
a880b8d21d Satisfy AppVeyor 2021-01-19 16:11:16 +00:00
14ff2af00e Satisfy AppVeyor 2021-01-19 15:37:59 +00:00
102d106ae7 Merge branch 'master' into sort-skins-alphabetically 2021-01-19 14:41:58 +00:00
7a47641c80 Merge branch 'sort-skins-alphabetically' of https://github.com/rednir/osu into sort-skins-alphabetically 2021-01-19 14:16:38 +00:00
b265d2dab4 Remove another whitespace 2021-01-19 14:16:22 +00:00
c5c5fdca45 Remove another whitespace 2021-01-19 14:10:08 +00:00
1d4c813ff6 Merge branch 'sort-skins-alphabetically' of https://github.com/rednir/osu into sort-skins-alphabetically 2021-01-19 14:03:31 +00:00
31e61326e1 Only user skins are sorted 2021-01-19 14:00:17 +00:00
f1894a8bac fixed itemUpdated() 2021-01-19 12:17:56 +00:00
bf7ce18fc0 Merge pull request #11539 from peppy/update-build-configs
Update various references to previous .NET version
2021-01-19 12:49:21 +09:00
35be91fc51 Update readme 2021-01-19 12:15:18 +09:00
1e99357a97 Update build configurations to net5.0 paths 2021-01-19 12:13:27 +09:00
0b65c0cd25 Remove whitespace 2021-01-18 20:17:42 +00:00
233e50ba1a Merge branch 'sort-skins-alphabetically' of https://github.com/rednir/osu into sort-skins-alphabetically 2021-01-18 20:09:56 +00:00
da89426a3b Merge branch 'master' of https://github.com/ppy/osu into sort-skins-alphabetically 2021-01-18 20:09:15 +00:00
6a991fbc84 Merge branch 'master' into sort-skins-alphabetically 2021-01-18 20:08:53 +00:00
7476cb3047 Sort SkinSection in alphabetical order 2021-01-18 19:51:42 +00:00
e74ecebfd6 nuget restore other rulesets 2021-01-18 23:45:57 +09:00
fda271d9d9 Merge pull request #11520 from frenzibyte/fix-item-download-button
Fix playlist item download button never shown back after hiding
2021-01-18 23:37:33 +09:00
000c7dd07b Merge pull request #11502 from peppy/fix-spinner-spinning-weirdness
Fix some issues with spinner spin sound
2021-01-18 22:50:32 +09:00
dcb92e5b38 Merge pull request #11529 from peppy/fix-android-release
Restore nuget packages per project to avoid toolchain incompatibilities
2021-01-18 22:04:19 +09:00
ced7a36788 Update namespaces 2021-01-18 21:24:10 +09:00
12443e39ae Update framework 2021-01-18 19:16:32 +09:00
95963f2fa2 Merge pull request #11526 from peppy/fix-editor-repeat-slider-adjustment
Fix sliders with an even number of repeats not allowing rotation/scale transforms
2021-01-18 18:56:25 +09:00
707d5346c9 Merge branch 'master' into fix-spinner-spinning-weirdness 2021-01-18 18:26:44 +09:00
46681322d0 Restore nuget packages per project to avoid toolchain incompatibilities with net50 2021-01-18 17:56:00 +09:00
1359153382 Revert "Test removing nuget restore from iOS/Android build scripts"
This reverts commit 39746cb3de.
2021-01-18 17:54:22 +09:00
7e30489167 Merge pull request #11525 from peppy/fix-editor-selection-box-non-visible-hitobjects
Fix selection box not updating with hitcircles/sliders far in the future or past
2021-01-18 17:34:25 +09:00
2f1d4bf51b Add missing braces 2021-01-18 17:13:47 +09:00
c79ab63743 Fix sliders with an even number of repeats not allowing rotation/scale transforms 2021-01-18 16:59:16 +09:00
02d2b2742b Fix selection box not updating with hitcircles/sliders far in the future or past 2021-01-18 16:57:36 +09:00
30f3e72c42 Merge pull request #11469 from Mysfit/beatmap-colour-setting
Add ability to toggle beatmap colours separate from skins
2021-01-18 16:46:53 +09:00
94fee8c31d Avoid doing a config lookup if initial conditional fails 2021-01-18 16:13:58 +09:00
1364de1166 Merge branch 'master' into beatmap-colour-setting 2021-01-18 16:07:46 +09:00
7b4f73eb8c Merge pull request #11523 from smoogipoo/nupkg-rulesets
Add nuget deploys for all rulesets
2021-01-18 11:47:30 +09:00
1b166d809e Adjust package titles 2021-01-18 11:08:03 +09:00
ec00aaef90 Add nuget deploys for all rulesets 2021-01-18 10:53:31 +09:00
2b23c8eabd Use alpha directly for checking visibility in test
`IsPresent` is no longer synonymous with being visible, after applying
the fix to the issue in question.
2021-01-17 18:08:58 +01:00
585aa87c53 Fix playlist item download button never shown back after hiding 2021-01-17 19:17:14 +03:00
39746cb3de Test removing nuget restore from iOS/Android build scripts 2021-01-18 00:11:35 +09:00
5e0fcc4a6c Merge pull request #11473 from frenzibyte/explicit-search-control
Add "explicit maps" search filter control to beatmap listing
2021-01-17 23:27:15 +09:00
a9568e713a Merge pull request #11519 from bdach/fix-android-multi-broken
Fix android users not being able to join multiplayer rooms
2021-01-17 23:24:05 +09:00
5278cad393 Reword setting to make more sense 2021-01-17 22:42:48 +09:00
5fd644fc57 Unify variable names 2021-01-17 22:42:48 +09:00
eb53e32792 Use task completion source for room join flow
On Android, users were unable to join or create multiplayer rooms. The
root cause of that was that the both the wait and set of the
`ManualResetEvent` in `getRoomUsers` occurred on the same thread, which
created a chicken-and-egg situation - the set could not proceed until
the wait had actually completed.

Resolve by substituting the `ManualResetEvent` for a
`TaskCompletionSource` to achieve a promise-style task, which the
previous code was a crude approximation of anyway.

Closes #11385.
2021-01-17 14:40:22 +01:00
addd463d26 Merge branch 'master' into explicit-search-control 2021-01-17 21:44:25 +09:00
edb6d3907b Merge pull request #11472 from frenzibyte/explicit-beatmap-markers
Add explicit content markers to beatmap panels and overlay
2021-01-17 21:44:10 +09:00