b02b8ae2bc
Merge pull request #13381 from smoogipoo/improve-hit-error-judgements
...
Improve hit error judgement displays
2021-06-09 19:40:17 +09:00
50eb58ecd3
Merge pull request #13402 from peppy/mania-key-lookup-fix
...
Use candidate skin for mania skin key lookup rather than `this`
2021-06-09 16:35:55 +09:00
17ad214e0e
Merge pull request #13393 from bdach/fix-skin-background-regression
...
Bring back skin background source
2021-06-09 16:34:57 +09:00
023015f9a6
Merge branch 'master' into fix-skin-background-regression
2021-06-09 08:09:21 +02:00
8a221f501d
Merge pull request #13400 from peppy/remove-obsoleted-drawable-judgement-methods
...
Remove some obsoleted members
2021-06-09 15:01:25 +09:00
d248bbd4c8
Use candidate skin for mania skin key lookup rather than this
2021-06-09 15:00:55 +09:00
a801a9a14d
Ensure background rotation on default skins
2021-06-09 07:59:47 +02:00
5487012060
Add test coverage for default skin background cycling
2021-06-09 07:48:16 +02:00
b8df3fff9e
Fix incorrect method referenced in xmldco
...
Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com >
2021-06-09 14:20:01 +09:00
62199a38a8
Add one missing obsoletion removal date
2021-06-09 14:11:50 +09:00
f41e34ae2c
Remove more obsoleted members
2021-06-09 14:10:48 +09:00
a87226ab10
Remove obsoleted DrawableJudgement methods
...
Undated, but change was made on 2020-11-18.
2021-06-09 14:09:23 +09:00
2f6227e0f2
Merge pull request #13397 from ekrctb/fix-event-not-unregistered
...
Fix registered event not unregistered on dispose
2021-06-09 13:12:06 +09:00
555ab8fccd
Fix event not unregistered on dispose
2021-06-09 12:35:14 +09:00
e914fbf449
Merge pull request #13396 from ekrctb/fix-circle-piece
...
Fix hit circle animation is removed when a replay is rewound
2021-06-09 11:39:38 +09:00
4707918c6a
Fix hit circle animation when a replay is rewound
2021-06-09 10:53:52 +09:00
97204b6f27
Reduce unnecessary background changes via IEquatable implementation
2021-06-08 22:37:18 +02:00
f628ec25ef
Add test coverage for keeping same background instance
2021-06-08 22:31:09 +02:00
a98c302211
Bring back skin background source
2021-06-08 22:04:59 +02:00
d86ace4d11
Add test coverage for skin background source
2021-06-08 22:03:59 +02:00
5bf4dd6358
Move skin background to separate file
2021-06-08 21:57:08 +02:00
04cc788627
Merge pull request #13380 from smoogipoo/fix-multi-spec-dt-doubling-2
...
Fix DT being doubled in multiplayer spectator
2021-06-08 23:31:56 +09:00
00efed2c39
Add colours for tick judgements
2021-06-08 23:10:21 +09:00
c8e14d7710
Ignore non-scorable and bonus judgements
2021-06-08 23:09:23 +09:00
c3ea1b26e1
Fix DT being doubled in multiplayer spectator
2021-06-08 22:51:42 +09:00
475788041a
Merge pull request #13337 from Pasi4K5/fix-sliders-out-of-screen
...
Fix sliders sometimes being outside of the playfield with osu! random mod enabled
2021-06-08 21:18:21 +09:00
25af4dfa8a
Merge pull request #13375 from smoogipoo/fix-multi-nullref
...
Fix possible nullref when exiting song select too fast
2021-06-08 20:47:40 +09:00
5a8cde7e6f
Merge pull request #13377 from peppy/fix-lazer-replays-getting-classic
...
Move legacy `ScoreInfo` to be completely based on presence of classic mod
2021-06-08 19:15:13 +09:00
d9ac9f641a
Merge pull request #12970 from peppy/fix-skin-sample-lookup
...
Fix default skin sample fallback logic existing within `PoolableSkinnableSample`
2021-06-08 19:10:04 +09:00
0b9916b266
Add parens to declare operator precedence
2021-06-08 18:39:52 +09:00
4ee7721c51
Extract first version out to constant
2021-06-08 18:38:47 +09:00
d31e3e8f1c
Fix nullref
2021-06-08 18:23:03 +09:00
b287366c8b
Remove forgotten classic mod addition
2021-06-08 18:09:57 +09:00
061e3d7f26
Move legacy ScoreInfo to be completely based on presence of classic mod
2021-06-08 18:00:09 +09:00
4d9fffc01b
Update score encoder version to be higher than any existing stable version
2021-06-08 17:59:43 +09:00
ab9290772b
Fix a similar case with online play sub-screens
2021-06-08 17:54:54 +09:00
860f1aebb3
Only call OnBackButton() if the screen has finished loading
2021-06-08 17:38:12 +09:00
6017ef3825
Merge branch 'master' into fix-skin-sample-lookup
2021-06-08 17:37:36 +09:00
e5e3509c87
Merge pull request #13264 from peppy/legacy-skin-default-fallback
...
Allow fallback to legacy defaults from legacy skins
2021-06-08 17:30:27 +09:00
c0fdbfba04
Merge pull request #13374 from peppy/update-framework
...
Update framework
2021-06-08 17:09:20 +09:00
490ab9e96a
Fix typo
2021-06-08 17:09:03 +09:00
7fa0ac6ed7
Fix possible nullref when exiting song select too fast
2021-06-08 17:03:50 +09:00
791855dfa0
Merge branch 'master' into legacy-skin-default-fallback
2021-06-08 16:54:26 +09:00
e3cb6f45f5
Merge pull request #13371 from peppy/fix-poolable-sample-disposal-skin-change
...
Clean up previous sample immediately on skin source change to avoid `Play` after disposal
2021-06-08 16:52:59 +09:00
751a5e7cf3
Merge pull request #13373 from peppy/catch-no-visibility-increase
...
Don't apply visibility increase to first object in osu!catch
2021-06-08 16:39:21 +09:00
89895f6ce4
Update framework
2021-06-08 16:24:00 +09:00
67135ce3db
Add null check
2021-06-08 16:15:17 +09:00
e388a896e8
Don't apply visibility increase to first object in osu!catch
...
The goal of the visibility increase is to help in cases where timing is
an issue (by showing the approach circle etc.). This doesn't need to
apply to catch.
@smoogipoo interested as to whether you agree with this one. Visually it
looks better to me but it does change the behaviour for only osu!catch,
so I'm not 100% confident on it.
Closes #13367 .
2021-06-08 16:02:26 +09:00
e0f568aa8f
Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
2021-06-08 15:19:52 +09:00
f3f634e969
Clean up previous sample immediately on skin source change to avoid Play after disposal
...
This seems to be the simplest way to avoid calls to `Play` after the
underlying sample may have been disposed. As per the issue thread, a
local workaround is acceptable here.
Closes #13223 .
2021-06-08 15:05:18 +09:00
