Commit Graph

37438 Commits

Author SHA1 Message Date
b2d8db3a92 Rename incorrect variable 2021-03-19 20:25:21 +09:00
c0c8b3e46c Fix regression meaning SkinnableSound initialisation may never happen 2021-03-19 19:22:50 +09:00
bf4317d3f0 Ensure looping is disabled on old samples when switching skins 2021-03-19 15:34:21 +09:00
0e821e857e Remove unnecessary duplicated skin changed handling
For some reason we were handling this both in `DrawableSkinnableSound`
and `PoolableSkinnableSample` in very similar ways. Only one seems
required.
2021-03-19 15:23:32 +09:00
b419d2c2e2 Fix invalid xmldoc indent 2021-03-18 19:52:38 +01:00
aec859b4d1 Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-18 19:51:46 +01:00
68b67e6e98 Merge pull request #12006 from peppy/input-handler-configuration
Consume framework updates to input handling
2021-03-18 22:58:51 +09:00
d9ec3c327e Merge branch 'master' into input-handler-configuration 2021-03-18 22:17:48 +09:00
a8cc3a3b44 Implement enable state changes locally for InputHandlers which should be toggleable 2021-03-18 21:17:04 +09:00
c694deb7d6 Revert changes to SettingsSourceAttribute class 2021-03-18 21:16:50 +09:00
d09ad85c71 Merge pull request #12060 from smoogipoo/fix-converted-mania-score-accuracy 2021-03-18 21:09:29 +09:00
e94644d7ee Merge pull request #12012 from bdach/taiko-explosion-pooling 2021-03-18 21:09:09 +09:00
f01ece8c8d Merge branch 'master' into taiko-explosion-pooling 2021-03-18 19:43:42 +09:00
0c3c8141da Remove Expires and RemoveWhenNotAlive override 2021-03-18 19:39:42 +09:00
917717686a Expand explanatory comment 2021-03-18 19:26:29 +09:00
b68dc686ee Fix converted mania scores not accounting for GREATs 2021-03-18 19:19:53 +09:00
53ae24db9b Merge pull request #12058 from peppy/fix-whitespace-in-ini
Fix skin parser not stripping whitespace before parsing
2021-03-18 18:46:28 +09:00
5b0d75ee56 Only trim trailing spaces to avoid breakage in storyboard parsing 2021-03-18 16:30:30 +09:00
bb3c3f302a Fix skin parser not stripping whitespace before parsing 2021-03-18 15:36:11 +09:00
b3e96c8385 Merge pull request #12043 from bdach/fix-reverse-crash
Fix selection box operation hotkeys not registering in change handler
2021-03-18 13:30:33 +09:00
0c272ce432 Merge pull request #12044 from Joehuu/update-profile-kudosu-section
Update kudosu section on user profile overlay in line with web
2021-03-18 13:28:45 +09:00
f95ce90c95 Adjust kudosu count formatting 2021-03-17 23:32:08 +01:00
08ffe425f9 Update kudosu description color in line with web 2021-03-17 14:46:23 -07:00
2e63c2ce20 Fix selection box operation hotkeys not registering in change handler
Could lead to crashes after reversing a note cluster and playing it
back.

The root cause of the crash was that the hotkey operations were not ran
inside of an editor change handler operation. This, in turn, caused the
autoplay replay to not be regenerated after flipping an object cluster,
therefore finally manifesting as a hard crash due to negative time
offsets appearing in judgement results, which interfered with the
default implementation of note lock.

Note that this incidentally also fixes the fact that selection box
hotkey operations (reverse and flip) did not handle undo/redo.
2021-03-17 22:17:42 +01:00
599c55fca5 Update total kudosu earned description text in line with web 2021-03-17 13:22:00 -07:00
6cea74f0fa Remove available kudosu section from user profile overlay in line with web 2021-03-17 13:21:41 -07:00
3bfde7341f Revert "Remove unnecessary overrides"
This reverts commit f4e508b570.
2021-03-17 17:14:53 +01:00
5a7e416495 Merge pull request #12027 from peppy/new-beatmap-empty-fields
Don't fill beatmap metadata with template values on creating a new beatmap
2021-03-17 19:36:21 +09:00
e59b8b4ce6 Fix test checking nullable string 2021-03-17 19:07:29 +09:00
f7ec79c5f4 Fix incorrect generic type 2021-03-17 19:02:25 +09:00
4bf57ad860 Remove remaining reference to obsolete value 2021-03-17 18:24:24 +09:00
e0c0107461 Merge branch 'update-config-usages' into input-handler-configuration 2021-03-17 18:08:13 +09:00
fccd495f27 Remove obsoleted setting for now 2021-03-17 18:07:51 +09:00
79041c1c4b Remove osuTK reference 2021-03-17 18:07:42 +09:00
577d40d8d1 Update framework 2021-03-17 18:05:18 +09:00
249ab8ab3d Merge branch 'master' into input-handler-configuration 2021-03-17 18:05:14 +09:00
a1a0074c32 Revert "Local framework"
This reverts commit b9b095ee75.
2021-03-17 18:05:11 +09:00
822d469b2c Merge pull request #12024 from peppy/fix-editor-startup-threading-crash 2021-03-17 18:02:48 +09:00
d0e61e5b4d Put back the label 2021-03-17 17:14:04 +09:00
3b6a1180b6 Remove non-accessed field 2021-03-17 17:02:11 +09:00
5adc675862 Focus artist textbox on entering song setup if fields are empty 2021-03-17 16:57:14 +09:00
26d6f96c4e Fix LabelledTextBox not correctly forwarding focus to its underlying TextBox component 2021-03-17 16:56:58 +09:00
eda891223c Start the editor with empty artist/creator/difficulty name fields 2021-03-17 16:47:12 +09:00
7fa5fd5647 Update usages of config with framework changes 2021-03-17 16:10:16 +09:00
c7740d1181 Fix opening the editor occasionally causing a hard crash due to incorrect threading logic
Setting one of the global screen `Bindable`s (in this case, `Beatmap`)
is not valid from anywhere but the update thread. This changes the order
in which things happen during the editor startup process to ensure
correctness.

Closes #11968.
2021-03-17 15:52:25 +09:00
891e7aadb6 Merge pull request #12015 from Joehuu/fix-mouse-disable-default-indicator
Fix disable mouse buttons setting not showing default indicator when using keybind
2021-03-16 11:51:53 +09:00
b495504cae Merge branch 'master' into fix-mouse-disable-default-indicator 2021-03-16 10:58:56 +09:00
da3dc61aae Remove newline 2021-03-16 10:58:42 +09:00
72c18fbdfe Restructure explosion animation to avoid resetting transforms on free 2021-03-15 21:21:52 +01:00
f4e508b570 Remove unnecessary overrides 2021-03-15 20:43:30 +01:00