b38de6e580
Add skinning support for welcome sprite text
2022-03-10 05:52:43 +03:00
df500dec04
Merge pull request #17187 from smoogipoo/fix-playlist-copy
...
Fix unable to copy playlist rooms without first opening
2022-03-09 23:03:43 +09:00
1646e9d64c
Merge pull request #17153 from hlysine/osu-random-mod-logic-changes
...
Separate randomization and object positioning logic in osu random mod
2022-03-09 20:52:33 +09:00
8bb07f83cd
Merge pull request #17054 from hlysine/mod-adaptive-speed
...
Implement Adaptive Speed mod
2022-03-09 17:56:34 +09:00
353b251d38
Attempt to merge conditional expression
...
Hoping to fix CI error, caused by older R# version.
2022-03-09 17:46:42 +09:00
d847f5874c
Merge pull request #17188 from peppy/fix-carousel-item-interaction-when-not-visible
...
Fix beatmap carousel panels accepting input while marked as not-visible
2022-03-09 17:43:30 +09:00
e689973de5
Merge branch 'master' into osu-random-mod-logic-changes
2022-03-09 16:58:59 +09:00
75c6a676b4
Apply nullable to OsuModRandom rather than using jetbrains annotations
2022-03-09 16:58:36 +09:00
4839bd8044
Notify if copying room fails
...
Co-authored-by: Dean Herbert <pe@ppy.sh >
2022-03-09 16:47:47 +09:00
520d2d6cfa
Fix beatmap carousel panels accepting input while marked as not-visible
...
This is an issue as carousel panels manage their own animated state. If
they are marked as not-visible (done at a higher level, from filtering
or update pathways) but clicked while fading out, they will animate back
to a visible state but not be marked as visible.
No tests for this one as it's probably not worthwhile to test (and hard
to do so). Manual testing can be done with the following patch:
```diff
diff --git a/osu.Game/Screens/Select/BeatmapCarousel.cs
b/osu.Game/Screens/Select/BeatmapCarousel.cs
index c3d340ac61..3372242acc 100644
--- a/osu.Game/Screens/Select/BeatmapCarousel.cs
+++ b/osu.Game/Screens/Select/BeatmapCarousel.cs
@@ -255,7 +255,7 @@ private void
beatmapSetsChanged(IRealmCollection<BeatmapSetInfo> sender, ChangeS
}
foreach (int i in changes.NewModifiedIndices)
- UpdateBeatmapSet(sender[i].Detach());
+ Scheduler.AddDelayed(() =>
UpdateBeatmapSet(sender[i].Detach()), 100, true);
foreach (int i in changes.InsertedIndices)
UpdateBeatmapSet(sender[i].Detach());
```
- Enter gameplay and adjust beatmap offset then return to song select
and click the flashing panel.
OR
- Enter editor and save then return to song select and click the
flashing panel.
Closes https://github.com/ppy/osu/discussions/17171 .
2022-03-09 16:08:52 +09:00
aad9e856b1
Merge pull request #17185 from smoogipoo/fix-local-score-linking
...
Fix avatar not clickable after watching replay
2022-03-09 15:39:54 +09:00
b07a1e8d09
Fix unable to copy playlist rooms without first opening
2022-03-09 15:38:00 +09:00
ad0ca5673a
Fix avatar not clickable after watching replay
2022-03-09 14:39:02 +09:00
e3cf2c6acd
Merge getAbsoluteAngle into computeRandomisedPosition
2022-03-09 13:27:33 +08:00
3ced5e7904
Rename Distance to DistanceFromPrevious
2022-03-09 13:09:33 +08:00
affcf5180b
Merge pull request #17161 from smoogipoo/fix-listing-score-conversion
...
Fix scores not being recalculated in beatmap overlay
2022-03-09 13:32:45 +09:00
58aef25ad5
Merge pull request #17152 from bdach/mod-overlay/difficulty-multiplier
...
Implement difficulty multiplier display for new mod select design
2022-03-09 12:11:16 +09:00
b3fd156f10
Merge pull request #17158 from peppy/realm-recover-from-newer-database-version
...
Add flow to allow recovery after running an older release (with a different realm database version)
2022-03-09 11:30:58 +09:00
810cbd745d
Merge pull request #17170 from peppy/fix-top-local-rank-test-failures-realm-callback
...
Refactor top local rank test method to be more resilient to slow realm callbacks
2022-03-09 11:14:37 +09:00
af4423959c
Merge pull request #17169 from peppy/fix-song-select-test-failures-realm-callback
...
Refactor song select test methods to be resilient to slow realm callbacks
2022-03-09 11:14:26 +09:00
714789f726
Merge pull request #17167 from peppy/fix-download-button-test-failure
...
Fix potential test failure on slow realm callback in `TestSceneBeatmapDownloadButton`
2022-03-09 01:49:23 +09:00
74fe1e8e47
Merge pull request #17166 from peppy/fix-realm-skin-dropdown-failure
...
Fix potential crash on rare incorrect firing of skin dropdown update methods
2022-03-09 01:46:31 +09:00
233c8232d3
Fix TestSceneTopLocalRank.TestHighScoreSet not waiting for potentially slow realm callback
...
As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847 .
2022-03-09 01:22:01 +09:00
286bafe326
Refactor multiple TestScenePlaySongSelect test methods to be resilient to slow realm callbacks
2022-03-09 01:18:53 +09:00
821de83e54
Merge pull request #17165 from smoogipoo/fix-intermittent-test
...
Fix intermittent multiplayer ready button test failures
2022-03-09 01:16:38 +09:00
56ad684f5b
Fix potential test failure on slow realm callback in TestSceneBeatmapDownloadButton
...
As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847 .
2022-03-09 01:11:46 +09:00
a2ef086c1f
Fix potential crash on rare incorrect firing of skin dropdown update methods
...
As brought to light by https://gist.github.com/smoogipoo/56eda7ab56b9d1966556f2ca7a80a847 .
There's a chance that the dropdown is not populated by the time
`updateSelectedSkinFromConfig` is fired via an external means (config
changes).
2022-03-09 01:08:13 +09:00
729af28a64
Fix intermittent test failure
2022-03-09 00:48:12 +09:00
94d5e2f264
Fix test failure ripple through entire TestScene
2022-03-09 00:48:03 +09:00
e9a2d23542
Fix score order related test failure
2022-03-08 23:35:35 +09:00
a352a140bc
Merge pull request #17157 from peppy/fix-statistics-json-serialisation
...
Fix incorrect serialisation of submitted scores
2022-03-08 20:20:31 +09:00
d13a66a96c
Rework test scene by only relying on OnlineID
2022-03-08 20:11:56 +09:00
4603e082f5
Merge pull request #17160 from peppy/remove-unnecessary-user-submittable-score
...
Remove `user` from `SubmittableScore`
2022-03-08 19:34:47 +09:00
f5cd967635
Fix scores not being recalculated in beatmap listing
2022-03-08 19:07:39 +09:00
e0dc3a04f3
Merge pull request #17159 from smoogipoo/add-hitresult-helper
...
Add IsBasic() and IsTick() extensions on HitResult
2022-03-08 18:46:39 +09:00
b0f40d9e45
Remove user from SubmittableScore
...
This wasn't being used by osu-web, and included far too much unnecessary
data. Of note, `pp` and `ruleset_id` are also not strictly required, but
there's no harm in sending them so I've left them be for now.
2022-03-08 18:38:24 +09:00
6565c95b17
Remove unused variable
2022-03-08 18:19:54 +09:00
a172fc6cb8
Add IsBasic() and IsTick() extensions on HitResult
2022-03-08 18:19:12 +09:00
0718a55ad0
Add flow to allow recovery after running an older release (with a different realm database version)
...
As brought up in https://github.com/ppy/osu/discussions/17148
2022-03-08 18:15:28 +09:00
9a347af5c7
Add test coverage of SubmittableScore serialisation to (roughly) match spec
2022-03-08 17:58:52 +09:00
589a40ca2d
Add EnumMember naming to HitResult to allow for correct json serialisation
2022-03-08 17:58:37 +09:00
719331420c
Merge pull request #17155 from peppy/beatmap-leaderboard-dont-handle-offset-changes
...
Fix `BeatmapLeaderboard` refreshing on changes in local offset setting
2022-03-08 15:38:05 +09:00
622ec53130
Fix BeatmapLeaderboard refreshing on unrelated changes to a beatmap
2022-03-08 14:50:47 +09:00
2a55c5e02e
Add extension method to detect and isolate realm collection-level changes
2022-03-08 14:50:47 +09:00
ae1c65c38d
Add xmldoc
2022-03-08 12:07:10 +08:00
8cfeffc085
Extract a major part of ApplyToBeatmap to a new method
2022-03-08 11:50:30 +08:00
ded84cab3f
Separate randomisation and object positioning logic
2022-03-08 11:45:16 +08:00
643f68e844
Better annotate initial rolling counter value set
2022-03-07 23:11:20 +01:00
019f4d965d
Show two decimal digits on mod multiplier rather than one
2022-03-07 22:55:55 +01:00
c25d7a1c75
Use rolling counter for multiplier display
2022-03-07 22:50:51 +01:00
