3902dc64f0
Fix adjusting offset via button seeking to timing point's offset unexpectedly
...
This was added with the intention of tracking the offset when already at
the start (the most common case when you're using the tap timing
wizard), but was also seeking when the user may be much further beyond
or before it.
Addresses https://github.com/ppy/osu/discussions/18741#discussioncomment-2975051 .
2022-06-19 01:35:45 +09:00
8a1d11fefb
Cancel previous metronome sound playback on pause
2022-06-18 04:07:21 +03:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
c30644328c
Fix timing adjustment repeat buttons firing one change per repeat invocation
2022-06-14 19:21:02 +09:00
fcf51a6f51
Merge pull request #18530 from peppy/add-cloen-button
...
Change text on timing group add button when it is going to clone instead
2022-06-03 22:23:04 +09:00
debd1a59b0
Merge pull request #18539 from frenzibyte/repeating-button-behaviour
...
Share repeat implementation in `TimingAdjustButton` for timeline zoom buttons
2022-06-03 18:18:23 +09:00
1c738e22ae
Merge pull request #18523 from peppy/tap-button
...
Add tap for BPM button
2022-06-03 18:11:10 +09:00
e779b460e4
Use Component instead of CompositeDrawable
2022-06-03 16:49:08 +09:00
dd93fc283b
Merge pull request #18531 from peppy/track-groups-better
...
Improve group tracking logic to avoid switching which point type unnecessarily
2022-06-03 13:04:54 +09:00
efbde06c11
Split button repeating logic from TimingAdjustButton to own component
2022-06-03 05:23:49 +03:00
87ec2e490d
Merge branch 'master' into deselect-control-group
2022-06-03 00:47:06 +02:00
ad3c093a08
Improve group tracking logic to avoid switching which point type unnecessarily
2022-06-02 18:33:09 +09:00
2fa4d46f73
Change text on timing group add button when it is going to clone instead
...
Also disables the button when it would otherwise have no effect.
2022-06-02 18:28:16 +09:00
0b125ade4c
Allow clicking away to deselect the current control point group
2022-06-02 18:18:18 +09:00
5a0f716bf2
Fix timing screen crash when attempting to add group to self
...
Closes #18527 .
2022-06-02 18:14:28 +09:00
ee4beefd95
Increase max taps to 128 for now
...
Will revisit this in the future with a more sound algorithm.
2022-06-02 17:27:52 +09:00
e75609dfb9
Increase taps to consider for better results for longer tap periods
2022-06-02 17:03:48 +09:00
4abfb35611
Improve light rotational alignment and increase light count to 8
2022-06-02 16:58:14 +09:00
060372a129
Split out transition length constants
2022-06-02 13:16:31 +09:00
15f8d318eb
Add note about glow code (please look away)
2022-06-02 13:13:00 +09:00
ac3793f340
Move inline class to end and apply NRT
2022-06-02 13:10:50 +09:00
d99d37c0a6
Apply current track rate to calculated BPM
2022-06-02 13:06:18 +09:00
943e904c71
Fix reset happening on mouse down instead of mouse up
...
Also some reorganisation of file content for legibility
2022-06-02 12:58:44 +09:00
0c493dd359
Add key binding for tap button
2022-06-02 12:58:44 +09:00
781a1527b1
Adjust button metrics and move surrounding buttons to be more integrated
2022-06-02 12:58:43 +09:00
d4e88441ec
Adjust metrics to make timing section fit better in editor
2022-06-02 11:57:06 +09:00
f3f7e28353
Ignore initial taps as they are generally inaccurate
2022-06-02 11:57:06 +09:00
b88bce9b8b
Restart track playback when tapping to time
2022-06-02 11:57:06 +09:00
96ccd29bdc
Don't play metronome click when tapping for timing
2022-06-02 11:57:06 +09:00
d47a3bb8e4
Use NRT and transfer BPM
2022-06-02 11:57:06 +09:00
a2d177d7d2
Add BPM display and tracking
2022-06-02 11:57:06 +09:00
3c7a04256f
Add glow
2022-06-02 11:57:06 +09:00
c3ba7b2c3b
Add lights
2022-06-02 11:57:06 +09:00
d12f6ea221
Add basics of tap button
2022-06-02 11:57:06 +09:00
453259df62
Merge pull request #18516 from peppy/metronome-sound
...
Add metronome sound
2022-06-02 07:38:42 +09:00
6b297bc6ed
Merge pull request #18502 from peppy/editor-timing-follow-current-time
...
Add automatic control point tracking to the timing screen
2022-06-02 07:37:03 +09:00
c0001d7f00
Merge branch 'master' into metronome-sound
2022-06-01 22:32:48 +02:00
d3b51c7387
Merge branch 'master' into editor-waveform-display-lock
2022-06-01 21:56:01 +02:00
0723709bec
Merge branch 'master' into editor-offset-bpm-adjust-buttons
2022-06-01 21:25:18 +02:00
801e11d841
Apply performance regression fix to effect section too
2022-06-01 20:25:56 +02:00
6b709de2c2
Remove unused using directive
2022-06-01 20:18:02 +02:00
a5d515dd0c
Merge branch 'master' into editor-new-control-point-is-bettert
2022-06-01 19:48:17 +02:00
534e8f8fac
Only switch to found group if non-null
2022-06-01 20:20:48 +09:00
a4ec32b499
Add button sound effect
2022-06-01 18:15:16 +09:00
93b8c90ecc
Apply frequency adjust to channel rather than sample for safety
2022-06-01 18:04:13 +09:00
0472881078
Fix null check only covering one of two calls
2022-06-01 18:03:03 +09:00
187acb0718
Simplify linq tracking logic
2022-06-01 17:57:53 +09:00
1293bbdbd9
Remove unnecessary null checks on Text property
2022-06-01 17:46:33 +09:00
8c54bd46bb
Rename button to more appropriate name
2022-06-01 17:46:05 +09:00
b03b0c9303
Merge branch 'master' into editor-offset-bpm-adjust-buttons
2022-06-01 17:45:16 +09:00
