a7be59175d
Made private + renamed Taiko Single Tap tracking variables for better readability
2023-03-06 10:59:22 +00:00
3a240aaa5f
style: use 64 radius
2023-03-06 10:27:59 +00:00
87d0bef313
Use nullable comparison helper method instead of manual implementation
2023-03-06 15:16:32 +09:00
ddee6400df
test: add coverage for Player{Avatar,Flag}
2023-03-05 23:46:51 +00:00
07bde4990d
feat: implement PlayerAvatar
2023-03-05 23:17:39 +00:00
20a610ea6c
style: a NRT pass on UpdateableFlag
2023-03-05 23:15:58 +00:00
654eacd449
feat(l10n): localise CornerRadius
2023-03-05 23:10:42 +00:00
082bfe3621
refactor: SkinnableAvatar to PlayerAvatar
2023-03-05 23:09:02 +00:00
908651cc11
make ResetConfirmDialog properly utilise its parent's logic
...
Adjust name of `DeleteAction` to `DangerousAction`
2023-03-05 20:57:26 +01:00
778cde8932
Merge pull request #22790 from Joehuu/fix-android-external-links
...
Fix external links not working on Android
2023-03-05 22:12:57 +09:00
77257398db
Merge pull request #22787 from bdach/skin-editor-screen-transitions
...
Fix several issues with skin editor behaviour on screen transitions
2023-03-05 22:00:14 +09:00
d120638e68
Use manifest overlay and merger for intent query specs
...
Co-authored-by: Susko3 <Susko3@protonmail.com >
2023-03-05 13:17:46 +01:00
5d6ab5f465
Add mailto scheme to intent queries
2023-03-04 16:07:29 -08:00
92f94278c1
Fix external links not working on Android
2023-03-04 13:35:34 -08:00
b0cd801405
fix code quality
2023-03-04 19:34:22 +01:00
5146f7c978
using array again in GetSearchableTerms
2023-03-04 16:49:46 +01:00
70a925aab1
added extra early-returns
2023-03-04 16:49:33 +01:00
b90c389ff0
using List instead of Span in GetSearchableTerms
2023-03-04 15:42:35 +01:00
3185418834
Add benchmarks for carousel beatmap filter
2023-03-04 15:14:22 +01:00
60cdd3c070
Clear components sidebar unconditionally on every target change
...
Fixes the working layer dropdown lingering after exiting from a
skinnable screen to a non-skinnable one.
2023-03-04 14:10:05 +01:00
9d4bb2ecf7
Add failing test coverage for clearing sidebar contents
2023-03-04 14:08:50 +01:00
d233f3a3ab
Show non-skinnable screen placeholder at higher level
2023-03-04 13:49:10 +01:00
49e298e304
Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer
...
An end result of #22674 is that `SkinBlueprintContainer`s are only ever
created by supplying a `SkinComponentsContainer` to them. However,
`SkinBlueprintContainer` still contained remnants of code that suggested
it was designed to handle cases where more than the drawable supplied to
it contained more than one `ISerialisableDrawableContainer`, or even
zero.
The zero path is totally dead right now (because every
`SkinComponentsContainer` is *by necessity* an
`ISerialisableDrawableContainer`), and the more-than-one path is dead
*for now* (and potentially forever?). Therefore, just hard-couple
`SkinBlueprintContainer` to receive a single target container.
2023-03-04 13:33:21 +01:00
2f25fb4083
Move NonSkinnableScreenPlaceholder to outer scope
2023-03-04 13:22:43 +01:00
15409b9c15
Fix skin selection not clearing on exit to non-skinnable screen
2023-03-04 13:18:34 +01:00
3dd3b5e77a
Add failing test case
2023-03-04 13:17:54 +01:00
d5ba5eed88
fix(SkinnableAvatar): init avatar.CornerRadius
2023-03-03 23:47:22 +00:00
b4ed2db15e
Removed accidental strong hit in single tap break test
2023-03-03 20:40:30 +00:00
41e6956432
Improved single tap strong hit test
2023-03-03 20:38:11 +00:00
866987d6e1
Merge pull request #22776 from peppy/fix-mania-upscroll
...
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 21:37:51 +01:00
93fd940164
Added new tests for Taiko Single Tap mod
2023-03-03 20:35:28 +00:00
d39b8c7c23
fix(SkinnableAvatar): update outdated interface
2023-03-03 19:35:45 +00:00
edd37a9a7c
cleanup
2023-03-03 16:16:45 -03:00
ada610b907
Revert my changes on tests
2023-03-03 16:15:49 -03:00
e23db62386
Do list group'badges in a nicer way
2023-03-03 16:14:19 -03:00
e75aa9138b
Merge branch 'ppy:master' into hud/avatar-thing
2023-03-03 20:03:56 +01:00
91d206e8d2
Optimised GetSearchableTerms
...
Reduced memory allocations to 1
2023-03-03 19:21:50 +01:00
50b0fca264
Code formatting
2023-03-03 18:11:29 +00:00
4dbe589de2
Fixed Taiko Single Tap test pass condition
2023-03-03 17:22:45 +00:00
865f785f50
Fixed an issue where Taiko's Single Tap could allow alternation under very specific circumstances
2023-03-03 17:13:39 +00:00
322f3e86ba
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-03 20:02:09 +03:00
ec95d00313
Added Taiko Single Tap test scene
2023-03-03 16:57:09 +00:00
3bff415909
Change ResetDialogue text
2023-03-03 15:16:48 +01:00
2b7111867c
Adjust reversion header text naming.
2023-03-03 15:12:20 +01:00
36058b3da2
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 18:03:06 +09:00
a14dede036
Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
...
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.
Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
7a092ea995
Add better coverage and more comments explaining the structure of test setup
2023-03-03 17:18:14 +09:00
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
6ff1fb6b1a
Adjust sizing to allow for timing point information now being longer than before
2023-03-02 18:57:54 +09:00
29be26b150
Merge pull request #22766 from Joehuu/fix-talking-with-text-overflow
...
Fix "talking with" text overflowing when usernames are too long
2023-03-02 17:04:11 +09:00
