b4ca6b6188
Update popover logic to take advantage of new explicit popup functionality
2021-07-12 18:25:04 +09:00
a3e0168a46
Update tests
2021-07-12 18:25:04 +09:00
e25b3518dc
Make password popover display inside RoomsContainer rooms
2021-07-12 18:25:04 +09:00
9f9d7f9125
Add remaining pieces of password flow (for osu-web join request)
2021-07-12 18:22:52 +09:00
3c49b46c5f
Add lock overlay for rooms which are password protected
2021-07-12 18:22:52 +09:00
f35d55c32f
Fix HasPassword not being in sync with Password value for client-side rooms
2021-07-12 15:49:19 +09:00
08c40938db
Add support for updating a room's password
2021-07-12 15:49:19 +09:00
84b0a3290c
Add multiplayer lounge test coverage
2021-07-12 15:49:19 +09:00
5148069efe
Update signatures in line with no-overload methods (unsupported by signalr)
2021-07-12 15:49:19 +09:00
2ca11d458a
Add password to room settings and multiplayer lounge interface
2021-07-12 15:49:19 +09:00
6a74fde082
Add has_password flag and region post only parameters
2021-07-12 15:49:19 +09:00
4fd6f2101c
Add password textbox input
2021-07-12 15:49:19 +09:00
24f330e5c1
Avoid MatchSettingsOverlay base class potentially accessing an uninitialised field
2021-07-12 15:49:19 +09:00
0db316d644
Add password scaffolding
2021-07-12 15:49:19 +09:00
0c52b26d23
Merge pull request #13824 from peppy/da-mod-refactor
...
Refactor `ModDifficultyAdjust` to more elegantly track user override status
2021-07-12 12:03:45 +09:00
ffa60479c9
Merge pull request #13839 from peppy/fix-migration-test-failure
...
Fix migration target having left over files potentially causing test failures
2021-07-12 11:47:18 +09:00
a6258d705e
Make CurrentNumber internal
2021-07-12 11:26:30 +09:00
32b4f5fbd6
Do not store direct references to original bindable
...
`DifficultyAdjustSettingsControl` and its inner `SliderControl` were
holding different references to `DifficultyBindable`s from the
difficulty adjust mod, therefore leading to bindings being lost to the
framework-side automatic unbind logic if the mod was toggled off and
back on in rapid succession.
Resolve by adding a shadowed implementation of `GetBoundCopy()` and
using it to isolate the controls from the mod bindable.
2021-07-11 15:28:13 +02:00
e0b2356bb0
Merge pull request #13853 from frenzibyte/disallow-custom-ruleset-score-submission
...
Disallow custom rulesets from attempting to submit scores
2021-07-11 15:21:38 +09:00
79d546afa2
Add missing osu!catch difficulty adjust attributes
2021-07-11 10:14:42 +09:00
f21ea3b790
Update player test scene Ruleset bindable from creation method
2021-07-11 03:46:19 +03:00
6b8de2a10b
Add test coverage for excluded cases in score submission
2021-07-11 03:35:35 +03:00
07ede7a147
Disallow custom rulesets from score submission
2021-07-11 03:34:57 +03:00
236e8019cc
Merge pull request #13840 from peppy/fix-run-from-screen-test-failures
...
Ensure run-from-screen song select reaches correct point in execution
2021-07-10 14:13:21 +02:00
08cd17435c
Merge branch 'master' into fix-run-from-screen-test-failures
2021-07-10 13:37:20 +02:00
94406d77de
Merge pull request #13838 from peppy/fix-access-denied-test-failures
...
Fix test failures due to logger pollution
2021-07-10 13:36:33 +02:00
1bd5b1a8b9
Merge branch 'master' into fix-access-denied-test-failures
2021-07-10 13:00:27 +02:00
c64fe06bf6
Merge pull request #13828 from ekrctb/catch-editor-selection-confine
...
Don't move selected objects outside the playfield in catch editor
2021-07-10 19:30:32 +09:00
b705213ea9
Update test to match expectations after refactor
2021-07-10 11:44:32 +02:00
6f89f8e572
Merge branch 'master' into da-mod-refactor
2021-07-10 11:41:54 +02:00
c5011865fc
Invert strangely negated condition
2021-07-10 11:23:38 +02:00
494089e402
Fix up English in comment
2021-07-10 11:22:54 +02:00
e8005e3bfb
Merge pull request #13841 from peppy/update-song-progress-keyboard-handling
...
Move handling of replay seek operations out of progress bar
2021-07-10 11:17:40 +02:00
6ae631b03a
Remove previous seek testing logic from common test scene
2021-07-09 16:52:03 +09:00
995ef953c6
Modify comment
2021-07-09 15:13:54 +09:00
9083b28114
Add test coverage of seeking and pausing
2021-07-09 14:47:11 +09:00
6a5f0e8237
Move handling of replay seek operations out of progress bar
...
This is in order to avoid using the now obsoleted property
`SliderBar.AllowKeyboardInputWhenNotHovered`
(see https://github.com/ppy/osu-framework/pull/4579 ).
2021-07-09 14:28:59 +09:00
741062a6da
Simplify bindable update methods
2021-07-09 13:58:44 +09:00
e0277763d0
Refactor DifficultyAdjustSettingsControl to help with readability
2021-07-09 13:50:07 +09:00
51bd83b3f4
Update override matching test to match expectations
2021-07-09 13:30:14 +09:00
f9cd7f10d8
Allow null values for ReadCurrentFromDifficulty
...
As long as this isn't a constructor parameter it feels best to
gracefully handle omission. Realistically having it in the ctor is the
best move, but it doesn't feel great in line with the other parameters
passed in via object initalisers.
2021-07-09 13:26:01 +09:00
90326f8864
Standardise variables
2021-07-09 13:24:26 +09:00
df4bd86cfc
Fix storage wrapping logic setting logger too early in startup sequence
2021-07-09 13:18:49 +09:00
f3b68a4fbf
Fix storage wrapping logic setting logger too early in startup sequence
2021-07-09 13:17:25 +09:00
7e14679606
Expand the selection movement limiting code with detailed comments
2021-07-09 12:58:08 +09:00
9786e1a932
Ensure run-from-screen song select reaches correct point in execution
...
Fixes issues as seen at
https://github.com/ppy/osu/runs/3023581865?check_suite_focus=true . Song
select may take a few frames to perform initial selection as there is a
bit of internal async logic. This ensures that the beatmap has been
updated before continuing with test execution.
2021-07-09 12:36:56 +09:00
887035c12e
Fix migration target having left over files potentially causing test failures
...
As seen at
https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050324 .
2021-07-09 12:21:25 +09:00
9f7c6adb58
Fix test failures due to logger pollution
...
As seen at
https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050307 . I
can't confirm that this will fix the issue but it looks like the only
plausible reason. I have confirmed that the logging is not coming from
the local (first logging is guaranteed to be after `SetupForRun`).
2021-07-09 12:15:30 +09:00
dbfeea9880
Merge pull request #13831 from nekodex/add-dropdown-sound-to-profile
...
Change profile section expansion button to use dropdown sounds
2021-07-09 11:58:48 +09:00
2eb12a59b7
Rename function to be more accurate
2021-07-09 11:16:47 +09:00
