b65e607941
Add test covering mod displays with too many mods
2021-07-21 16:43:41 +09:00
5bee06fd5f
Remove forgotten AutoSize specification
2021-07-21 16:43:29 +09:00
396ad79d50
Remove unnecessary UnbindAll call
2021-07-21 16:43:08 +09:00
a63065dbe9
Tidy up ModDisplay
2021-07-21 16:38:25 +09:00
747c475b95
Merge pull request #13932 from peppy/fix-multiple-request-completion-states
...
Fix API request potentially firing failed events after completion
2021-07-21 15:11:03 +09:00
59dd3452fe
Merge pull request #13954 from bdach/user-profile-beatmap-api-adjustments
...
Adjust user beatmap section naming on profile overlay to match web
2021-07-21 08:21:10 +09:00
ba62a0f877
Merge pull request #13955 from bdach/password-popover-enter
...
Allow confirming room password by pressing Enter
2021-07-21 08:20:20 +09:00
db9cf443c7
Allow confirming room password by pressing Enter
2021-07-21 00:04:51 +02:00
1e634d9db0
Adjust user beatmap sections on profile overlay to match web
2021-07-20 21:55:17 +02:00
738d321788
Merge pull request #13946 from peppy/fix-online-play-sub-screens-not-async-loaded
...
Fix `OnlinePlayScreen` sub-screens not loaded asynchronously
2021-07-20 19:51:13 +09:00
d066ebcd70
Merge pull request #12682 from frenzibyte/refactor-combo-colour-retrieval
...
Refactor combo colours retrieval to use skin config lookups instead
2021-07-20 19:47:57 +09:00
15127f972e
Merge branch 'master' into fix-online-play-sub-screens-not-async-loaded
2021-07-20 18:47:41 +09:00
13733d8c75
Merge pull request #13943 from peppy/fix-subscreen-exit-before-loaded
...
Ensure online play subscreen is loaded before forwarding `OnExiting`
2021-07-20 18:36:42 +09:00
26cc4af87c
Revert unintended changes
2021-07-20 16:44:51 +09:00
d87ea741ed
Fix OnlinePlayScreen sub-screens not loaded asynchronously
2021-07-20 16:38:39 +09:00
4113eae6ad
Add test coverage of fail scenario
2021-07-20 16:37:13 +09:00
1af230c48c
Merge branch 'master' into refactor-combo-colour-retrieval
2021-07-20 10:08:25 +03:00
fe414b942f
Ensure online play subscreen is loaded before forwarding OnExiting
...
Closes https://github.com/ppy/osu-framework/issues/4619 (actually not a
framework issue; the framework correctly guards against this scenario,
see
4e29504384/osu.Framework/Screens/ScreenStack.cs (L277)
2021-07-20 15:51:34 +09:00
6cc81c24b4
Merge pull request #13785 from ekrctb/dependency-providing-container
...
Add a convenient way to provide ad-hoc dependency to children in visual test
2021-07-20 14:18:17 +09:00
f415dc18a7
Merge pull request #13941 from Henry-YSLin/update-TargetBeatContainer
...
Update `OsuModTarget` to take advantage of the new `BeatSyncedContainer`
2021-07-20 12:30:49 +09:00
1c6a13fca7
Disallow mistimed event firing
2021-07-20 10:31:19 +08:00
a387d8df74
Use BeatSyncClock
2021-07-20 10:30:40 +08:00
9ea1f5900a
Don't consider version suffixes when checking for updates
...
This is just to make life easier for me with deploys for now.
2021-07-20 01:05:37 +09:00
e77597c2b6
Merge pull request #13921 from Game4all/localise-profile-overlay
...
Localise user profile overlay
2021-07-20 00:37:01 +09:00
844152e1b1
Merge pull request #13861 from peppy/add-password-support
...
Add multiplayer room password support
2021-07-19 23:32:28 +09:00
6e104fe084
Merge pull request #13894 from peppy/fix-beat-synced-container-alt
...
Fix multiple issues with `BeatSyncedContainer`
2021-07-19 23:19:20 +09:00
0fc1d3e404
Merge pull request #13931 from peppy/fix-replay-date
...
Fix replay dates being unexpectedly updated on play completion
2021-07-19 22:56:27 +09:00
6a55cb9df0
Revert unintended change
...
It's a deeper issue with ScreenStack (see:
https://github.com/ppy/osu-framework/issues/4619 ).
2021-07-19 22:52:07 +09:00
7956f73f62
Move initial content into step
2021-07-19 22:31:53 +09:00
57a99886d5
Fix password icon not disappearing when no password
2021-07-19 22:31:01 +09:00
892d858d5f
Fix compile error
2021-07-19 22:23:31 +09:00
b7c2d6b1ab
Merge branch 'master' into add-password-support
2021-07-19 22:23:09 +09:00
6d49165664
Merge pull request #13928 from ekrctb/juice-stream-path
...
Add `JuiceStreamPath` as alternative representation of `JuiceStream` path for catch editor
2021-07-19 22:18:05 +09:00
5ef1fe6948
Merge branch 'master' into fix-replay-date
2021-07-19 21:58:37 +09:00
f3bcaf7f11
Merge pull request #13929 from peppy/i-deep-cloneable
...
Create a deep clone of score for score submission purposes
2021-07-19 21:58:27 +09:00
0a43e54dfc
Fix request failing due to parameters
2021-07-19 21:24:22 +09:00
a001e4aa16
Fix web request failing if password is null
2021-07-19 20:57:16 +09:00
05295241b8
Add room joining tests
2021-07-19 20:55:14 +09:00
3168a927dc
Fix possible exception
2021-07-19 20:50:30 +09:00
80c2b1449b
Fix API request potentially firing failed events after completion
...
Specifically, `Cancel()` calls were not thread safe. Due to a series of
events, `ListPollingComponent` could call `Cancel` from a non-update
thread, leading to a race condition where both a `Success` and `Fail`
event can be fired.
This is intended to be the simplest fix possible, locking and guarding
specifically on the callbacks. Further work could be done in the future
to improve the flow surrounding `pendingFailure`, potentially reducing
redundant work and cleaning up the code, but that's not happening here.
Closes https://github.com/ppy/osu/issues/13632 .
2021-07-19 20:27:01 +09:00
2eec524f27
Fix password not copied from multiplayer client
2021-07-19 20:20:08 +09:00
d6aa15e5d7
Remove local APIRoom from test multiplayer client
2021-07-19 20:19:23 +09:00
1b9d297911
Add test
2021-07-19 20:08:29 +09:00
a5a0f12e19
Also copy password in test room manager
2021-07-19 20:07:56 +09:00
26d0eea485
Set HasPassword correctly in the response room
2021-07-19 20:03:32 +09:00
2515785f93
Use room password to fill settings textbox
2021-07-19 20:03:32 +09:00
8c0daa89a0
Make test multiplayer client validate password
2021-07-19 20:03:27 +09:00
063f14da98
Update test room manager to not return passwords
2021-07-19 20:03:27 +09:00
b3f60c8253
Fix date being updated on replays unexpectedly
2021-07-19 19:28:35 +09:00
f16b4957aa
Move clone to earlier in the process
2021-07-19 19:18:34 +09:00
