Commit Graph

53096 Commits

Author SHA1 Message Date
b663986b9f Add test coverage of locally available without replay button handling 2022-07-07 17:04:04 +09:00
461d133c1f Add test coverage of score importing 2022-07-07 16:43:31 +09:00
1a41d3ef20 Allow PlayerTestScene to import the beatmap it's using 2022-07-07 16:42:36 +09:00
f88e2aa025 Remove EF test workaround 2022-07-07 15:02:03 +09:00
9d730f8440 Fix custom rulesets not importing scores at all
Replaces the error with the ability to import, minus replays.

Closes https://github.com/ppy/osu/issues/17350 (arguably, but let's go with it for now).
2022-07-07 14:49:23 +09:00
e5dd7b1654 Merge pull request #19021 from frenzibyte/fix-flaky-tests-envvar
Fix flaky tests not running at all with environment variable set
2022-07-07 10:56:38 +09:00
9115072917 Fix flaky tests not running at all with environment variable set 2022-07-07 04:24:10 +03:00
1ff3b19360 Merge pull request #19020 from frenzibyte/mgcc-descriptive-asserts
Improve asserts in `TestSeekPerformsInGameplayTime` to be more descriptive
2022-07-07 08:51:24 +09:00
a5b01b8920 Improve asserts in TestSeekPerformsInGameplayTime to be more descriptive 2022-07-07 01:00:55 +03:00
b9acdcdbe2 Merge pull request #19014 from peppy/line-buffered-reader-simplification
Enable NRT and simplify `LineBufferedReader`
2022-07-06 20:27:04 +09:00
c2f1069073 Avoid usage of finally in potentially hot path 2022-07-06 19:55:51 +09:00
01bc6e5cb7 Revert old behaviour of ReadToEnd 2022-07-06 19:55:51 +09:00
8f63592d6b Merge pull request #19013 from peppy/fix-param-naming
Fix incorrect case in `CatcherArea` parameter
2022-07-06 19:46:52 +09:00
6340caf27d Merge pull request #19018 from peppy/memory-caching-component-statistics
Add statistics display for `MemoryCachingComponent`s
2022-07-06 19:20:36 +09:00
9f76118ee0 Merge pull request #19015 from peppy/improve-beatmap-parsing-performance
Fix `BeatSyncedContainer` unintentionally blocking on beatmap load
2022-07-06 18:41:07 +09:00
a1b6ec60c8 Add statistics display for MemoryCachingComponents
Never sure if these are working as they should (or how well they are
working). This helps quite a bit.
2022-07-06 18:38:40 +09:00
12d396a513 Use -1 to specify default buffer size 2022-07-06 15:43:35 +09:00
ae49aafde2 Fix BeatSyncedContainer unintentionally blocking on beatmap load 2022-07-06 14:58:06 +09:00
a52ea3cabe Enable NRT and simplify LineBufferedReader 2022-07-06 14:57:56 +09:00
7053a8507b Merge pull request #18993 from Joehuu/fix-personal-best-delete-context-menu
Fix personal best score showing delete option on context menu
2022-07-06 14:53:35 +09:00
c95eb2d2c1 Fix incorrect case in CatcherArea parameter 2022-07-06 14:28:50 +09:00
73a5f9e911 Merge pull request #19010 from peppy/forgotten-password-link
Add forgotten password link to login form
2022-07-06 13:55:18 +09:00
6fb00d84f9 Apply NRT to LoginForm and remove nullability of IAPIProvider 2022-07-06 01:29:00 +09:00
3a68f386a8 Add forgotten password link to login form 2022-07-06 01:25:04 +09:00
85e589f863 Merge pull request #19005 from Susko3/initial-cookie
Allow MIDI and joysticks to trigger the osu! cookie on the initial screen
2022-07-05 19:26:56 +09:00
4c3789ec5d Split into a function 2022-07-05 11:15:37 +02:00
9c1fda6048 Merge pull request #19006 from peppy/realm-locking-test-safety
Fix intermittent realm migration test failures
2022-07-05 16:23:43 +09:00
33db508301 Add note regarding why the realmRetrievalLock return is done on the async thread 2022-07-05 16:23:10 +09:00
5adec2c738 Ensure blocking restoration only completes after update callback work is completed 2022-07-05 14:39:14 +09:00
1b98936328 Rename realm ThreadLocal to better convey what it's doing
Every time I looked at this code I have to re-learn what it's doing.
Changing these variable names should help quite a bit.
2022-07-05 13:38:25 +09:00
bb0f212448 Trigger the initial cookie with midi and joysticks 2022-07-05 00:38:18 +02:00
f1b55d743c Fix delete local score test having no files 2022-07-04 11:04:20 -07:00
b49a1aab8a Merge pull request #18997 from peppy/fix-realm-backup-ctor-fail
Fix realm backup creation failing when run from `RealmAccess` constructor
2022-07-04 18:41:57 +09:00
506409a9c4 Fix realm backup creation failing when run from RealmAccess constructor
At the point of construction, we are not on the update thread, but it
doesn't really matter at this point because there's no other usages.
2022-07-04 16:45:23 +09:00
64edc6888d Add test coverage of corrupt realm creating backup 2022-07-04 16:45:23 +09:00
925d7b1fdc Update framework 2022-07-04 15:01:01 +09:00
65917fbb99 Merge pull request #18990 from andy840119/remove-nullable-disable-in-the-ruleset-filter
Remove nullable disable annotation in the ruleset filter.
2022-07-04 13:46:31 +09:00
df152421a8 Fix personal best score showing delete option on context menu 2022-07-03 10:23:17 -07:00
50a5462446 Merge pull request #18992 from peppy/update-framework
Update framework
2022-07-03 23:59:53 +09:00
e4bf2224c6 Update framework 2022-07-03 23:16:51 +09:00
14ef771290 Remove the nullable disable annotation in the test case. 2022-07-03 21:05:14 +08:00
a7bcc32cc2 Remove the nullable disable annotation in the mania ruleset. 2022-07-03 21:04:39 +08:00
59e3d4b9e5 Remove the nullable disable annotation in the Ruleset.Filter namespace. 2022-07-03 21:00:54 +08:00
9bf91835b6 Merge pull request #18962 from peppy/slider-range-control
Move star difficulty filter to song select
2022-07-03 21:58:00 +09:00
385bd5a1b2 Merge pull request #18965 from peppy/mark-flaky-tests
Mark, document and silence remaining flaky tests on standard CI runs
2022-07-03 21:41:14 +09:00
ccc322e100 Merge pull request #18985 from andy840119/remove-nullable-disable-in-the-replays
Remove nullable disable annotation in replays namespace
2022-07-03 21:19:36 +09:00
724fd19038 Remove nullable disables 2022-07-03 21:15:13 +09:00
8c2f4b48fc Use debug.assert for better readable. 2022-07-03 19:27:56 +08:00
1ccfd69690 Merge pull request #18978 from peppy/send-beatmap-hash-to-server
Send beatmap hash to server on solo score request
2022-07-03 13:18:17 +09:00
982bcc4500 Merge pull request #18981 from peppy/fix-beatmap-info-wedge-test
Fix `BeatmapInfoWedge` test potentially failing due to quick initial load
2022-07-03 13:10:16 +09:00