Commit Graph

13943 Commits

Author SHA1 Message Date
6ca17bdfd5 Center icon and text using anchor and origin instead of margin 2019-09-02 10:42:21 -07:00
53c254c6a5 Replace Array.IndexOf() with Contains() 2019-09-02 19:01:36 +02:00
09097f7680 Merge branch 'master' into iskincomponent 2019-09-02 22:38:57 +09:00
3443a9517f Merge pull request #5953 from peppy/fix-direct-panel-unbind-nullref
Fix potential null reference on DirectPanel unbind
2019-09-02 21:35:17 +09:00
1e7528c2b3 Merge remote-tracking branch 'upstream/master' into non-timeoffset-judgements 2019-09-02 19:13:00 +09:00
b460f76fa6 Adjust file spacing slightly 2019-09-02 19:01:43 +09:00
0bfe4650c3 Early return if no change occurred in looping value 2019-09-02 19:01:17 +09:00
f08b523abf Name tuple items 2019-09-02 18:20:30 +09:00
9c53430a0f Only initialise when required 2019-09-02 18:18:59 +09:00
eaeecfb300 Merge remote-tracking branch 'upstream/master' into add-adjustment-function-for-skinnable-sound 2019-09-02 18:15:17 +09:00
f20e07136a Add attribute to catch potential future nullrefs 2019-09-02 17:48:41 +09:00
be5baef386 Merge pull request #5778 from EVAST9919/kudosu-info
Add kudosu history to UserProfileOverlay
2019-09-02 17:22:53 +09:00
f6102b4d92 Adjust xmldoc 2019-09-02 17:15:36 +09:00
0c73c5acf3 Expose full hitobject rather than hit windows 2019-09-02 17:14:40 +09:00
841da7d691 Fix potential null reference on DirectPanel unbind 2019-09-02 17:12:32 +09:00
d21d68b36c Refactor to match web implementation 1:1 2019-09-02 17:04:38 +09:00
f2bdf94a1d Add HitWindows to JudgementResult to indicate timing errors 2019-09-02 16:28:14 +09:00
0a89603e79 Fix hit error potentially not displaying with null hitwindows 2019-09-02 16:07:16 +09:00
0985b1679f Move enum to response class 2019-09-02 15:57:55 +09:00
3d551b08a9 Rename legacy actions 2019-09-02 15:57:23 +09:00
da45070373 Group common prefixes together 2019-09-02 15:44:21 +09:00
c06908adf7 Fix spacing specifications 2019-09-02 15:37:38 +09:00
13fadec6ec Merge remote-tracking branch 'upstream/master' into kudosu-info 2019-09-02 15:25:41 +09:00
daa2007b41 Merge branch 'master' into fix-switching-ruleset-unpauses-beatmap 2019-09-02 15:24:01 +09:00
e1e4c00a15 Merge branch 'master' into improve-scrolling-ruleset-performance 2019-09-02 15:09:48 +09:00
d74e1b9b64 Remove from dictionary on Remove() 2019-09-02 15:06:43 +09:00
8f8d35bd15 Delay initial hitobject state computation 2019-09-02 15:06:34 +09:00
f9fcf1562f Merge remote-tracking branch 'upstream/master' into iskincomponent 2019-09-02 14:21:02 +09:00
81e8290caf Merge pull request #5334 from stanriders/beatmapset-genre-language
Add genre and language sections to beatmapset overlay

Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-09-02 14:16:55 +09:00
78f753d919 Merge pull request #5949 from smoogipoo/fix-swell-timeoffset
Fix taiko swell tick judgements having non-zero time offsets
2019-09-02 13:46:37 +09:00
043034a6ce Merge remote-tracking branch 'upstream/master' into beatmapset-genre-language 2019-09-02 13:45:25 +09:00
d4c12881f5 Remove unnecessary over-complication and fix transitions 2019-09-02 13:45:13 +09:00
6603cbd74d No language doesn't mean "Other" 2019-09-02 13:41:14 +09:00
fc668d8a74 Move autoplay mod to a less overridable location 2019-09-02 13:24:39 +09:00
2945fef62d Expose HasCompleted from ScoreProcessor 2019-09-02 13:04:30 +09:00
cad68bb82f Add autoplay helper property 2019-09-02 12:54:59 +09:00
e479be3fba Merge pull request #5894 from smoogipoo/accessible-beatdivisor-colours
Move beat divisor colour retrieval to BindableBeatDivisor
2019-09-02 12:41:19 +09:00
31645a5834 Merge branch 'master' into channel-topic-serach 2019-09-02 12:07:11 +09:00
7ca51d3866 Fix resume overlay being drawn below cursor
Closes #5905.
2019-09-02 11:20:55 +09:00
fc48b190fe Fix inaccurate xmldoc 2019-09-01 13:32:53 +02:00
c4dc34eefd Consolidate HoverClickSounds constructors
As suggested in review, merge both HoverClickSounds constructors into
one accepting optional arguments. Due to existing usages the parameter
is added as second and supplied by name in ModButton.
2019-09-01 13:10:11 +02:00
d1eafafa51 Allow searching channels by topics
Closes #5939
2019-09-01 19:57:12 +09:00
f182fb158c Fix some spelling mistakes on code comments (#5927)
Fix some spelling mistakes on code comments
2019-09-01 13:32:56 +09:00
a155814bc4 Implement instant movement properly 2019-09-01 06:07:25 +03:00
7d955839be Instantly move rank graph tooltip 2019-09-01 04:22:24 +03:00
aff4dab9aa Ensure playing track of beatmap selected only if a track change occurred 2019-09-01 03:17:55 +03:00
658e0edc3e Handle other button clicks in HoverClickSounds
As suggested in review, remove previously introduced HoverMouseUpSounds
and instead change effect playing logic in HoverClickSounds by moving it
out of OnClick() to OnMouseUp().

Users of the class can either use the existing constructor to play
the effect only on left click or use the newly introduced constructor
with the MouseButton[] parameter to specify which button clicks should
trigger the sound.
2019-08-31 20:16:16 +02:00
a1c72db5f6 Fix inconsistent sound effects on mod buttons
Because HoverClickSounds.OnClick() does not fire upon right clicking
on mod buttons, the sound effects that play on left and right click
were inconsistent. Introduce HoverMouseUpSounds drawable that allows
to play the click sound effect upon mouse up events for an arbitrary
set of mouse buttons and use it on mod buttons.
2019-08-31 17:01:12 +02:00
5695bb670e change back to queuing 2019-08-31 10:55:05 -04:00
1b4ae5a4a4 Spelling fixes 2019-08-31 10:55:05 -04:00