Commit Graph

12908 Commits

Author SHA1 Message Date
be52d0a60c Add note explaining shadow opacity
pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`
2023-02-13 22:18:34 +01:00
61584ba63c Fix corner_radius missing in some parts of FooterButtonV2.cs.
Adjust shadow radius value to 5 to match figma.
2023-02-13 22:15:29 +01:00
6e6421caea Change FooterV2.cs colour to use ColourProvider instead of OsuColour.
Remove unnecessary `FillFlowContainer`
2023-02-13 22:12:25 +01:00
2dee783401 Remove not needed containers 2023-02-13 15:14:25 +03:00
aa2e0028ab refactor: hide trigger presence from content 2023-02-13 10:59:10 +00:00
11d0e185b8 refactor: separate impl of KeyCounterDisplay
This allows for different layouts of display. Idk, maybe someone would
want to mix both variants? (don't do this please). This commit is mostly
prep for further changes.
2023-02-13 01:36:12 +00:00
74a58fb674 refactor: separate things in KeyCounter
To implement different different sources of input for KeyCounter, it
is now possible to create a Trigger class (to inherit) instead of
inheriting KeyCounter. This eases the creation of more input sources
(like for tests) while allowing to implement different UI variants.

That way, if another variant of the key counter needs to implemented
(for whathever reason), this can be done by only inheriting KeyCounter
and changing how things are arranged visually.
2023-02-13 01:24:27 +00:00
cb51b9e350 Use existing ModdingBeatmap activity 2023-02-12 15:01:50 -08:00
bbeef53569 Add TestingBeatmap activity 2023-02-12 13:11:42 -08:00
afb66d8af4 Make user activity class names more specific 2023-02-12 12:32:17 -08:00
774eae98cc Merge branch 'master' into editor-select-timing-on-enter 2023-02-11 16:27:22 +01:00
a3cc0d23b3 Fix typo in xmldoc 2023-02-11 16:26:32 +01:00
0c5dae5f26 Merge pull request #22529 from ItsShamed/dsc/presence
Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`
2023-02-11 17:29:47 +09:00
81c3e0da31 Fixed timeLeft counter in SongProgressInfo being out of bounds after rotation 2023-02-10 17:58:48 +01:00
6d876fdb9a Automatically select the closest timing point on entering the timing screen 2023-02-10 17:48:56 +09:00
03e623d1d2 Move ControlPointList to own file 2023-02-10 17:37:31 +09:00
eccde923e5 Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability
Improve readability of `AccuracyCircle`
2023-02-10 17:03:46 +09:00
cf009432cc Centralise accuracy cutoff constants and add lookup helper methods 2023-02-09 15:41:58 +09:00
57312279f0 adjust RankNotch gap size to match original value 2023-02-09 02:20:05 +01:00
fd93bd3f50 move rank accuracy requirements to class-local constants 2023-02-09 00:46:24 +01:00
ee40444fd3 use Precision.AlmostEquals for bounds check 2023-02-08 23:59:19 +01:00
0531c010eb display RankBadges on on their sector centres
the D `RankBadge` does this anyway. the A and S badges are slightly off
centre to prevent overlap with the SS badge
2023-02-08 14:01:40 +01:00
6ace6bfee1 ensure AccuracyCircle doesn't land in gaps created by RankNotches 2023-02-08 13:20:53 +01:00
3a3c2e78a1 Merge branch 'master' into skin-editor-undo-support 2023-02-08 15:41:58 +09:00
b6809e156b Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii
Implement a sheared slider for the updated design
2023-02-08 15:01:00 +09:00
PC
7e127dafe2 Update reference 2023-02-07 11:52:47 +03:00
e162fd56da Change the way initial state saving works in EditorChangeHandler to be closer to first change 2023-02-07 16:22:51 +09:00
bc89f8dc5b feat: add name and rulset verb display support 2023-02-06 12:44:00 +00:00
2c7386db39 FIx score appearing on BeatmapLeaderboard and TopLocalRank 2023-02-06 15:14:14 +03:00
aaf3ad805c Fix potential nullref in tests 2023-02-06 19:31:45 +09:00
b83c8443ea Ensure pause sample loop is stopped on exiting player 2023-02-06 18:24:31 +09:00
43f7665c9e Improved readability again 2023-02-06 09:49:42 +01:00
c691a0d3af Merge branch 'master' into sheared_slider_implementation_clean_ii 2023-02-06 17:49:33 +09:00
ddcc02fdfe Merge pull request #22505 from Joehuu/fix-hover-click-sounds
Fix some clickable elements having no hover and click sounds
2023-02-06 16:52:19 +09:00
4f23e096d7 Improved readability 2023-02-06 07:59:37 +01:00
778b8a9bf7 Fix default settings not being serialised / state tracked correctly 2023-02-06 15:00:42 +09:00
e4b17588f5 Add missing xmldoc to new methods in EditorChangeHandler 2023-02-06 14:11:40 +09:00
10ab4d572a Merge branch 'master' into skin-editor-undo-support 2023-02-06 13:46:50 +09:00
bf273597ea feat: actually support status also for Replays 2023-02-06 00:41:10 +00:00
d5b2d9ce97 feat: add support for spectating status 2023-02-05 23:58:08 +00:00
f58534f60c Extended the length of replay at the end of map 2023-02-05 18:51:28 +01:00
ef900bccdf Merge branch 'master' into BPM_counter_fix 2023-02-04 23:44:58 +01:00
cb7540564a Merge pull request #22504 from peppy/fix-editor-positional-nudge-undo
Fix beatmap editor positional nudging not being undoable
2023-02-04 15:52:34 +01:00
88872cf1cf Use ``GetTrueGameplayRate()`` to remove need for jank 2023-02-04 00:53:54 +01:00
d9bee958dd Stop ``BPMCounter.cs``'s value from going to 0 after failing. 2023-02-03 23:56:34 +01:00
97afb83394 Merge branch 'master' into carousel 2023-02-03 22:15:44 +01:00
63f7d326c2 Merge branch 'master' into fix-editor-positional-nudge-undo 2023-02-03 21:31:05 +01:00
4bd43171e8 Merge branch 'master' into fix-skin-editor-padding-weirdness 2023-02-03 20:28:47 +01:00
2cda277c09 Add a basic change handler to the skin editor 2023-02-03 18:57:50 +09:00
3345e34544 Move beatmap specific logic out of EditorChangeHandler 2023-02-03 17:53:54 +09:00