Commit Graph

414 Commits

Author SHA1 Message Date
444f66b0ee Move to base class for added safety 2023-05-03 18:46:30 +09:00
cd31cff8cd Fix event subscriptions not being cleaned up in DrawableCarouselBeatmap
The handling of cleanup is performed only the `Item_Set` method. This
was already correctly called for `DrawableCarouselBeatmapSet`, but not
for the class in question here.

This would cause runaway memory usage at song select when opening many
beatmaps to show their difficulties. For simplicity, we don't yet pool
these (and generate the drawables each time a set is opened) which isn't
great but likely will be improved upon when we update the visual /
filtering of the carousel. But this simplicity caused the memory usage
to blow out until exiting back to the main menu when cleanup would
finally occur.
2023-05-03 18:41:30 +09:00
556964eae0 Merge branch 'master' into BitmapUpdatesOnScore 2023-03-16 12:16:42 +03:00
6c5ccdfd90 Merge branch 'master' into optimise-search 2023-03-07 22:07:29 +01:00
5213bfa5c9 Merge branch 'master' into make_skin_reset_dangerous 2023-03-07 21:06:44 +01:00
5af41bb1c8 Move filter matching code into own method to simplify early returns 2023-03-07 17:24:17 +09:00
87d0bef313 Use nullable comparison helper method instead of manual implementation 2023-03-06 15:16:32 +09:00
908651cc11 make ResetConfirmDialog properly utilise its parent's logic
Adjust name of `DeleteAction` to `DangerousAction`
2023-03-05 20:57:26 +01:00
70a925aab1 added extra early-returns 2023-03-04 16:49:33 +01:00
b90c389ff0 using List instead of Span in GetSearchableTerms 2023-03-04 15:42:35 +01:00
91d206e8d2 Optimised GetSearchableTerms
Reduced memory allocations to 1
2023-03-03 19:21:50 +01:00
82293c0c86 Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.

In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
90227a6496 Rename DeleteConfirmationDialog.cs into DangerousActionDialog.cs 2023-02-27 21:57:59 +01:00
PC
7e127dafe2 Update reference 2023-02-07 11:52:47 +03:00
2c7386db39 FIx score appearing on BeatmapLeaderboard and TopLocalRank 2023-02-06 15:14:14 +03:00
ddcc02fdfe Merge pull request #22505 from Joehuu/fix-hover-click-sounds
Fix some clickable elements having no hover and click sounds
2023-02-06 16:52:19 +09:00
5a76c1ab9c Refactor HoverSampleDebounceComponent to inherit Component 2023-02-03 00:29:25 -08:00
f7094567d7 Rename and document method to limit scope 2023-02-03 15:04:47 +09:00
500e9c7944 Refactor into a method rather than property 2023-02-02 14:53:58 +09:00
942e7729f3 Merge branch 'master' into carousel 2023-02-02 14:41:55 +09:00
7ba448b13c Update comment to match implementation 2023-01-18 17:12:57 +01:00
3b27774561 Remove OnlineID sort consideration 2023-01-18 19:21:02 +09:00
a9ac28b504 Add fallback sorts to CarouselBeatmapSet to ensure stable sorting 2023-01-17 16:40:25 +09:00
832d033777 Fix merge issues 2023-01-16 01:09:04 +01:00
ab6bf6e1dc Merge remote-tracking branch 'upstream/master' into carousel 2023-01-16 00:27:56 +01:00
87ee9ab813 Added custom menu items in DrawableCarouselBeatmap 2023-01-16 00:13:12 +01:00
112cf403ec Fix intermittent failure in certain beatmap carousel tests 2023-01-13 19:41:44 +03:00
aab84d50eb Remove boxing overhead in CarouselItem comparator 2023-01-10 18:35:06 +01:00
b7e845201f Fix whitespace around Debug.Assert 2023-01-10 18:03:17 +09:00
d53dafa29f Revert Debug.Assert 2023-01-10 17:52:28 +09:00
6abbc7dc28 Further fix nullability 2023-01-09 20:59:28 +01:00
69260ca3c3 remove unnecessary usages of nullable forgiveness, add asserts for debugging 2023-01-09 18:36:55 +01:00
47fb467012 Remove nullable disabling in carousel 2023-01-08 19:02:48 +01:00
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
d9d083752a Clamp backwards index to total current items to fix edge case of item removal 2022-10-26 11:03:11 +09:00
cf3bf41b49 Harden and simplify logic to avoid weird issues 2022-10-25 18:57:15 +09:00
22ea9a8ab4 Add early return of carousel group has no items 2022-10-25 13:34:22 +09:00
2456a18bc1 Rewrite implementation to avoid duplicated LINQ returns 2022-10-25 12:48:17 +09:00
5a118cfdc3 Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection
 Conflicts:
	osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs
2022-10-24 21:40:48 +03:00
964ed01abb Add confirmation dialog for updating locally modified beatmaps 2022-10-13 02:40:15 +03:00
a44ba579c5 Fix beatmap update button not respecting user "prefer no video" setting
Closes #20701.
2022-10-11 14:27:40 +09:00
3cfacb5e39 Merge pull request #20257 from peppy/update-button-show-login
Show login overlay when attempting to update a beatmap while logged out
2022-09-12 17:51:45 +09:00
94f8197e22 Show login overlay when attempting to update a beatmap while logged out 2022-09-12 16:15:14 +09:00
95062c2cc8 Remove center origin specification to avoid single-frame layout issues 2022-09-09 19:42:58 +03:00
dd10a06e3d Merge branch 'master' into top-rank-badge-order 2022-09-09 19:38:44 +03:00
1524623624 Fix back-to-front filter logic
Was copied across from a place which was checking for `match` and
applied verbatim to a place that was `filter`. Which are polar
opposites.
2022-09-01 19:59:27 +09:00
217fa00a72 Bring logic up-to-date 2022-08-26 19:32:49 +09:00
a146db0e35 Merge branch 'master' into carousel-perform-selection 2022-08-26 19:29:00 +09:00
55f1b43329 Removed check 2022-08-22 13:41:36 -04:00
c2036d3893 Moved filter exclusion 2022-08-22 03:39:46 -04:00