f51413ead9
Refactor to pass clockrate in constructor rather than deriving from mods
2021-06-03 16:09:42 +10:00
85d2b1232a
Refactor to abstract out strain logic into StrainSkill class
...
While it is the case for the existing official Skills, Skill implementations shouldn't be required to conform to a strain based approach.
There are other valid approaches to calculating skill difficulty that can be supported by abstracting the strain logic into its own StrainSkill class.
2021-04-03 20:52:39 +11:00
66643a97b0
Add a list of mods to Skill class
...
Although this isn't necessary for existing official rulesets and calculators, custom calculators can have use cases for accessing mods in difficulty calculation.
For example, accounting for the effects of visual mods.
2021-02-20 20:37:44 +11:00
1ba586a683
Revert overlooked AR<8 speed buff
...
Pull request #11107 introduced changes in osu! performance calculation,
related to a scaling coefficient applied to the speed and aim skills.
The coefficient in question was dependent on the approach rate of
a map. During a post-merge review of that PR, it was spotted that
the scaling coefficient for speed also had a 10x buff applied for AR<8,
which could reach magnitudes as large as 80% on AR0, which seems quite
exorbitant. This change was not discussed or mentioned anywhere in the
review process.
Revert back to the old multiplier of 0.01 rather than 0.1 for AR<8. The
negative slope through AR0 to 8 is retained in its previous form.
2021-01-13 17:59:29 +01:00
76ffe31855
Merge pull request #11138 from smoogipoo/stanr-nf-multiplier
...
Port StanR's NF multiplier changes
2020-12-17 18:59:46 +09:00
8bdef0ff55
Code quality fix
...
Co-authored-by: Dean Herbert <pe@ppy.sh >
2020-12-15 13:18:41 +09:00
54827d4e96
fixed low 50s count still penalizing high obj count maps
2020-12-14 12:41:24 -06:00
1dce446c52
Merge branch 'miss-penalty-curve'
2020-12-11 10:49:31 -06:00
b7872a54b8
small factor rebalance
2020-12-11 10:48:53 -06:00
a5a66e71f9
Merge branch 'miss-penalty-curve'
2020-12-11 10:22:04 -06:00
abc8a2982c
swapped ^.75 buff onto speed instead of aim
2020-12-11 08:20:56 -06:00
c20117f0fb
Merge branch 'miss-penalty-curve'
2020-12-11 08:02:39 -06:00
544160798b
cleaned up mistakes and made quality changes
2020-12-11 08:01:45 -06:00
fd0d793c69
changed the comment to reflect the change
2020-12-10 18:51:54 -06:00
e45417d4fe
Merge branch 'lowacc-nerf'
2020-12-10 14:24:42 -06:00
1f2946d64c
changed miss penalty curve to scale with totalhits
2020-12-10 14:21:06 -06:00
cc5639d2b4
added unneeded whitespace
2020-12-10 09:48:40 -06:00
7c2f506b79
Port StanR's NF multiplier changes
2020-12-10 17:10:29 +09:00
54abc3bd4d
revert aim curve and add new 50s nerf
2020-12-09 20:07:52 -06:00
149651dec1
Merge branch 'lowacc-nerf' of https://github.com/Xexxar/osu into lowacc-nerf
2020-12-09 13:05:11 -06:00
d604c51cbd
capped scaling at OD 8 to prevent overscaling
2020-12-09 13:04:14 -06:00
a2bd8ece10
Merge branch 'master' into lowacc-nerf
2020-12-09 12:06:33 -06:00
05ad9aae8d
changed curve to linear OD + acc based curve
2020-12-09 11:57:01 -06:00
cfc34a63bd
realized i accidently deleted the OD scaling
2020-12-09 11:21:03 -06:00
7e3fcfe437
fixed issue with comment
2020-12-09 10:35:48 -06:00
748035e80a
changes to acc scaling curve for speed and aim pp
2020-12-08 16:53:52 -06:00
168ba62500
Port StanR's dynamic SO pp changes
2020-12-08 22:09:48 +09:00
57b7ef88e2
Fix spacing
2020-12-08 12:12:53 +09:00
cf3fbe0b0b
osuDifficulty ar11 nerf
2020-12-06 18:06:36 -06:00
27cc6c5046
Rename HitCirclesCount -> HitCircleCount.
2020-10-03 16:52:33 +02:00
abd395a030
Remove unecessary using references.
2020-10-02 19:41:24 +02:00
cb2f695fdd
Calculate hit circle count in OsuPerformanceCalculator.
2020-10-02 19:34:41 +02:00
0163688a17
Remove IBeatmap from PerformanceCalculator.
2020-10-02 19:24:30 +02:00
f439c1afbc
Make osu/taiko/catch use Ok+Great
2020-09-29 17:16:55 +09:00
1c1afa1c96
Move MaxCombo to base DifficultyAttributes
2020-08-28 19:16:20 +09:00
c20902f249
Fix double in accuracy calculation in OsuPerformanceCalculator.
2020-05-18 18:22:03 +08:00
373aae0610
Use int for total hits in OsuPerformanceCalculator.
2020-05-18 17:45:32 +08:00
1865cd0762
Fix possible exceptions in performance calculators
2020-05-18 15:10:59 +09:00
9ddfdab27a
Remove meaningless Convert calls.
2019-12-03 20:47:00 +08:00
c6a85a11bd
Merge branch 'master' into sharpen
2019-11-27 17:09:11 +09:00
9425e80a5d
Unify to use double in performance calculators.
2019-11-26 18:34:23 +08:00
7d7b9e36b2
Use compound assignment.
2019-11-12 19:53:50 +08:00
f925e781a9
Refactor HitWindows for legibility
2019-09-06 15:24:14 +09:00
4c150839c0
Fix potential diffcalc hitwindow nullref
2019-09-02 17:38:58 +09:00
7e9f5a0939
Add Skills to DifficultyAttributes
2019-05-29 11:22:51 +02:00
612db31c38
Apply newline additions
2019-04-01 12:16:32 +09:00
2dbf7d122c
Merge branch 'master' into use-pattern-matching
2019-02-28 14:53:07 +09:00
e2c6a8bc07
Use pattern matching wherever possible
2019-02-28 14:35:00 +09:00
26d53d06a9
Fix remaining issues
2019-02-28 13:31:40 +09:00
0380293098
Add beatmap argument
2019-02-19 17:58:02 +09:00
