be995f1359
Add localisation support for new button string
2023-05-04 11:11:19 +09:00
b7abab6d8a
More variable improvements
2023-05-04 11:10:05 +09:00
0a584f0652
Simplify check logic and improve variable naming
2023-05-04 11:07:09 +09:00
967e801f9c
code inspect
2023-05-03 23:26:58 +09:00
debbd376bd
move scrollContent update logic to updateActiveState()
2023-05-03 23:24:14 +09:00
f4b1264cc9
use button Enable status to ensure preset name is not null
2023-05-03 23:22:46 +09:00
aa5a026c67
remove local button handle
2023-05-03 23:14:24 +09:00
c609e6345c
remove Use Current Mods menu item
2023-05-03 23:02:50 +09:00
3a15783a3c
remove wait, use AddUntilStep
2023-05-03 22:59:01 +09:00
e394b487e0
Merge branch 'master' into edit-mods-preset
2023-05-03 12:06:16 +09:00
e42b0cc5b1
Merge pull request #23370 from peppy/fix-editor-playfield-padding
...
Add more padding around playfield in editor to avoid overlap with tool areas
2023-05-03 11:44:55 +09:00
03459a4f19
Merge pull request #23371 from peppy/argon-slider-ball-fade-faster
...
Increase the rate of slider ball fade on argon skins to match other implementations
2023-05-02 19:03:47 +02:00
95badb9455
Adjust composer tests to new screen layout
...
`TestSceneHitObjectComposer.TestPlacementFailsWhenClickingButton()` was
attempting to cover the case of the user clicking a toolbox button which
was in front of the playfield, and ensure that the click did not result
in a placement. However, since the paddings in
67f83f246b
2023-05-02 18:45:45 +02:00
ec8362c6fc
Merge pull request #23367 from peppy/fix-uo-tooltip
...
Fix slider bar tooltips potentially showing negative zero
2023-05-02 18:03:09 +02:00
48dd42407b
Merge pull request #23369 from peppy/beatmap-attribute-text-unicode-preference
...
Fix `BeatmapAttributeText` not supporting unicode artist/title
2023-05-02 17:32:55 +02:00
94ae9d7664
Merge pull request #23357 from OliBomby/fix-reverse-crash
...
Prevent infinite repeat count when adjusting repeats of 0 length slider
2023-05-02 19:53:26 +09:00
1b565ab9e8
Merge pull request #21789 from mk56-spn/bubble_mod_implementation_clean
...
Add "bubble" mod to osu! ruleset
2023-05-02 19:52:32 +09:00
2aaa52e904
Merge pull request #23374 from EVAST9919/ruleset-shaders-test
...
Add missing ruleset shader tests
2023-05-02 19:52:09 +09:00
ba5088f71a
Add missing ruleset shader tests
2023-05-02 11:55:05 +03:00
8160d56264
Update test shaders
2023-05-02 11:51:05 +03:00
e44672bdd5
Avoid using Schedule in transforms (doesn't handle rewind well)
2023-05-02 17:08:49 +09:00
7830711c8e
Tidy up various code quality issues in OsuModBubbles
2023-05-02 17:08:37 +09:00
fb0e90913d
Ensure lifetime start is also updated when reverting judgements
2023-05-02 17:07:12 +09:00
414b80d44e
Change flashlight depth in a more standard way
2023-05-02 17:00:54 +09:00
b2b9f2a036
Merge branch 'master' into bubble_mod_implementation_clean
2023-05-02 16:59:55 +09:00
bd72c67d68
Increase the rate of slider ball fade on argon skins to match other implementations
2023-05-02 15:47:35 +09:00
67f83f246b
Add more padding around playfield in editor to avoid overlap with tool areas
...
Closes #23130 .
2023-05-02 15:37:02 +09:00
4a97c2c105
Merge pull request #23038 from cdwcgt/scale-background-dim
...
Add feature to adjust `ScalingContainer` background dim
2023-05-02 15:36:52 +09:00
ce4a6c38a0
Merge pull request #22950 from Joehuu/fix-initial-playlist-highlight
...
Fix now playing playlist not highlighting selected item on initial open
2023-05-02 15:36:34 +09:00
1e4a628cb1
Merge pull request #23284 from Hy0tic/multiplier-doesnt-update-with-preset-mod
...
Fix issue where multiplier show wrong value when adjusting speed on preset
2023-05-02 14:59:41 +09:00
57f48e0703
Start colour black to ensure initial appear transition doesn't look silly
2023-05-02 14:33:57 +09:00
ab4f66fad3
Minor readability refactors
2023-05-02 14:31:39 +09:00
7a840e1d82
Remove unnecessary TransferValue spec
2023-05-02 14:29:26 +09:00
7efaa299bd
Merge branch 'master' into scale-background-dim
2023-05-02 14:24:54 +09:00
736be6a73b
Refactor slightly for readability
2023-05-02 14:11:16 +09:00
ad40099e32
Ensure negative sign is only applied when the post-rounded result is negative
2023-05-02 14:00:52 +09:00
37a5dde859
Fix BeatmapAttributeText not supporting unicode artist/title
2023-05-02 13:47:49 +09:00
e808e7316b
Mark delegate value unused and add comment to avoid future regression
2023-05-02 13:29:30 +09:00
63890ef6fe
Fix audio offset tooltip potentially showing "-0 ms"
...
Closes https://github.com/ppy/osu/issues/23339 .
2023-05-02 13:24:22 +09:00
983a8f7dfe
Merge branch 'master' into fix-reverse-crash
2023-05-02 13:14:34 +09:00
87db891143
Adjust test to reliabily fail
2023-05-02 13:12:11 +09:00
5da78098ad
Merge pull request #23362 from bdach/fix-saving-online-beatmap-not-resetting-id
...
Reset online ID on locally modifying beatmap
2023-05-02 12:41:23 +09:00
0b048979f4
Merge pull request #23361 from OliBomby/distance-snap
...
Enable 'Use current' distance snap when exactly on a hit object
2023-05-02 12:21:57 +09:00
436ebdcfcb
Fix beatmap leaderboard test failure
...
Because the online info reset (which includes online ID reset) was
happening after encoding,
`TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()`
started failing, as the hash no longer matched expectations after the
first save of the map.
2023-05-01 19:44:15 +02:00
cf5211aec9
Enable current distance snap when exactly on a hit object
2023-05-01 19:22:52 +02:00
1fb4c814f4
Remove no longer needed API call mocking
...
The online ID will be reset unconditionally after any local change is
made to any beatmap. That behaviour no longer depends on online lookups
succeeding or failing.
This may change at a later date when beatmap submission is integrated
into lazer - the idea is that online IDs would get re-populated on local
beatmaps once they are submitted to web.
2023-05-01 19:08:41 +02:00
f470b2c9cc
Always reset online info when saving local beatmap
2023-05-01 18:17:45 +02:00
8ab3a87b13
Add failing test case covering online ID reset on save
...
This test scene passes at e58e1151f3e72f103c17
2023-05-01 18:17:35 +02:00
dbb2a8980b
add test
2023-05-01 15:56:23 +02:00
1dc34ee25d
fix infinite repeat count when adjusting length of 0 length slider
2023-05-01 15:48:54 +02:00
