Commit Graph

54427 Commits

Author SHA1 Message Date
c03e47317a Fix notes not being added to list 2022-08-15 21:56:03 +09:00
4d4ee05981 Whoops I meant to remove these 2022-08-15 21:56:03 +09:00
78283ce3c5 Remove TaikoDifficultyPreprocessor 2022-08-15 21:43:09 +09:00
21d2998032 Privatise internals of TaikoColourDifficultyPreprocessor 2022-08-15 21:35:57 +09:00
94c6beeaf7 Use ctor in a place that looks visually weird
I read through this thinking "why doesn't Previous get assigned to
currentEncoding here? But it's because the initializer runs right after
the ctor and before the "method" returns. So really there's 3 operations
running on one line here - ctor, init, and assignment.
2022-08-15 21:30:46 +09:00
502e31dd37 General refactoring 2022-08-15 21:26:54 +09:00
d686e841c5 Merge branch 'master' into colour-encoding-2 2022-08-15 20:56:50 +09:00
c334a84139 Merge pull request #19775 from peppy/less-gameplay-clock
Move all usage of `GameplayClock` to `IGameplayClock`
2022-08-15 13:23:04 +02:00
71961b244e Merge branch 'master' into less-gameplay-clock 2022-08-15 11:58:30 +02:00
11854158a8 Merge pull request #19773 from peppy/constraint-asserts-in-tests
Update some clock tests to use constraint-based assertions
2022-08-15 11:57:43 +02:00
cc982d374c Cache self rather than GameplayClock 2022-08-15 18:30:53 +09:00
c5f8529d20 Mark unused methods as NotImplemented for safety 2022-08-15 18:30:53 +09:00
f81c7644b4 Make GameplayClockContainer also an IGameplayClock and expose to remaining tests 2022-08-15 18:30:53 +09:00
c8764cb333 Move all usage of GameplayClock to IGameplayClock 2022-08-15 18:30:53 +09:00
6d78218142 Update usages of GameplayClockContainer.GameplayClock to access properties directly 2022-08-15 18:08:49 +09:00
224f3eaa84 Make GameplayClockContainer non-abstract and use in MultiSpectatorPlayer 2022-08-15 18:08:49 +09:00
95c1b488a7 Add non-null assertion to FrameStabilityContainer 2022-08-15 18:08:49 +09:00
58146598c8 Update TestSceneEditorClock to use constraint-based assertions 2022-08-15 18:08:05 +09:00
0087935708 Update TestSceneSpinnerRotation to use constraint-based assertions 2022-08-15 18:05:39 +09:00
4b5439f434 Merge pull request #19768 from peppy/fix-song-progress-div-by-zero
Fix div-by-zero in `SongProgress` when no object duration could be calculated
2022-08-15 16:44:28 +09:00
623e90a7b2 Fix div-by-zero in SongProgress when no object duration could be calculated 2022-08-15 15:05:35 +09:00
0d3cda3329 Merge pull request #19746 from bastianpedersen/beatmap-comments-image-not-visible
Make `CommentMarkdownTextFlowContainer` render images
2022-08-15 00:02:03 +09:00
383afe04f3 Remove not needed override 2022-08-14 15:15:36 +02:00
932becc4b2 Remove CommentMarkdownTextFlowContainer and rather use base-class OsuMarkdownTextFlowContainer 2022-08-14 10:11:49 +02:00
b05acb0073 Make CommentMarkdownTextFlowContainer render images 2022-08-13 21:32:24 +02:00
c02990ad67 Merge pull request #19718 from peppy/fix-playlist-imported-items
Fix playlist overlay showing new imports when they don't match collection filter
2022-08-12 23:27:26 +09:00
e6ecdf7457 Merge pull request #19715 from peppy/relax-mod-multiplier
Adjust various mod multipliers to avoid competition with normal scores
2022-08-12 23:12:57 +09:00
9d1b0b5836 Revert sealing 2022-08-12 22:32:27 +09:00
e5e9841652 Apply multiple other mod debuffs as decided in pull request discussion 2022-08-12 18:58:09 +09:00
b76e5757e1 Fix InSelectedCollection not being applied to newly imported beatmaps 2022-08-12 15:06:34 +09:00
a90967715c Add test coverage of new imports not correctly being filtered by collection filter 2022-08-12 15:06:34 +09:00
5111bad86c Refactor TestScenePlaylistOverlay to use realm for testing
Removes the dual-purpose flow which existed only for testing.
2022-08-12 15:06:34 +09:00
9dcf45079c Merge pull request #19717 from peppy/visual-tests-development-directory
Update interactive visual test runs to use development directory
2022-08-12 15:00:39 +09:00
38afc53bad Update interactive visual test runs to use development directory 2022-08-12 13:40:29 +09:00
ac4213ecee Adjust relax mod multiplayer to 0.5x
Has previously been discussed internally. Probably good to get this out
before the next full reprocess of scores server-side.

The multiplier here was @smoogipoo's suggested value. I'd be willing to
go lower if this is seen at too high, but it should be a round number to
make it easy for users to understand the max score available to them.
2022-08-12 12:30:13 +09:00
9148305fd8 Merge pull request #19657 from novialriptide/open-profile-hotkey
Add keybind for showing profile
2022-08-12 02:47:13 +09:00
667b700a28 Merge branch 'master' into open-profile-hotkey 2022-08-11 13:04:19 -04:00
b4af32efb7 Merge pull request #19708 from smoogipoo/fix-inspection
Fix possible null reference inspection
2022-08-11 21:52:09 +09:00
d88f247594 Fix possible null reference inspection 2022-08-11 20:38:08 +09:00
f29d1b2ded Merge pull request #19001 from stanriders/pp-balancing
osu! performance points balancing pass
2022-08-11 20:31:33 +09:00
9f28c4c033 Adjust test values 2022-08-11 19:47:32 +09:00
61a3758cd9 Merge branch 'master' into pp-balancing 2022-08-11 19:46:16 +09:00
9839d9933d Merge pull request #19707 from peppy/api-run-loop-refactor
Refactor `APIAccess` main loop to read better
2022-08-11 19:44:01 +09:00
d6c64af5e3 Merge branch 'master' into api-run-loop-refactor 2022-08-11 19:09:32 +09:00
77cd279a76 Merge pull request #19706 from peppy/api-connected-state-refactor
Fix avatar potentially not loading in `LoginOverlay` due to misordered events
2022-08-11 19:08:25 +09:00
865d63f768 Refactor APIAccess main loop to read better 2022-08-11 15:43:39 +09:00
47196b19a5 Stop setting Online state in handleRequest
This is already handled amicably by the `Failing` -> `Connecting` flow.
Having this set in `handleRequest` throws things off, potentially
leading to the `Online` state change before the user has been populated.
2022-08-11 14:36:30 +09:00
7ec67c28b9 Set Online state sooner in connection process
This isn't really required as such, but feels more correct. There was no
reason for it to wait for the friend population to complete before
deeming things to be "online".
2022-08-11 14:35:56 +09:00
65a1daf211 Merge pull request #15666 from MBmasher/fl-slider
Add slider bonus to Flashlight skill
2022-08-11 13:42:31 +09:00
b18f9b39dc Merge pull request #19702 from peppy/api-access-user-thread-safety
Add thread safety to `APIAccess.LocalUser`
2022-08-11 13:25:27 +09:00