Commit Graph

55014 Commits

Author SHA1 Message Date
c42ae4be04 Merge pull request #20095 from peppy/fix-bracket-riht-click-no-selection
Fix right-clicking a non-selected match in ladder view dismissing context menu
2022-09-07 14:56:23 +09:00
dc71abdf56 Merge pull request #20144 from peppy/fix-notification-overlay-presence
Fix completion toasts sometimes not displaying
2022-09-07 14:55:33 +09:00
83962443e5 Merge pull request #20168 from nekodex/add-textbox-esc-feedback
Add audio feedback for Esc/Back clearing text from a FocusedTextBox
2022-09-07 14:19:15 +09:00
cb1d886c9c Add audio feedback for Esc/Back clearing text from a FocusedTextBox 2022-09-07 13:17:04 +09:00
13efa819ae Merge pull request #19413 from Gramore/feature/EditorDeleteDiff
Add ability to delete difficulties from the editor
2022-09-06 19:20:45 +03:00
90207b6032 Merge branch 'master' into feature/EditorDeleteDiff 2022-09-06 18:48:06 +03:00
c2107bd322 Fix test failures due to notifications being forwarded before player finishes loading 2022-09-06 23:36:27 +09:00
604fc0fb97 Merge pull request #20156 from peppy/sb-earliest-alpha-fix-atttempt-two
Fix some storyboard elements displaying too late due to incorrect start time allowances
2022-09-06 23:14:43 +09:00
db15bd56e8 Invalidate working beatmap cache when calling DeleteDifficultyImmediately rather than in editor code 2022-09-06 18:12:47 +09:00
579e7e1f17 Fix deleting a difficulty not updating the beatmap set hash 2022-09-06 18:12:47 +09:00
a3de5f808e Fix typo in LoopStartTime addition 2022-09-06 17:46:03 +09:00
9f2ea54e40 Tidy up TestSceneLeadIn constant for loop offset to read better 2022-09-06 17:45:53 +09:00
6e52dbb266 Update IsDisplayingToasts to check the flow count directly 2022-09-06 17:30:24 +09:00
677708c5e4 Rewrite logic using a list 2022-09-06 16:58:51 +09:00
d667f46830 Refactor alpha check to not overwrite sourced overrides with values from later commands 2022-09-06 16:41:32 +09:00
fa0a4614f8 Add failing test for second incorrect case of start time handling 2022-09-06 16:40:59 +09:00
bea42d2862 Handle earliest-alpha-start-time logic in StoryboardSprite itself 2022-09-06 16:16:58 +09:00
a5e57b083c Remove EarliestDisplayTime's input to CommandStartTime 2022-09-06 16:16:58 +09:00
abf0242686 Add failing test for incorrect start time of storyboard elements 2022-09-06 16:16:58 +09:00
9e3228aa65 Fix completion notification not being posted if completion occurs during NotificationOverlay load 2022-09-06 04:07:49 +09:00
6296c971f8 Merge pull request #20136 from smoogipoo/fix-cancellation-perf
Improve performance when cancelling import with debugger attached
2022-09-05 22:03:50 +09:00
510972e3ad Avoid reference counting by using height calculation for IsPresent instead
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.

Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
0514c96191 Fix incorrect count tracking when notification is manually disposed 2022-09-05 19:26:40 +09:00
229e1a8ef7 Fix notification overlay being present when it doesn't need to 2022-09-05 19:13:58 +09:00
f754686521 Remove necessity of AlwaysPresent for ProgressUpdate completion posting 2022-09-05 19:13:58 +09:00
0d4ee6bd80 Centralise ability to fetch all toast tray notifications (including animating ones) 2022-09-05 18:42:20 +09:00
eca7b8f988 Fix completion notifications not always showing as toasts 2022-09-05 18:39:11 +09:00
56886fed09 Add test coverage of progress notification completions showing 2022-09-05 18:39:11 +09:00
4fa6707bf0 Set all progress notifications to non-important 2022-09-05 18:29:35 +09:00
87e26e34b8 Merge pull request #20141 from peppy/fix-editor-timeline-sv-display
Fix incorrect slider length in timeline when non-default velocity is inherited from previous object
2022-09-05 17:51:25 +09:00
764bb7a8e1 Merge pull request #20142 from peppy/fix-textbox-potential-crash
Fix textbox sample playback potentially crashing if called before load
2022-09-05 17:05:28 +09:00
f1d9b225a7 Remove probably pointless comment 2022-09-05 16:40:10 +09:00
2bec8b82b3 Fix textbox sample playback potentially crashing if called before load 2022-09-05 16:26:41 +09:00
8af8adf22d Fix incorrect slider length in timeline when non-default velocity is inherited from previous object 2022-09-05 16:17:26 +09:00
57954bb8f5 Enable nullability on TimelineHitObjectBlueprint 2022-09-05 14:50:43 +09:00
8cbd344330 Improve performance when cancelling import with debugger attached 2022-09-05 11:28:13 +09:00
07d4a025b0 Merge pull request #20109 from frenzibyte/online-play-room-status-inconsistency
Fix room status dropdown placement inconsistent between multiplayer and playlists
2022-09-05 11:19:56 +09:00
cbc3627189 Merge pull request #19971 from peppy/remove-dispose-updates
Update `Remove`/`RemoveRange`/`RemoveAll` calls in line with framework changes
2022-09-03 17:38:17 +03:00
ff4a051c05 Merge branch 'master' into remove-dispose-updates 2022-09-03 16:14:50 +03:00
e8fa872f61 Fix room status dropdown position inconsistent on online-play screens 2022-09-03 16:14:21 +03:00
b43995269a Dispose ScrollingTeams on removal 2022-09-03 15:17:51 +03:00
778d767a12 Revert disposal on SectionsContainer properties 2022-09-03 15:02:57 +03:00
8bfaa2a51f Fix tournament match handling right click to select itself, dismissing the context menu 2022-09-02 18:19:42 +09:00
7364173fa9 Merge pull request #20093 from smoogipoo/dont-serialise-has-replay
Don't serialise `has_replay`
2022-09-02 18:00:01 +09:00
dc02b59a05 Add extra coverage to tests
Also fixes a potential failure due to test beatmap having two difficulties with same name.
2022-09-02 17:57:20 +09:00
4f18105e9d Ensure next beatmap selected matches the menu ordering 2022-09-02 17:57:00 +09:00
840d1c4cd5 Disable delete difficulty menu item when only one difficulty is present 2022-09-02 17:14:48 +09:00
a7799e4f1e Merge pull request #20092 from smoogipoo/bump-diffcalc-versions
Bump difficulty calculator versions
2022-09-02 17:11:36 +09:00
9fd8067e11 Tidy up dialog and deletion flow 2022-09-02 17:07:09 +09:00
605108c938 Refactor/rename deletion method to read better 2022-09-02 16:59:01 +09:00