Commit Graph

10889 Commits

Author SHA1 Message Date
aea03ca21d Merge pull request #17359 from frenzibyte/fix-score-panel-max-combo
Improve method of retrieving beatmap maximum combo for results score panels
2022-03-22 06:28:30 +09:00
d811a70f4b Change button types on editor exit dialog to match purpose
Addresses https://github.com/ppy/osu/discussions/17363.
2022-03-21 16:06:59 +09:00
5c1e11c153 Merge branch 'master' into queue-list-counter 2022-03-21 05:01:09 +03:00
2a78042038 GetBeatmapMaximumComboAsync -> GetMaximumAchievableComboAsync 2022-03-20 16:18:53 +03:00
e1d22e58bf Simplify queue count text logic 2022-03-20 06:25:14 +03:00
7529d6fc00 Bind queue items during playlist initialization
Along with where the other bindables are bound together (only bind, not
listening).
2022-03-20 06:23:44 +03:00
eca7975864 Compute the beatmap maximum achievable combo instead of Beatmap.MaxCombo 2022-03-20 05:38:14 +03:00
ef823d58a7 address frenzibyte review (refactor bindable flow, clean up CI stuff) 2022-03-19 13:05:35 -04:00
9afe82a0d5 Fix potentially null drawable call to SetLayoutPosition 2022-03-19 14:54:58 +03:00
b7d5a628bc Merge branch 'master' into fix-spectator-seeks-hot 2022-03-19 11:39:01 +01:00
a903aee17e Use schedule to workaround seek issue instead 2022-03-19 18:00:14 +09:00
cf2212e794 Revert "Fix spectator not starting from correct seek point (hotfix)"
This reverts commit 2b59eff465.
2022-03-19 17:20:54 +09:00
2b59eff465 Fix spectator not starting from correct seek point (hotfix) 2022-03-19 15:14:25 +09:00
dae5569e36 Use nullable in PlayerLoader 2022-03-19 15:06:22 +09:00
da76358ee0 Expose the loading player in PlayerLoader 2022-03-19 15:06:22 +09:00
b99541fb5e Revert "Swap placements of "hold for menu" and key counter"
This reverts commit 5bcb7c167c.
2022-03-19 08:08:07 +03:00
5d16519a82 make code prettier 2022-03-18 23:41:55 -04:00
ad9b119e3d Reduce "hold for menu" radius of visibility 2022-03-19 05:04:54 +03:00
486be83177 Calculate position adjustment distance in local parent space 2022-03-19 05:04:13 +03:00
5bcb7c167c Swap placements of "hold for menu" and key counter 2022-03-19 05:02:22 +03:00
0adad3a599 Handle potential null room hosts 2022-03-19 04:01:35 +03:00
5a5629eb5a (works now) use BindValueChanged to set the Queue text 2022-03-18 20:47:45 -04:00
5e5fbc496e (still not working) try bindables instead of int 2022-03-18 20:32:37 -04:00
d9b2a29c6d (not working yet) add MultiplayerPlaylistTabControl, "Queue ({count})" 2022-03-18 20:02:26 -04:00
faa36c78e5 put count and tabs into new fillflowcontainer 2022-03-18 12:55:00 -04:00
fc75aa0807 Merge pull request #17324 from frenzibyte/score-panel-max-combo
Display beatmap maximum combo next to score combo in results panel
2022-03-18 22:59:38 +09:00
fa8eb1feec Update score panel to check for all combo-breaking statistics 2022-03-18 15:23:14 +03:00
04f4e81852 Rename start countdown request 2022-03-18 21:05:19 +09:00
ed90dc6d6b Fix centering of labels using Height instead of location to better handle rotations 2022-03-18 20:17:04 +09:00
bd488d139d Better centre text labels for hit error meter 2022-03-18 20:11:05 +09:00
af22e67e15 Fix perfect combo check not accounting for LargeTickMiss
`LargeTickMiss` can affect combo, see
a352a140bc/osu.Game/Rulesets/Scoring/HitResult.cs (L124-L144).
2022-03-18 13:11:41 +03:00
9215384229 Display beatmap maximum combo in score panel 2022-03-18 13:11:41 +03:00
7c9fe4036c Add setting to change the style of the early/late markers 2022-03-18 17:50:37 +09:00
919583137e Add line style for centre marker 2022-03-18 17:50:37 +09:00
cdeab1b14e Add setting to change the style of the centre marker 2022-03-18 17:50:37 +09:00
331cb2aa80 Add setting to show or hide the moving average arrow 2022-03-18 17:50:37 +09:00
3f92bef9df Add setting for judgement line thickness 2022-03-18 17:50:37 +09:00
c2e7ff7e3e display count of listQueue 2022-03-18 01:37:53 -04:00
72843a6797 Add support for starting/stopping countdowns 2022-03-18 14:33:09 +09:00
efce471f0b Add countdown button + popover 2022-03-18 14:31:57 +09:00
b76a87e6f8 Split ready button visual logic into button itself 2022-03-18 14:31:57 +09:00
1bd08b4a4b Remove kick button fading as well to not look jarring 2022-03-18 08:09:15 +03:00
98b420ee6f Remove no longer correct crown fade animation
Since the host is pinned to the top without any animation, it would look
jarring for the crown to fade away from the old panel (and at a 50ms
duration).
2022-03-18 07:25:12 +03:00
1c899d00b9 Pin multiplayer host panel to the top of the list 2022-03-18 07:25:03 +03:00
af6d53ad64 Merge pull request #17279 from peppy/skin-editor-borrowed-dependencies
Only show components in skin editor which are usable on the current screen
2022-03-18 11:29:12 +09:00
4650c197a3 Make SongProgress.DrawableRuleset nullable to allow test scene to work 2022-03-17 18:45:37 +09:00
da0ffab14e Integrate ready button implementation 2022-03-17 18:43:04 +09:00
461d41529b Integrate spectate button implementation 2022-03-17 18:36:33 +09:00
fd71aa4a4d Change SongProgress resolution requirements to be required 2022-03-17 15:05:54 +09:00
ac739c9dae Change PerformancePointsCounter resolution requirements to be required
All other similar UI components have required dependencies, so this is
mainly to bring things in line with expectations. I am using this fact
in the skin editor to only show components which can be used in the
current editor context (by `try-catch`ing their
`Activator.CreateInstance`).
2022-03-17 14:56:35 +09:00