Commit Graph

51894 Commits

Author SHA1 Message Date
d3e6eac02e Merge pull request #16762 from peppy/fix-carousel-ruleset-filter-test-local-database
Fix `TestSelectingFilteredRuleset` failing under visual tests due to using local database
2022-02-03 16:59:45 +09:00
41aa4b8cca Fix TestSelectingFilteredRuleset failing under visual tests due to using local database 2022-02-03 16:04:05 +09:00
cd806711f8 Merge pull request #16761 from peppy/more-dialog-overlay-wait
Wait for `DialogOverlay` load in more tests
2022-02-03 16:01:32 +09:00
6355ac6663 Wait for DialogOverlay load in more tests
Apparently the previous fix was not enough as this can still be seen
failing
(https://github.com/ppy/osu/runs/5046718623?check_suite_focus=true).

This change is copying from what other tests use seemingly reliably,
such as `TestScenePerformFromScreen`)
2022-02-03 15:10:08 +09:00
c8ce00b26a Trigger a re-layout of HUD components when scoring mode is changed
This is a simple way of fixing the layout of scoring elements
overlapping due to different score display width requirements of
different scoring modes. It will only resolve the case where a user
hasn't customsied the layout of the default skins, but as this is a very
simple / low effort implementation for the most common scenario, I think
it makes sense.

Closes https://github.com/ppy/osu/issues/16067.
2022-02-03 14:50:41 +09:00
867586f7f5 Merge pull request #16758 from smoogipoo/fix-incomplete-requests-offline
Fix API requests not completing when offline
2022-02-03 14:34:24 +09:00
a69c7a9de6 Split exceptions back out to give better messaging 2022-02-03 14:09:27 +09:00
62fa915193 Standardise exception messages for local-user-logged-out flows 2022-02-03 13:58:55 +09:00
d9a43b4c4c Fix API requests not completing when offline 2022-02-03 13:16:54 +09:00
aff36d4e16 Refactor populateStatistics to avoid disposing 2022-02-03 11:52:37 +08:00
62537eb4aa Fix spectator not completing 2022-02-03 12:44:33 +09:00
b94fe84712 Merge branch 'master' into new-difficulty-creation-v3 2022-02-03 10:48:20 +09:00
2731d8e3c2 Merge pull request #16701 from LeNitrous/mod-alternate-osu
Add "Alternate" mod for osu! ruleset
2022-02-03 10:41:23 +09:00
be9df2ca11 Merge pull request #5774 from MaxOhn/aimassist-mod
Add "Aim Assist" mod
2022-02-03 10:40:43 +09:00
9bca597a8a Merge pull request #16751 from bdach/flashlight-decimals-display 2022-02-03 10:34:09 +09:00
a8ffc4fc2a Add editor override to respect IsolateSavingFromDatabase 2022-02-02 21:57:21 +01:00
47429fb0c6 Fix same-name safety firing wrongly 2022-02-02 21:57:21 +01:00
afc48d86df Add failing test coverage for save after safeties addition 2022-02-02 21:57:10 +01:00
4f1aac9345 Add safeties preventing creating multiple difficulties with same name 2022-02-02 21:57:09 +01:00
87e2e83288 Add test coverage for difficulty name clash cases 2022-02-02 21:55:34 +01:00
54bb6ad40c Fix working beatmaps not seeing new difficulties after add 2022-02-02 21:55:34 +01:00
0d51c015ad Add basic test coverage for new difficulty creation 2022-02-02 21:55:34 +01:00
dc96c4888b Add support for creating new blank difficulties 2022-02-02 21:55:33 +01:00
b613aedeb8 Fix menu item width changing when hovered 2022-02-02 21:23:35 +01:00
3386f038ba Add new difficulty creation menu 2022-02-02 21:23:35 +01:00
e2fcdc394b Extract method for difficulty switch menu creation 2022-02-02 21:23:35 +01:00
82f9ad63f5 Fix flashlight size multiplier printing with too many decimal digits 2022-02-02 20:41:25 +01:00
4aa4df69f2 Reorder iOS landscape orientations to prioritise "Landscape Right"
"Landscape Right" is often the proper default for landscape-only applications.

Matches up with all other landscape-only iOS games I have locally.
2022-02-02 22:22:11 +03:00
fb353d5d45 Merge branch 'master' into aimassist-mod 2022-02-02 19:37:34 +01:00
dca1bddabb Lock supported interface orientation to landscape for iPhone 2022-02-02 21:25:50 +03:00
7463744407 Fix osu! autoplay-like mods not declaring incompatibility with AimAssist 2022-02-02 19:17:33 +01:00
3a5099cf06 Merge pull request #16748 from frenzibyte/explicit-diffadjust-keyboard-step
Use `0.1` keyboard step for "Difficulty Adjust" sliders
2022-02-03 00:22:23 +09:00
074a691635 Set keyboard step to 0.1 for difficulty adjust sliders 2022-02-02 17:43:08 +03:00
81a22dbd29 Add back playing users list 2022-02-02 23:19:43 +09:00
fcbba3d948 Rename PlayingUserStates -> WatchingUserStates 2022-02-02 23:11:29 +09:00
589f5e7a31 Update test which has now been resolved 2022-02-02 23:09:38 +09:00
9d1d13c715 Fix up TestSpectatorClient implementation
Rather than using a list which is supposed to be updated "client"-side,
now uses the "server"-side list.
2022-02-02 23:05:09 +09:00
19eb9ad8a7 Reorder StatisticsItem constructor to make a touch more sense 2022-02-02 23:02:38 +09:00
3c2a6fe208 Don't prompt for a replay if no item requires hit events 2022-02-02 19:07:14 +08:00
1e19c7046a Use spacing instead of bottom margin 2022-02-02 19:02:29 +08:00
b0023b9809 Also dispose rows 2022-02-02 19:00:46 +08:00
f777347aaf Merge pull request #16742 from smoogipoo/fix-multi-swap-mod-crash
Fix crash when selecting non-osu! ruleset mods as freemod
2022-02-02 19:14:10 +09:00
6d3bc005ea Merge branch 'master' into spectator-state-rework 2022-02-02 18:57:04 +09:00
b5fb3b7dae Fix crash when selecting swap mod as freemod 2022-02-02 18:42:22 +09:00
36bfef4f54 Dispose container before replacing 2022-02-02 17:32:16 +08:00
042574660c Rename "Content" to "CreateContent" 2022-02-02 17:29:03 +08:00
90e30bc9e8 Remove useless null checks 2022-02-02 17:26:17 +08:00
6a482827fe Fix weird line breaking 2022-02-02 17:23:03 +08:00
5e3d124eef Add scrolling to the extended statistics panel 2022-02-02 17:20:22 +08:00
db0f3b7f5e Merge pull request #16738 from peppy/fix-ruleset-incorrectly-loading
Fix rulesets potentially being marked `Available` even when methods are missing
2022-02-02 18:03:04 +09:00