Commit Graph

51894 Commits

Author SHA1 Message Date
4f3e55a0ce Merge branch 'master' into songselect-random-sfx 2022-02-02 17:18:24 +09:00
6260c5fc13 Merge pull request #16739 from nekodex/cursor-tap
Add cursor 'tap' audio feedback
2022-02-02 17:02:33 +09:00
cb31ce812c Merge branch 'master' into cursor-tap 2022-02-02 16:34:34 +09:00
4758de226b Update resources 2022-02-02 16:27:59 +09:00
6e41a6e704 Tidy up code into a presentable state 2022-02-02 16:27:16 +09:00
2e46404fe5 Remove spinner support for now 2022-02-02 16:26:00 +09:00
987aa5a21c Add testing of different strengths 2022-02-02 16:26:00 +09:00
f07502ac5f Use simple damp easing rather than transforms 2022-02-02 16:15:06 +09:00
334ed2c9c4 Fix sliders moving before they are actually hit 2022-02-02 15:36:09 +09:00
6b31e7e9db Merge branch 'master' into aimassist-mod 2022-02-02 15:18:48 +09:00
104256a054 Add test coverage 2022-02-02 15:18:44 +09:00
e7d72f1823 Revert recent changes 2022-02-02 15:18:44 +09:00
0c5da9370a Fix rulesets potentially being marked Available even when methods are missing
Came up when running the game after the recent breaking changes
(https://github.com/ppy/osu/pull/16722), where two template rulesets I
had loaded were erroring on startup but still being marked as available,
allowing them to crash the game on attempting to initiate relpay logic.

These cases are already handled for first-time ruleset loading via the
`GetTypes()` enumeration in `RulesetStore.addRuleset`, but when
consistency checking already present rulesets the only runtime
validation being done was `ruleset.CreateInstance()`, which does not
handle missing types or methods.
2022-02-02 14:52:01 +09:00
6e60e68b80 Change from click to mousedown+mouseup and only play when cursor is visible 2022-02-02 14:44:06 +09:00
3ba5d88914 Update statistics item display logic 2022-02-02 13:41:51 +08:00
a2affefb0a Avoid checking gameplay clock time in Update method 2022-02-02 14:33:17 +09:00
c5c4c85006 Lazily create content of StatisticItem 2022-02-02 13:29:18 +08:00
c7a192cc5f Only handle LeftButton and RightButton actions
There are definitely going to be other actions used in the future, which
would immediately cause this mod to fail. Limiting handling to
left/right buttons only is the correct way forward.
2022-02-02 14:04:12 +09:00
fed63abd83 Sanitise interceptor logic to now require two separate check paths 2022-02-02 14:02:48 +09:00
0036d0e26d Move alternate mod to "conversion" category 2022-02-02 13:58:13 +09:00
6d962e7925 Merge pull request #16726 from dekrain/leaderboard-score-tooltip
Add basic tooltip for leaderboard scores
2022-02-02 13:56:45 +09:00
4b646709c1 Merge pull request #16658 from Spooghetti420/no-long-notes-mod
Add "Hold Off" mod (no long notes)
2022-02-02 13:35:44 +09:00
ddc8094a75 Update description 2022-02-02 13:34:23 +09:00
d065e32ca1 Fix crash due to MatchLeaderboardScores not having populated rulesets 2022-02-02 13:23:49 +09:00
b4fd1ecba2 Hide attribute if the maximum is 0 2022-02-02 11:02:01 +08:00
35b7653290 Revert mod flow changes and add visual test coverage showing an overflow case 2022-02-02 09:13:19 +09:00
6033c89e7b Merge pull request #16734 from bdach/war-on-unused-params
Fix several cases of unused constructor and method parameters
2022-02-02 07:40:58 +09:00
3674ed15ce Remove unused game host parameter
No longer used since eeccf836ec.
2022-02-01 21:53:21 +01:00
b978010b48 Remove unused allowMissing parameter in audio file check test
No longer used since 7f95400f46.
2022-02-01 21:53:21 +01:00
7cdf63c654 Remove unused FindProvider() methods
No longer needed since 39f99bf785.
2022-02-01 21:53:21 +01:00
e4028b8fc1 Remove index ctor param from ColumnHitObjectArea
No longer used since 5692cecaa4.
2022-02-01 21:49:52 +01:00
e042f29ee3 Remove skin ctor param from LegacyCatchComboCounter
No longer used since 004798d61d.
2022-02-01 21:49:52 +01:00
75101b1105 Remove unused ruleset ctor params from test beatmap model managers
No longer used since 00e3af3366.
2022-02-01 21:49:41 +01:00
994fb966b6 Remove Host ctor param from SkinModelManager
No longer used since 29d074bdb8.
2022-02-01 21:37:19 +01:00
07d09b3520 Remove unused parameter from createGameplayComponents()
No longer used since 136843c8e4.
2022-02-01 21:35:41 +01:00
a94702b3ae Remove unused parameters in LegacyComboCounter
No longer used since 9bb8a43bce.
2022-02-01 21:35:41 +01:00
1fa2bf5d69 Remove unused parameter from createColourBars()
No longer used since b61aa660c6.
2022-02-01 21:35:40 +01:00
c6a65ccfed Remove unused parameter from createContent()
No longer used since 513e470b52.
2022-02-01 21:35:40 +01:00
16e0cc6a2b Remove IIpcHost param from ScoreManager
No longer used since 3e3b9bc963.
2022-02-01 21:35:40 +01:00
a378e78ced Fix RealmLive unnecessarily passing ID around
Appears to have never been needed. When the `retrieveFromID` method was
created in 81b5717ae7, it didn't use the
`id` parameter for anything either.
2022-02-01 21:35:12 +01:00
3d7af805a3 Fix BeatmapMetadata not using its user param correctly 2022-02-01 21:16:28 +01:00
eee020f8e4 Cleanup tooltip layout
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-01 20:26:52 +01:00
b06128ffa5 Rename "Final PP" to "Achieved PP" 2022-02-01 22:26:55 +08:00
39524f3dd2 Split total pp into 2 lines 2022-02-01 22:26:30 +08:00
b75c08c9ab Improve beat length logic
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-02-01 13:36:36 +00:00
f4210f7a30 Rework spectator components to use new user state 2022-02-01 21:53:25 +09:00
41007169f7 Give SpectatorState a user state 2022-02-01 21:51:05 +09:00
bfe6218ed5 Change default orientation to SensorLandscape 2022-02-01 12:43:58 +01:00
2c0c44a950 Merge pull request #16722 from smoogipoo/spectator-consistency-frames
Implement spectator consistency frames
2022-02-01 17:28:13 +09:00
15479ae046 Add test coverage of no header doing nothing 2022-02-01 16:55:28 +09:00