Commit Graph

51894 Commits

Author SHA1 Message Date
e5ffa45ab8 Merge pull request #16710 from peppy/add-intro-playback-safety
Add failsafe to `IntroScreen` to stop users with incorrect audio configuration getting stuck
2022-01-31 13:40:40 +09:00
bb8dc74e88 Fix constant formatting 2022-01-31 12:20:51 +09:00
6556a7e3c3 Handle different gameplay rates when seeking on master clock 2022-01-31 01:40:07 +03:00
2b999f9780 Add failing test case 2022-01-31 01:40:07 +03:00
b52153e73d Remove settings 2022-01-30 17:40:15 +00:00
f8939af5e6 Track loading via state as well 2022-01-31 01:12:03 +09:00
1cec76df74 Fix weird reading xmldoc
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-01-30 23:18:40 +09:00
82806d7aeb Ensure the background is eventually displayed when IntroTriangles suspends 2022-01-30 21:32:39 +09:00
6a21d58325 Avoid test failures on non-triangle intro tests 2022-01-30 18:59:18 +09:00
52f1c2bfdb Add failsafe to IntroScreen to stop users with incorrect audio configuration getting stuck
The most common case of this seems to be linux users with incorrect or
unsupported audio driver configurations. It continues to be brought up
in discussions as people are unsure of why their game freezes on
startup, and unable to easily recover.
2022-01-30 18:51:16 +09:00
1dbcb5ab63 Add test coverage of intro fail scenario 2022-01-30 18:51:16 +09:00
04dbb5d3c6 Disallow setting "NoScores" externally as it is handled internally 2022-01-30 16:18:19 +09:00
acc1199add Consolidate flows of Set operations, either result or error 2022-01-30 16:16:00 +09:00
c401629dd8 Also refactor placeholder logic to make more sense 2022-01-30 10:50:32 +09:00
3ec193d47e Fix spectator clock container incorrectly starting catch-up clock 2022-01-30 01:46:10 +03:00
4f4f60248f Add failing test case 2022-01-30 01:46:10 +03:00
b434e29a7c Move loading hide operation inside early return to ensure not hidden too early
It should only be hidden after the async load completes.
2022-01-30 03:10:15 +09:00
dad9cc9315 Ensure Reset/Scores_Set run inline where possible 2022-01-30 03:06:29 +09:00
06660ff960 Fix null beatmap in test scene 2022-01-30 03:02:56 +09:00
9b573fbc2b Add missing entries to switch statement and guard against out of range 2022-01-30 02:58:53 +09:00
d21464ea61 Fix assertions to work in both directions 2022-01-30 02:54:51 +09:00
d3cb910cf8 Convert inline math to not so inline to make operation more explicit 2022-01-30 02:37:01 +09:00
3d771c0fc7 Remove unnecessary loading hide call from PlaceholderState_Set and add more assertiveness 2022-01-30 02:34:31 +09:00
51acf79935 Change test exposure to property instead of method 2022-01-30 02:29:51 +09:00
40f43344f1 remove unused using 2022-01-29 23:31:26 +08:00
535216a0d3 rename CanIntercept to ShouldAlternate 2022-01-29 23:20:31 +08:00
e408d8ef0e rename Frames to ReplayFrames 2022-01-29 23:19:51 +08:00
9861c50b33 Remove pointless tests that no longer show anything valid 2022-01-30 00:03:22 +09:00
a915b9cd30 Fix occasional failures in TestSceneDeleteLocalScore 2022-01-29 23:58:57 +09:00
6f54f8ad78 Add more safety around CancellationToken usage 2022-01-29 23:58:57 +09:00
d0b74a91fb Fix edge cases with score drawable loading 2022-01-29 23:58:57 +09:00
0293d95f82 Simplify IsOnlineScope usage 2022-01-29 23:58:57 +09:00
daea13f491 Simplify flow of cancellation token 2022-01-29 23:58:57 +09:00
3d59bab7c6 Remove fetch callback logic completely 2022-01-29 23:58:57 +09:00
13f445ddd5 Move score update code into own method 2022-01-29 23:58:57 +09:00
c48e9f2bbd Remove more unnecessary schedule/cancel logic 2022-01-29 23:58:57 +09:00
a700ad3849 Remove scoresLoadedOnce weirdness 2022-01-29 23:58:57 +09:00
661fec7c8a Make score setter private 2022-01-29 23:58:57 +09:00
b85b2c01fb Reorder based on accessibility and add regions 2022-01-29 23:58:57 +09:00
c548658662 Remove move unused pieces 2022-01-29 23:58:57 +09:00
17aa9f3040 Remove pointless level of schedule/cancel logic 2022-01-29 23:58:57 +09:00
64925b3fea Remove unused Content override 2022-01-29 23:58:57 +09:00
b9dac6c3b2 Reorder and tidy up bindable flows 2022-01-29 23:58:57 +09:00
aee93934d5 Rename methods to make more sense (and always run through AddOnce) 2022-01-29 23:58:57 +09:00
c6d303a5b4 Add xmldoc to Leaderboard class 2022-01-29 23:58:57 +09:00
a8eb3f95df add readonly modifier 2022-01-29 22:54:17 +08:00
4132f67629 Merge pull request #16702 from peppy/fix-ef-migrations
Run EF migrations before migrating to realm
2022-01-29 15:40:26 +01:00
1087d8b1ce add tests 2022-01-29 22:31:31 +08:00
b4e516c535 allow test scenes to specify replays manually 2022-01-29 22:31:24 +08:00
24f9ef4005 make xmldoc more verbose 2022-01-29 22:31:04 +08:00