Commit Graph

2837 Commits

Author SHA1 Message Date
221cc1747c Drop "default" prefix 2021-10-04 20:34:28 +09:00
5aae673240 Use GameplayState 2021-10-04 20:33:54 +09:00
2e3450b3f5 Make Mods readonly 2021-10-04 20:20:24 +09:00
031c5a441e Merge branch 'master' into realtime-pp-display 2021-10-04 20:19:37 +09:00
853cf6feaa Rename last remaining BeatmapInfo Beatmap usage 2021-10-04 17:35:53 +09:00
7e009f6168 Add full xmldoc 2021-10-02 02:31:41 +09:00
32afd3f426 Replace all basic usages 2021-10-02 02:22:23 +09:00
05ca3aec4f Rename GameplayState to SpectatorGameplayState 2021-10-02 02:10:11 +09:00
0ee148b53f Extra guard against no attributes 2021-10-01 21:31:26 +09:00
a1f880a36a Split classes 2021-10-01 21:00:39 +09:00
d0081908c5 Make Score internal 2021-10-01 20:52:48 +09:00
5820a71652 Fix mania difficulty calculator crashing 2021-10-01 19:57:45 +09:00
4d8418e072 Fix possible nullrefs 2021-09-30 17:54:56 +09:00
d2a8f35b4c Update styling 2021-09-30 17:54:52 +09:00
84bddf0885 Initial PP counter implementation 2021-09-30 17:00:24 +09:00
625711e6d2 Merge pull request #14776 from peppy/fix-pause-with-audio-offset
Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments
2021-09-28 18:44:22 +09:00
ffdaf23329 Merge pull request #14814 from peppy/fix-key-counter-masking
Fix `KeyCounterDisplay` potentially getting stuck invisible due to autosize masking
2021-09-21 16:21:38 +09:00
761548e533 Merge branch 'master' into 14470-ur-not-updating 2021-09-20 22:07:33 +02:00
fb416c79e9 Fully revert Player 2021-09-20 15:01:03 -04:00
a3464c98a7 Fix KeyCounterDisplay potentially getting stuck invisible due to autosize masking
Closes #14793.
2021-09-20 23:52:01 +09:00
9a1db04920 Resolve GameplayClockContainer instead of Player 2021-09-20 10:28:58 -04:00
36a20ab0b3 Resolve failed test compilation 2021-09-20 10:26:07 -04:00
10fe2382b0 Address most issues 2021-09-20 10:07:42 -04:00
04715a5471 Add null-check when invoking OnSeek 2021-09-18 12:20:36 -04:00
f6e279baa1 Add xmldoc to HitErrorMeter.Clear
Explains how the method is called and what inheritors should do when implementing it.
2021-09-18 12:18:11 -04:00
12cc16c598 Remove unused property in SongProgress 2021-09-18 12:05:06 -04:00
b2b3108afa Resolve addressed issues
+ Stopped using testing methods in non-testing classes
+ Resolve Player and add OnSeek event
+ Take bindings away from BarHitErrorMeter
+ Add support for ColourHitErrorMeter
2021-09-17 16:19:41 -04:00
5f27f1c099 Avoid accounting for the pause pitch adjust effect when "fixing" hardware offset adjustments
Bit of an unfortunate one. Because we are applying the pitch adjustment
to the lowest level (`Track`), it's hard to filter out in parent clock
calculations.

Tried a few solutions but this feels the best. Note that we can't just
undo the `pauseFreqAdjust` adjustment as it will div-by-zero.

Closes https://github.com/ppy/osu/issues/14773.
2021-09-17 15:43:38 +09:00
f9d5abff8a Update with keybinding changes 2021-09-16 18:26:12 +09:00
fa693bb8a8 Move MusicController adjustment set to inside OsuScreen itself (and result nullable) 2021-09-16 16:08:09 +09:00
318f0941ca Move all the "inherit previous AllowTrackAdjustments" logic into OsuScreen 2021-09-15 21:25:39 +03:00
f0439ef50b Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect 2021-09-15 13:12:57 +03:00
b9193aae6d Make IOsuScreen.AllowTrackAdjustments nullable
Allows for inheriting value from the previous screen if undefined
2021-09-14 17:37:57 +03:00
3c75094f43 Move BarHitErrorMeter's icon reorintation to Update() 2021-09-13 19:41:55 +03:00
7267602b95 Fix icon orientation for horizontal bar hit error meter 2021-09-13 17:14:39 +03:00
bde092f816 Clear UR bar display on seek with mouse 2021-09-09 20:08:16 -04:00
bf0150bab4 Clear UR bar display on keyboard input 2021-09-09 16:21:51 -04:00
c25ab6835c Remove IJsonSerializable interface
Was pretty pointless and made it hard to use the custom serialisation
terms arbitrarily in tests.
2021-08-31 14:39:20 +09:00
f64efdc4a9 Merge branch 'update-extension-usages' into update-framework 2021-08-30 16:00:09 +09:00
7be825f470 Merge pull request #14488 from frenzibyte/multi-spectator-player-leaving
Gray out and stop player instances who quit during multi-spectator sessions
2021-08-30 12:04:19 +09:00
e374ef163d Update localisable formattable extensions usages inline with framework change 2021-08-29 15:00:28 +03:00
378734a7f8 Separate solo spectator player and "exit on restart" logic to own class 2021-08-27 13:24:37 +03:00
e633b2716d Fix regression in outro skip handling logic 2021-08-26 13:58:45 +09:00
b1a261c902 Avoid using scheduled delegates at all for skip overload input handling 2021-08-26 12:25:37 +09:00
956e3c554b Avoid skip overlay attempting to show when it is already invalid 2021-08-26 12:25:37 +09:00
e503182a8d Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 18:50:55 +02:00
16ddbcd208 Don't bind to RoomId where it's expected to be constant 2021-08-24 14:25:40 +09:00
df170afbc4 Fix multiplayer crashing when entering gameplay 2021-08-24 13:22:06 +09:00
956c1cc216 Merge branch 'master' into activity-on-multiplayer-screens 2021-08-24 12:33:34 +09:00
2877b43824 split multiplayer and playlist activity 2021-08-22 09:54:07 +08:00