c61fac578c
style(KeyCounter): rename methods and arguments
...
As for the second suggestion in
https://github.com/ppy/osu/pull/22654#discussion_r1109047998 ,
I went with the first one as only one Trigger actually uses this
argument for rewinding.
2023-02-16 23:15:03 +00:00
ddd6c1a1c6
refactor(KeyCounter): address bindables issues
...
`IsCounting` is back being an auto-property.
`countPresses` is now encapsulated and being exposed as an
`IBindable<int>` via `CountPresses`
2023-02-16 22:20:34 +00:00
6340730427
refactor(KeyCounter): remove circularity
2023-02-16 21:59:39 +00:00
a644fae364
style(KeyCounter): rename (Un)lit methods to (Un)light
2023-02-15 21:41:41 +00:00
df0633858c
fix(KeyCounter): don't override Handle
...
This caused the Keyboard inputs to register twice, which is not what we
want.
2023-02-15 21:41:41 +00:00
157bba7830
refactor: rename Trigger class to InputTrigger
2023-02-15 21:41:36 +00:00
aa2e0028ab
refactor: hide trigger presence from content
2023-02-13 10:59:10 +00:00
74a58fb674
refactor: separate things in KeyCounter
...
To implement different different sources of input for KeyCounter, it
is now possible to create a Trigger class (to inherit) instead of
inheriting KeyCounter. This eases the creation of more input sources
(like for tests) while allowing to implement different UI variants.
That way, if another variant of the key counter needs to implemented
(for whathever reason), this can be done by only inheriting KeyCounter
and changing how things are arranged visually.
2023-02-13 01:24:27 +00:00
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
0e2ccac33b
Add spaces to comments
2020-05-04 18:36:24 -07:00
831d04f339
Don't use gameplay clock in KeyCounter
2019-09-12 15:48:07 +09:00
0cdf125c1e
Handle key counter rewinding in a better way
...
Use ElapsedFrameTime rather than storing state data
2019-09-12 15:42:14 +09:00
cb0cf6e2c5
Remove reset functions
2019-09-12 14:27:52 +09:00
158737e001
Remove FadeTime customisation
...
Also adjusts fade transitions to feel better, especially in fast forward scenarios.
2019-09-12 14:27:29 +09:00
f9c969788a
Fix keys not reaching full brightness as soon as they should
2019-09-12 13:56:23 +09:00
612db31c38
Apply newline additions
2019-04-01 12:16:32 +09:00
01f1018d02
Tidy up clock logic using DI and a GameplayClock
2019-03-05 13:37:51 +09:00
0788a7e9f1
Merge branch 'master' into more-inspections
2019-02-28 14:32:57 +09:00
42be7857d1
Use expression body for property get/set where possible
2019-02-28 13:58:19 +09:00
26d53d06a9
Fix remaining issues
2019-02-28 13:31:40 +09:00
d61dfe888e
Fix venera fonts not being correctly specified
2019-02-22 19:42:09 +09:00
a2aa3ec5cb
Adjust sprite texts in-line with framework changes
2019-02-20 15:03:20 +09:00
8617aaa2a7
Update licence header (and remove year)
2019-01-24 17:43:03 +09:00
f27bd3ef3e
OpenTK -> osuTK
2018-11-20 17:14:59 +09:00
79b56cb35c
Make saveState private
2018-09-15 16:34:08 +09:00
65b2bceef2
Simplify implementation
2018-09-15 14:51:04 +09:00
dae54d252d
Remove redundant checks in RestoreState
2018-09-07 21:35:32 +03:00
7a1fdd9dc8
Reset KeyCounter if targetState was not found
2018-09-06 01:01:36 +03:00
8a9b3f6459
Remove rewinded keycounter states
2018-08-15 22:18:48 +03:00
3134e14b37
Test KeyCounter.RestoreState
2018-07-28 23:24:03 +03:00
1e6220e3c0
Call KeyCounter.RestoreState itself
2018-07-28 13:22:52 +03:00
332ad5bb67
Move states to KeyCounter
2018-07-22 23:58:21 +03:00
ecd51d70f9
Rename Memento class
2018-07-22 23:13:06 +03:00
0632c59e60
Save KeyCounter state when keypress happens
2018-07-22 17:35:42 +03:00
72959691e9
Introduce KeyCounterMemento
2018-07-22 17:16:17 +03:00
241437c819
Remove unnecessary counting change logic
2018-07-20 17:08:25 +09:00
32a74f95a5
Normalize all the line endings
2018-04-13 18:26:38 +09:00
37d393bca0
Update licence headers
2018-01-05 20:21:19 +09:00
9d523ea012
Update framework
2017-07-12 11:06:13 +09:00
da751804b6
Reduce error count.
2017-03-09 14:24:16 +09:00
a14bdf8624
Use Color4Extensions from Framework and remove redundant Name
2017-03-04 19:42:37 +01:00
9a2beb5979
Update Key Counter font.
2017-02-16 22:43:49 +09:00
50bd80cb0c
Update and standardise license headers.
2017-02-07 14:27:41 +09:00
16a01abc4d
Merge remote-tracking branch 'upstream/master' into options-refactor
...
# Conflicts:
# osu.Game/Beatmaps/Drawables/BeatmapPanel.cs
# osu.Game/Graphics/UserInterface/BackButton.cs
# osu.Game/Screens/Play/KeyCounter.cs
2017-02-03 13:16:07 +09:00
3e7503e860
Make skip button work.
2017-01-27 21:57:22 +09:00
