c6d78b9325
Fix several oversights in data linking causing drawable rooms not updating as expected
2022-02-24 16:12:15 +09:00
53bbd00675
Also make APIUser opt-in and remove the remaining serialization exclusion rule
2022-02-23 17:12:38 +09:00
43c83d2de1
Add note about why RoomID is nulled in DeepClone
2022-02-23 17:10:11 +09:00
f14a9af801
Make Room opt-in rather than opt-out for json serialization
2022-02-23 17:10:10 +09:00
28c9c5ab6a
Remove unnecessary ShouldSerialize rules in Room
2022-02-23 17:10:10 +09:00
71a012bea6
Don't update count twice immediately
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2022-02-23 13:42:47 +09:00
2bea485af8
Fix currently playing text not showing in lounge
2022-02-23 13:37:47 +09:00
61b3280de1
Add missing property copies in Room.CopyFrom implementation
2022-02-22 15:47:00 +09:00
71ae425fb2
Merge branch 'master' into rooms-request-faster
2022-02-22 15:45:05 +09:00
057fd6c352
Add mention of StarRatingRangeDisplay fallback scenario being wrong for multiplayer
2022-02-22 15:37:42 +09:00
f12044b03e
Add mention of PlaylistItem.Beatmap being a placeholder in many cases
2022-02-22 15:31:08 +09:00
cde3d9c08b
Change precedence order to favour playlist as a source for beatmap count
2022-02-22 15:15:57 +09:00
a676acd80d
Merge pull request #16945 from peppy/three-column-playlist
...
Update playlist room display to a three column layout
2022-02-22 12:21:56 +09:00
c2af1526aa
Merge pull request #16943 from peppy/spotlights-on-top
2022-02-22 10:08:59 +09:00
d71e511413
Merge branch 'master' into spotlights-on-top
2022-02-21 23:42:02 +01:00
959f0330e0
Merge branch 'master' into three-column-playlist
2022-02-21 23:40:21 +01:00
a5af89d143
Merge pull request #16894 from dekrain/leaderboard-score-timeref
...
Add text displaying recent score time on the leaderboard
2022-02-21 21:16:31 +01:00
e3ae52360e
Merge branch 'master' into leaderboard-score-timeref
2022-02-21 20:50:00 +01:00
897f0ecd5f
Merge pull request #16938 from smoogipoo/classic-score-hitobject-factor
...
Scale classic score by hitobject count instead of max combo
2022-02-22 00:40:56 +09:00
113153e6a3
Fix remaining filter tests
2022-02-22 00:25:00 +09:00
2aa0364092
Fix null reference in tests during attempted ruleset filtering
2022-02-22 00:14:33 +09:00
98c008b95f
Fix test failures due to order change
2022-02-21 19:48:39 +09:00
655b23f408
Update playlist room display to a three column layout
...
Similar to the changes made to multiplayer.
2022-02-21 19:46:33 +09:00
c7e9cf904b
Fix incorrect null check on now-bindable DifficultyRange
2022-02-21 19:38:26 +09:00
ffa5291b74
Add fallback handling for item count to support different request types
2022-02-21 19:37:36 +09:00
b5348e0407
Update ruleset filtering to use newly provided array return
2022-02-21 19:05:32 +09:00
b43008b9f6
Add cover and count handling from newer response version
2022-02-21 19:05:22 +09:00
39d64e779c
Handle API returned difficulty range for rooms
2022-02-21 19:05:19 +09:00
7f4cc221d2
Add API versioning
2022-02-21 19:02:03 +09:00
0cfb85f3bb
Merge pull request #16939 from peppy/fix-intro-import-failure-ruleset-test-projects
...
Add safeties to skip attempted import of the intro beatmap when osu! ruleset not present
2022-02-21 18:24:56 +09:00
33592b3e9e
Merge pull request #16942 from peppy/copy-spotlight-category
...
Allow room category to be copied even if `Spotlight`
2022-02-21 18:21:21 +09:00
46b408be75
Update tests to match new behaviour
2022-02-21 18:19:55 +09:00
02a8500500
Ensure spotlights always show at the top of the lounge listing
...
As proposed at https://github.com/ppy/osu/discussions/16936 . Spotlights
are intended to have focus, so let's make sure they are the first thing
the user sees for the time being.
2022-02-21 18:01:46 +09:00
ab8b502709
Add test coverage of spotlights being at the top of the listing
2022-02-21 18:01:46 +09:00
1737128334
Allow room category to be copied even if Spotlight
...
I remember that this conditional copy was added to support making copies
of spotlight rooms without carrying across the `Spotlight` type, but in
testing this is already handled web side to the point that it's not
required.
The rationale for allowing the copy is that this method is used for
tests, where it was not being copied correctly from the input as
expected (used at
bdc3b76df0/osu.Game/Tests/Visual/OnlinePlay/TestRoomManager.cs (L38)
2022-02-21 17:47:56 +09:00
c466d6df94
Ensure to not multiply by 0
2022-02-21 17:19:35 +09:00
2f6e65a9a2
Gracefully handle undefined DateTimeOffset values
...
Only seems to happen in tests, but best to safeguard against this
regardless.
2022-02-21 16:35:40 +09:00
656c58567d
Add safeties to skip attempted import of the intro beatmap when osu! ruleset not present
...
In general running this import will not cause any critical failures, but
the import itself *will* fail – and more loudly with the upcoming
changes to `RulesetStore` (https://github.com/ppy/osu/pull/16890 ). Due
to it being a loud failure, it will cause the notification overlay to
display a parsing error, which can interrupt the flow of some tests.
See test failure at
https://github.com/ppy/osu/runs/5268848949?check_suite_focus=true as an
example (video coverage at
https://github.com/ppy/osu/pull/16890#issuecomment-1046542243 ).
2022-02-21 16:21:38 +09:00
3d0caa44c8
Remove unused utils class
2022-02-21 13:43:30 +09:00
fc1877b6fa
Move to extension method and revert logic to match previous implementation
2022-02-21 13:42:26 +09:00
c3b365cf6b
Scale classic score by hitobject count
2022-02-21 13:31:03 +09:00
79408f6afc
Add xmldoc and clean up ScoreboardTimeUtils extension methods a touch
2022-02-21 13:30:58 +09:00
2ded7d281b
Remove unused using statement
2022-02-21 13:17:19 +09:00
abe1a3990a
Merge branch 'master' into leaderboard-score-timeref
2022-02-21 12:11:10 +09:00
85e2f68a64
Merge pull request #16933 from bdach/mod-overlay/basic-colour-theme
...
Add all colour constants for "basic" colour theme to `OsuColour`
2022-02-21 11:12:34 +09:00
36a00c1ee2
Remove static OverlayColourProviders
2022-02-20 21:09:08 +01:00
ce0db9d4db
Remove all references to static OverlayColourProviders
2022-02-20 21:09:08 +01:00
79ba37bbab
Add Colour0 to OverlayColourProvider
2022-02-20 21:09:08 +01:00
2592f0900d
Add comments about OverlayColourProvider vs OsuColour distinction
2022-02-20 21:08:58 +01:00
e20ae5b871
Add all colour constants for "basic" colour theme to OsuColour
2022-02-20 21:00:49 +01:00
