Commit Graph

32180 Commits

Author SHA1 Message Date
93bdca5211 Split out GetTextures helper function for LegacySkins 2022-04-07 17:28:48 +09:00
f0698937b7 Merge pull request #17700 from peppy/fix-skin-lookups-extension-specified
Fix filename lookups on `LegacySkin`s going awry when extension is specified
2022-04-07 17:03:27 +09:00
5af93bd85d Merge pull request #17701 from peppy/fix-storyboard-animation-sizing
Fix storyboard animations getting incorrect positioning due to size not being set
2022-04-07 17:00:39 +09:00
a7e262627f Fix DrawableStoryboardAnimation not specifying sizing correctly
Usually this would be handled by `TextureAnimation`, but because we are
inheriting from `DrawableAnimation` here for reasons, we needed to
implement this ourselves. Follows the implementation in
`TextureAnimation`.
2022-04-07 15:18:55 +09:00
eb0653fa7b Merge pull request #17698 from Joehuu/fix-replay-button-local-being-disabled
Fix replay button being disabled when available locally but not online
2022-04-07 14:18:02 +09:00
205edb65a2 Fix filename lookups on LegacySkins going awry when extension is specified
Due to the logic present to handle `@2x` fallback, the extension was
potentially being added at the wrong point in the filename. This change
ensures that the lookup filenames are always correct.

Closes https://github.com/ppy/osu/issues/17690.
2022-04-07 14:16:19 +09:00
9ed4f31048 Update resources 2022-04-07 13:35:07 +09:00
358931842f Move enabled setting to each case 2022-04-06 21:22:56 -07:00
8a73831115 Add MP lobby 'warning' SFX for the final seconds of countdown 2022-04-07 13:12:33 +09:00
4432a93d09 Fix replay button being disabled when available locally but not online 2022-04-06 20:43:56 -07:00
c997d0fcf0 Merge pull request #17631 from bdach/mod-overlay/full-screen
Implement basic layout & behaviour of new mod select screen
2022-04-07 10:23:49 +09:00
4c20e67478 Merge pull request #17683 from huoyaoyuan/remove-outdated
Remove some outdated packages
2022-04-07 10:13:15 +09:00
c440d89ef9 Merge pull request #17678 from peppy/get-virtual-time-length
Change `WorkingBeatmap.GetVirtualTrack` to use length provided by `BeatmapInfo`
2022-04-07 09:32:59 +09:00
4b3569ea79 Merge pull request #17576 from peppy/fix-multiplayer-unobserved
Centralise exception handling of `MultiplayerClient` calls
2022-04-07 09:09:55 +09:00
ec4f1bcbc8 Remove outdated NETCore packages. 2022-04-06 19:18:18 +08:00
c42ef43faa Ensure intro beatmap has protected flag set
In cases this isn't set, the beatmap has likely entered a bad state.

Closes https://github.com/ppy/osu/issues/17659.
2022-04-06 16:46:53 +09:00
2b8a5833dd Fix back-to-front conditional check 2022-04-06 15:13:02 +09:00
552ec5282f Change WorkingBeatmap.GetVirtualTrack to use length provided by BeatmapInfo
A lot of tests are using test resources that populate the length field,
but do not populate hitobjects. The general expectation is that
components should be using the cached length in cases where hitobjects
are not relevant, but `GetVirtualTrack` was doing its own local
calculation.

This could cause tests to fail due to `MusicController` changing track
in the background.
2022-04-06 14:51:15 +09:00
f795f77cf9 Add missing newline 2022-04-06 14:00:54 +09:00
c540810943 Merge branch 'master' into fix-multiplayer-unobserved 2022-04-06 11:33:10 +09:00
01da3924cc Simplify IsCurrentScreen check to only apply to relevant call 2022-04-06 11:32:35 +09:00
2525ec0d18 Switch 24H toggle from UI settings to language settings 2022-04-05 17:07:58 -04:00
9d475f7b33 Add config in settings for forcing 24H time, determines default off CurrentCulture 2022-04-05 16:21:28 -04:00
9c91e6d8f5 Merge branch 'master' into mod-overlay/full-screen 2022-04-05 21:29:40 +02:00
74706f72e6 Add 12-hour display setting (TODO add toggle) 2022-04-05 15:10:55 -04:00
ac799aaf7a Add missing newline 2022-04-05 19:25:47 +09:00
32daf64a31 Use newly exposed framework helper function to find closest parent 2022-04-05 19:24:34 +09:00
631aa2a6ec Remove left padding to allow left-most column to exist further to the.. left 2022-04-05 18:44:25 +09:00
54715885af Adjust animation metrics slightly 2022-04-05 18:41:01 +09:00
7a1820e6bb Fix multiplier display resetting transformations 2022-04-05 18:40:48 +09:00
9fdeb20537 Animate individual ModColumns during togle of oerlay 2022-04-05 18:27:34 +09:00
901032bfa2 Animate multiplier display 2022-04-05 18:25:27 +09:00
7623f3b90b Merge branch 'master' into skin-editor-import-at-cursor 2022-04-05 17:39:11 +09:00
2b59f76b2d Merge pull request #17596 from peppy/skin-editor-sprites
Allow importing sprites into a skin via drag-and-drop
2022-04-05 17:38:58 +09:00
497e5e3a36 Slightly adjust scroll handling and also apply to ModSettingsContainer 2022-04-05 17:19:33 +09:00
a408776734 Limit FillFlow of columns to applicable direction 2022-04-05 17:15:05 +09:00
388322cd61 Speed up customisation panel toggle a bit 2022-04-05 16:56:24 +09:00
58e9147b12 Simplify and better comment nested scroll conditionals 2022-04-05 16:48:25 +09:00
2ec15a1ebe Fix lookup through transformers 2022-04-05 16:47:15 +09:00
f156cb797d Improve nested scroll behaviour 2022-04-05 16:46:09 +09:00
23dad7bdc4 Move scroll view padding to content level
Without doing this, there is a non-masked but also non-interactive area
to the left or right of the view.
2022-04-05 16:43:00 +09:00
c973d33bfd Merge pull request #17604 from nekodex/mp-countdown-sfx
Add SFX for multiplayer lobby countdown timer
2022-04-05 16:40:26 +09:00
3d8ae0465f Reword comment slightly 2022-04-05 15:51:04 +09:00
8e543204cd Remove debounce logic (not required after switching to Update clock time) 2022-04-05 15:49:47 +09:00
5f415cbe53 Full potential null reference and add better commentary on countdown scheduling 2022-04-05 15:48:18 +09:00
d0f83885ce Appease the CI 2022-04-05 13:20:34 +09:00
31bf0c4a9b Disable "final" sample in countdown for the time being 2022-04-05 13:16:06 +09:00
174dc1641c Fix multiple issues with timekeeping
- Using realtime (`DateTimeOffset.Now`) meant that values would be
  changing in the same frame, causing misfirings or incorrect displays
- No debounce on sample playback meant that scheduling edge cases could
  potentially cause samples to be played more than once.
2022-04-05 11:49:58 +09:00
3ca365ad7f Merge branch 'master' into dangerous-delete-actions 2022-04-05 10:55:01 +09:00
Ame
32c89f8643 Handle repeated OnPressed() on FooterButton (without FooterButtonRandom) 2022-04-05 00:33:41 +02:00