0ccac24f76
Split out base implementation of MultiplayerGameplayLeaderboard test
2022-04-11 19:15:46 +09:00
a7eb5d71f1
Merge pull request #17765 from peppy/fix-multiplayer-room-type
...
Fix `MultiplayerTestScene` not setting match type correctly
2022-04-11 19:12:57 +09:00
34457b4742
Expose mocked members as virtual on Multiplayer and SpectatorClient
2022-04-11 19:04:15 +09:00
abb42a54fd
Fix MultiplayerTestScene not actually setting match type correctly
2022-04-11 17:57:05 +09:00
5cfafee83c
Merge pull request #17764 from smoogipoo/fix-playlist-results-screen-test
...
Fix incorrect cursor parameterisation in test scene
2022-04-11 16:10:20 +09:00
d1de516b11
Fix incorrect cursor parameterisation in test scene
2022-04-11 15:40:28 +09:00
72cb3d6ad6
USe MathF in all applicable places
2022-04-11 14:15:08 +08:00
37976c569a
Merge pull request #17762 from peppy/fix-unobserved-exceptions
...
Avoid throwing unobserved exception when `PerformancePointsCounter` requests timed attributes
2022-04-11 14:50:12 +09:00
489f064b13
Merge pull request #17761 from peppy/fix-drawable-room-null-reference
...
Fix potential crash in `DrawableRoom` due to lack of null check on post-lookup beatmap
2022-04-11 14:50:01 +09:00
cb6e557212
Fix MasterGameplayClockContainer having incorrect rate-based offsets immediately after LoadComplete
...
I've attempted to explain why this is required using inline comments.
There's also further conversation at
https://github.com/ppy/osu/pull/17302#issuecomment-1091850927 .
2022-04-11 14:11:26 +09:00
808f0ecb74
Ensure running state is updated before performing Seek in GameplayClockContainer.Reset
2022-04-11 14:10:50 +09:00
2b74dbca28
Fix potential crash in DrawableRoom due to lack of null check on post-lookup beatmap
2022-04-11 13:44:34 +09:00
779f7390b7
Add test coverage of DrawableRoom actually showing post-retrieval text
2022-04-11 13:44:34 +09:00
19b655d75b
Avoid throwing unobserved exception when PerformancePointsCounter requests timed attributes
2022-04-11 13:30:21 +09:00
f2e67d00cc
Merge pull request #17743 from smoogipoo/fix-particle-spewer-nan
...
Fix ParticleSpewer outputting NaN values in vertices
2022-04-09 23:06:14 +09:00
d482ab0287
Fix ParticleSpewer outputting NaN in vertices
2022-04-09 22:29:55 +09:00
2702f7b9f9
Merge pull request #17731 from peppy/fix-highlight-null-ref
2022-04-08 20:20:03 +03:00
134d9b5ddf
Perform Show() at the bottom of the method
...
Probably not affecting behaviour, but makes more sense.
2022-04-08 19:28:04 +03:00
34adc1d410
Add quick test coverage
2022-04-08 19:21:37 +03:00
57fb8616b8
Fix potential null reference when attempting to highlight a message before overlay has been displayed
2022-04-09 00:31:00 +09:00
ae1e126837
Make HighlightMessage implicitly show chat overlay
2022-04-09 00:30:28 +09:00
53484eb7de
Merge pull request #17728 from smoogipoo/fix-breaking-assert
...
Remove some incorrectly-firing asserts
2022-04-08 22:58:57 +09:00
9ea6f9b1fe
Remove some incorrectly-firing asserts
2022-04-08 21:44:44 +09:00
62f5409191
Merge pull request #17725 from peppy/multiplayer-hotifx
...
Avoid multiplayer crashes when events arrive in unexpected order
2022-04-08 20:23:37 +09:00
1f5e435bb3
Merge pull request #17726 from peppy/update-framework
...
Update framework
2022-04-08 19:48:24 +09:00
e6e475118f
Merge pull request #17724 from peppy/fix-disconnect-assert-issue
...
Fix potential assert failure due to `Room` access from disconnection event
2022-04-08 19:44:20 +09:00
ea4ca6d2ad
Update framework
2022-04-08 18:09:57 +09:00
5c571996d8
Avoid multiplayer crashes when events arrive in unexpected order
...
Intended to be a temporary fix for
https://github.com/ppy/osu/issues/17713 while a more permanent solution
is established. A proper fix is actually quite simple, but updating the
test to work with it is... *slightly* more complicated.
This hotfix will mean that if a `UserJoined` event arrives during the
unobserved window during room join (of the local user), the local user
still won't see the joining user, but the game won't crash as a result.
2022-04-08 17:55:47 +09:00
6bb8243212
Fix potential assert failure due to Room access from disconnection event
2022-04-08 17:41:03 +09:00
975bb8cc2a
Merge pull request #17703 from peppy/fix-storyboard-fallback-animation-frame-count-weirdness
...
Fix `DrawableStoryboardAnimation` to handle skin fallback frame count similar to stable
2022-04-08 17:01:17 +09:00
c48f8d7b9b
Merge pull request #17714 from bdach/mod-overlay/multimod-incompatibility
...
Ensure that mods grouped into multi mods are pairwise incompatible
2022-04-08 16:43:06 +09:00
21b81b693d
Merge pull request #17721 from peppy/multiplayer-client-thread-safety
...
Add and assert thread safety of `MultiplayerClient.Room`
2022-04-08 16:31:08 +09:00
879267862c
Fix typo in DrawableOsuHitObject
2022-04-08 15:20:22 +09:00
933a722cfc
Remove secondary null checks which cannot exist (were on wrong thread)
2022-04-08 14:56:04 +09:00
24c2d465a9
Move null assert in MultiplayerPlayer on to update thread
2022-04-08 14:53:14 +09:00
64c63fe93a
Move null check in JoinRoom on to update thread
2022-04-08 14:52:56 +09:00
d50f41225f
Rename scheduleAsync to runOnUpdateThreadAsync
2022-04-08 14:43:53 +09:00
9ba99ed57d
Ensure all access to MultiplayerClient.Room is on the update thread
...
This was an implicit requirement until now, but not well documented
everywhere. Adding this makes it much easier to understand the
requirement (and probably safer).
2022-04-08 14:42:56 +09:00
282b220d94
Fix test failure due to checking incompaatibility of flattened multi mods
2022-04-08 00:16:50 +02:00
e99d0f9fae
Make all OsuModObjectScaleTween implementations incompatible with each other
2022-04-07 22:38:47 +02:00
5e02ba353b
Make OsuMod{Blinds,Flashlight} incompatible
2022-04-07 22:38:46 +02:00
6630b38c08
Make all ModRateAdjust implementations incompatible with each other
2022-04-07 22:38:46 +02:00
112096768b
Add test checking incompatibility of multi mods
2022-04-07 22:38:46 +02:00
8175741a6c
Merge branch 'master' into fix-storyboard-fallback-animation-frame-count-weirdness
2022-04-07 21:49:32 +02:00
d256bd2cc7
Merge pull request #17704 from peppy/bindable-safety-skin-editor
...
Fix multiple issues with bindable safety in `SkinEditor` components
2022-04-07 21:43:56 +02:00
71c0216c55
Add null check guards to unsubscriptions in Dispose()
2022-04-07 21:37:42 +02:00
04db80848b
Remove unused using directives
2022-04-07 21:24:50 +02:00
3016ce7817
Merge branch 'master' into bindable-safety-skin-editor
2022-04-07 20:59:44 +02:00
926710beac
Merge pull request #17670 from perrymacmurray/clock
...
Add support for 12-hour time on toolbar clock
2022-04-07 20:58:58 +02:00
b84a3b7834
Rewrite input drum measurements to autosize on X axis
2022-04-07 21:39:53 +03:00
