9d236c503d
Merge pull request #17609 from CenTdemeern1/toolbar-clock-tests
...
Add test coverage for toolbar clock mode cycling
2022-04-02 15:46:57 +02:00
c103cee1d5
Need to commit the second half again because my Git UI messed up
2022-04-02 04:53:47 +02:00
a1baced777
Change behavior of the display mode test
...
I remembered to run InspectCode this time, all good
2022-04-02 04:45:21 +02:00
ee9696855b
Remove hover test
2022-04-02 04:41:05 +02:00
245e452d41
Remove redundant typecast I accidentally left in (Thanks InspectCode)
2022-04-02 04:31:43 +02:00
95ccac50d4
Add display mode changing test
...
Yup this is gonna fail horribly
2022-04-02 04:26:16 +02:00
9350f6f5f8
Add spaces around commas in Vector2 construction
2022-04-02 02:59:07 +02:00
dc744f18ff
Trim whitespace
2022-04-02 02:43:51 +02:00
6685c97147
mainContainer -> toolbarClock
2022-04-02 02:43:44 +02:00
b07152a119
Initial attempt at writing a test for the toolbarClock
...
I'll add more once I know if this code passes review or not
2022-04-02 02:35:37 +02:00
0f4b75ab15
Add multiplayer lobby countdown SFX
2022-04-01 21:33:57 +09:00
6776c37bbc
Merge pull request #17592 from peppy/skin-mutation-better-naming
...
Fix automatically created "(modified)" skins getting conflicting names
2022-04-01 21:25:10 +09:00
43d03f2825
Put ToArray call in correct place in brackets
2022-04-01 19:30:16 +09:00
6e6271d0c0
Fix "server-side" room playlist not updated
...
Remove unused using
2022-04-01 18:32:10 +09:00
16d4544ff9
Prevent reloads when playlist item order changes
2022-04-01 17:06:37 +09:00
37dea0ff21
Add failing test case
2022-04-01 17:05:11 +09:00
9d93cffbb2
Merge pull request #17490 from frenzibyte/improve-bug-issue
...
Apply minor changes to the issue report template
2022-04-01 17:04:28 +09:00
fc3ebe9b51
Reword log retrieval steps on mobile platforms
...
Co-authored-by: Dean Herbert <pe@ppy.sh >
2022-04-01 10:40:16 +03:00
01681ee874
Add missing ToArray call
...
Not sure where this went, was there in my original commit.
2022-04-01 16:19:02 +09:00
f0821ce1fc
Import new skin editor sprites to the cursor location
2022-04-01 16:16:49 +09:00
cabf6f501f
Merge pull request #17594 from peppy/move-skin-component-error-handling
...
Move `SkinnableInfo` error handling to lower level
2022-04-01 16:04:00 +09:00
c294819128
Merge pull request #17593 from peppy/disable-random-skin-in-skin-editor
...
Disable ability to use random skin shortcut from within the skin editor
2022-04-01 16:03:50 +09:00
6afed5e865
Fix new SettingsItem attribute not playing well with non-Drawables
2022-04-01 16:01:33 +09:00
bfd3406f5f
Ensure that file is imported and caches are invalidated before placing new sprites
2022-04-01 16:01:33 +09:00
314ad63c6e
Simplify available file lookup and include file extension
2022-04-01 16:01:33 +09:00
2b7105ac4f
Add a default sprite representation to allow better placeholder display in skin editor toolbox
2022-04-01 16:01:33 +09:00
52eeaffce3
Limit lookup resources to images
2022-04-01 16:01:33 +09:00
d1be229d74
Combine SkinSprite into SkinnableSprite
2022-04-01 16:01:33 +09:00
762de3cc97
Replace invalidation logic with local realm notification subscription
2022-04-01 16:01:33 +09:00
9c3dad9fbf
Add proof of concept flow to ensure RealmBackedResourceStore is invalidated on realm file changes
...
I'm not at all happy with this, but it does work so let's go with it for
now.
2022-04-01 16:01:33 +09:00
66f5eae530
Hook up a dropdown to show all available sprites for the current skin
2022-04-01 15:01:43 +09:00
fca9faac9b
Add SkinnableSprite for arbitrary sprite additions
2022-04-01 14:36:36 +09:00
3a16483214
Add prioritised user lookups for default skin
...
This allows user resources to be consumed before falling back to the
game bundled assets.
2022-04-01 14:36:36 +09:00
01829cf2d8
Move SkinnableInfo error handling to lower level
...
Handling was recently added to handle the usage in
`Skin.GetDrawableCompoent`, but it turns out this is also required for
`DrawableExtensions.ApplySkinnableInfo` which can throw in a similar
fashion.
Found while working on sprite support for the editor, where this becomes
an actual issue (ie. switching to a branch where the new sprite support
is not present can cause unexpected crashes).
2022-04-01 14:30:04 +09:00
88306a6180
Disable ability to select random skin from within the skin editor
...
Reasoning is explained in inline comment.
I knowingly only applied this to the shortcut key. It's still feasible a
user can choose the option from the skin dropdown while the editor is
open, but that's less of an issue (because a user won't get the same
compulsion that I get to mash the key, only to be greeted with 100 new
mutable skins created).
2022-04-01 14:22:32 +09:00
69d4f86122
Fix automatically created "(modified)" skins getting conflicting names
...
Applies the already tested and proven method that is used in the editor
to the mutable skin creation flow.
2022-04-01 14:11:55 +09:00
0a86bf6fb1
Merge pull request #17588 from peppy/aim-assist-rename
...
Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour
2022-04-01 14:04:30 +09:00
4c8f427ad3
Merge pull request #17589 from peppy/tournament-scene-manager-key-bindings
...
Add ability to switch between most common tournament scenes using key bindings
2022-04-01 14:04:21 +09:00
6b9f5812a5
Merge pull request #17579 from CenTdemeern1/clock-button
...
Make the toolbar clock feel more like a button
2022-04-01 13:12:48 +09:00
10f15f2bdb
Merge pull request #17559 from bdach/mod-overlay/sheared-toggle
...
Implement sheared toggle button
2022-04-01 13:06:22 +09:00
de625125d6
Rename magnetised mod attraction strength property to match new naming
2022-04-01 13:03:48 +09:00
3bebc88306
Consider spinners when calculating jump angles
...
Spinners are considered in `GeneratePositionInfos`, so they should also be considered in `RepositionHitObjects`
2022-04-01 11:59:24 +08:00
ee65677884
Use height of playfield instead of width when randomizing the first object
...
This is the change discussed in #17194 . The effect of this change is barely noticeable, but it makes more sense to generate the object within playfield from the start.
2022-04-01 11:57:45 +08:00
031a977009
Calculate slider rotation using end point of path instead of EndPosition
2022-04-01 11:50:30 +08:00
0015f627b0
Add xmldoc
2022-04-01 11:49:27 +08:00
c0a78924aa
Fix generation for zero-length sliders
2022-04-01 11:47:21 +08:00
ea672745b0
Add ability to switch between most common tournament scenes using key bindings
2022-04-01 12:44:49 +09:00
af3835083c
Fix slider relative rotation calculation
2022-04-01 11:41:45 +08:00
998df5a4fe
Fix large slider clamping
2022-04-01 11:37:10 +08:00
cabbc486e9
Rotate sliders in random mod
2022-04-01 11:36:20 +08:00
