c867068cae
Update framework
2022-03-08 21:15:14 +09:00
da7c6f1772
Merge branch 'master' into chat-mention-highlight
2022-03-08 21:15:12 +09:00
a352a140bc
Merge pull request #17157 from peppy/fix-statistics-json-serialisation
...
Fix incorrect serialisation of submitted scores
2022-03-08 20:20:31 +09:00
4603e082f5
Merge pull request #17160 from peppy/remove-unnecessary-user-submittable-score
...
Remove `user` from `SubmittableScore`
2022-03-08 19:34:47 +09:00
e0dc3a04f3
Merge pull request #17159 from smoogipoo/add-hitresult-helper
...
Add IsBasic() and IsTick() extensions on HitResult
2022-03-08 18:46:39 +09:00
b0f40d9e45
Remove user from SubmittableScore
...
This wasn't being used by osu-web, and included far too much unnecessary
data. Of note, `pp` and `ruleset_id` are also not strictly required, but
there's no harm in sending them so I've left them be for now.
2022-03-08 18:38:24 +09:00
a172fc6cb8
Add IsBasic() and IsTick() extensions on HitResult
2022-03-08 18:19:12 +09:00
9a347af5c7
Add test coverage of SubmittableScore serialisation to (roughly) match spec
2022-03-08 17:58:52 +09:00
589a40ca2d
Add EnumMember naming to HitResult to allow for correct json serialisation
2022-03-08 17:58:37 +09:00
719331420c
Merge pull request #17155 from peppy/beatmap-leaderboard-dont-handle-offset-changes
...
Fix `BeatmapLeaderboard` refreshing on changes in local offset setting
2022-03-08 15:38:05 +09:00
622ec53130
Fix BeatmapLeaderboard refreshing on unrelated changes to a beatmap
2022-03-08 14:50:47 +09:00
2a55c5e02e
Add extension method to detect and isolate realm collection-level changes
2022-03-08 14:50:47 +09:00
5e0882df8d
Simplify message highlighting transforms
2022-03-08 04:00:11 +03:00
d74064b94b
Use Equals instead of reference equality operator
2022-03-08 03:56:27 +03:00
f645869958
Update ChannelManager.CurrentChannel directly to handle non-loaded chat scenario
...
`currentChannel` gets instantiated once the chat overlay is open, while
`HighlightMessage` could be called while the chat overlay has never been
open.
This will all be rewritten with the new chat overlay design anyways, so
should be fine for now.
2022-03-08 03:42:18 +03:00
f8e5570e41
Fix Message equality not passing on equal references
2022-03-08 03:20:20 +03:00
7f47be4680
Refactor message highlighting logic to rely on a Channel data bindable
2022-03-08 03:19:37 +03:00
5764c53c17
OpenChannelNotification -> HighlightMessageNotification
2022-03-08 03:16:07 +03:00
22a2ef42c5
Check channel ID on message highlight using currentDrawableChannel
2022-03-08 01:22:47 +03:00
e0d2c8ca5e
Merge pull request #17046 from peppy/clowd-squirrel
...
Replace squirrel fork with `Clowd.Squirrel`
2022-03-07 16:25:40 +09:00
51f6eb4028
Merge pull request #17075 from peppy/realm-property-watching
...
Add ability to watch properties via a `RealmAccess` helper method
2022-03-07 14:38:23 +09:00
31d6c75f40
Merge branch 'master' into realm-property-watching
2022-03-07 13:53:17 +09:00
b90a5864b1
Merge pull request #17138 from peppy/disallow-icon-interaction
...
Disallow interaction with carousel set difficulty icons unless selected
2022-03-07 13:00:18 +09:00
da29947ecd
Disallow interaction with carousel set difficulty icons unless selected
...
I kinda liked this flow, but from multiple reports from users it
definitely seems in the way. We can revisit after the new design is
applied to song select.
Note that this means the tooltips also don't display. If it is preferred
that they should (arguable from a UX perspective, since I'd expect to be
able to click at that point) then the issue can be addressed using a
slightly different path (a few more lines - nothing too complex).
2022-03-07 11:34:08 +09:00
bd1adaf245
Merge pull request #17115 from frenzibyte/manual-channel-scroll
...
Refactor channel scrolling container to handle non-user scrolls
2022-03-07 11:26:23 +09:00
32d242dd62
Hook up message notifications to chat message highlighting logic
2022-03-07 05:10:49 +03:00
741702549b
Add test coverage for chat overlay message highlighting
2022-03-07 05:10:49 +03:00
f4fa80c1e3
Add support to highlight messages in chat overlay
2022-03-07 05:10:49 +03:00
cb2133944d
Add test coverage for channel message highlighting
2022-03-07 05:10:49 +03:00
30b38345aa
Add ability to highlight chat lines
2022-03-07 05:08:36 +03:00
ba83db0229
Merge pull request #17134 from bdach/mod-overlay/popup-screen-title
...
Implement popup screen title component
2022-03-07 11:03:38 +09:00
3e73b8c78a
Merge pull request #17059 from frenzibyte/fix-storyboard-sample-rate
...
Fix storyboard samples rate not adjusted from actual gameplay mods
2022-03-07 09:41:06 +09:00
e5a6564034
Merge branch 'master' into fix-storyboard-sample-rate
2022-03-07 03:12:40 +03:00
d9be65ea39
Remove no longer necessary CancelUserScroll method
2022-03-06 23:58:06 +03:00
60334046e4
Revert UserTrackingScrollContainer changes
2022-03-06 23:57:51 +03:00
a13a087f5d
Add xmldoc to trackNewContent to explain its purpose
2022-03-06 23:51:27 +03:00
9ec0e74813
Move scrolling to UpdateAfterChildren to avoid scheduling
...
At least that's what I believe "let FillFlow update to new size" means.
2022-03-06 23:50:58 +03:00
9bc1f3f014
Further refactor and simplify ChannelScrollContainer
2022-03-06 23:34:12 +03:00
54275813b5
Use text flow container in popup screen title
2022-03-06 20:41:31 +01:00
df0617f34c
Implement popup screen title component
2022-03-06 16:09:18 +01:00
e322eb578a
Merge pull request #17116 from bdach/sample-popover-tabbing
...
Allow tabbing between textboxes in sample point popover
2022-03-06 11:45:16 +09:00
e1eeb9c6bb
Allow tabbing between textboxes in sample point popover
2022-03-06 01:43:56 +01:00
634821e49f
Use the term "programmatically" instead
2022-03-06 00:01:45 +03:00
5b3ffb12b7
Refactor channel scrolling container to handle manual scrolls resiliently
2022-03-05 23:27:07 +03:00
4de66bb1c6
Merge pull request #17093 from peppy/offset-ui-improvements
...
Show beatmap offset adjustments in a more visual way
2022-03-06 02:17:36 +09:00
0e8ad4b143
Switch step to Until steps due to AddOnce firing logic
2022-03-06 01:50:25 +09:00
06512e8bd9
Use const for minimum height specification in final usage location
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2022-03-06 01:01:22 +09:00
f8ef352306
Don't consider judgements beneath the minimum height as being applicable
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2022-03-06 01:00:47 +09:00
08b3bc222d
Revert "Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available"
...
This reverts commit 8115a4bb8f
2022-03-05 16:42:51 +01:00
e4b4c3c5c4
Merge branch 'master' into offset-ui-improvements
2022-03-05 16:10:18 +01:00
