449e5fa6f8
Rename one more left-over skinnable naming
2023-02-17 22:09:55 +03:00
1a63ca9ece
Add xmldoc around SkinComponentsContainerLookup
2023-02-17 14:18:05 +09:00
cb7df7282b
Apply NRT to SerialisedDrawableInfo
2023-02-16 20:01:59 +09:00
81dcc105a9
Rename left-over skinnable naming in SerialisedDrawableExtensions
2023-02-16 15:34:41 +09:00
76f7accd13
Standardise all local SkinComponentsContainerLookup variables to containerLookup
2023-02-16 15:33:56 +09:00
eea0cd3cf8
Reword xmldoc on ISerialisableDrawable to make less skin-centric
2023-02-16 15:31:35 +09:00
0b25f7baeb
Reword and fix typos in some new xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2023-02-16 15:27:30 +09:00
08ed174f61
Change GameplaySkinComponentLookup's generic to always be an enum
...
And document the class better.
2023-02-15 18:48:14 +09:00
a92e42bb84
Rename SkinnableTargetContainer to SkinComponentsContainer
...
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
b1cf6d83d8
Move extension methods closer to serialisation classes
2023-02-15 18:37:41 +09:00
e61d2d571c
Move the lookup type out of ISserialisableDrawableContainer
2023-02-15 18:37:41 +09:00
a7b47f6503
Rename ISkinnableTarget to ISerialisableDrawableContainer
2023-02-15 18:37:41 +09:00
d159d6b970
Rename ISkinnableDrawable to ISerialisableDrawable
2023-02-15 18:37:41 +09:00
8cb5a51aa7
Add further documentation to skin classes
2023-02-15 18:23:19 +09:00
856efd9fd9
Rename SkinnableDrawableInfo to SerialisedDrawableInfo
2023-02-15 18:23:19 +09:00
9e651a7ca2
Rename SkinnableInfo to SkinnableDrawableInfo
2023-02-15 18:23:17 +09:00
6010dde86e
Move SkinnableInfo to better namespace
2023-02-15 18:23:10 +09:00
8bbd00822c
Simplify and rename SkinnableTargetComponentsContainer
2023-02-15 17:30:21 +09:00
55358d36c8
Change MinimumColumnWidth to remove setter
2023-02-13 17:50:32 +09:00
ca768ca446
Add comment regarding unused enum members in LegacyNoteBodyStyle
2023-02-13 17:43:52 +09:00
bfbffc4a68
Add parsing support for mania NoteBodyStyle
2023-02-10 19:46:59 +09:00
635e225d19
Add correct lookup for WidthForNoteHeightScale
2023-02-10 19:18:41 +09:00
e5f62b0d2e
Remove public access modifier from interface methods
2023-02-06 14:19:25 +09:00
10ab4d572a
Merge branch 'master' into skin-editor-undo-support
2023-02-06 13:46:50 +09:00
59656a7286
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-03 19:08:33 +01:00
2f30306ea2
Expose a method to reload a SkinnableTargetContainer from provided info
2023-02-03 18:53:09 +09:00
92306b9123
Combine localisations for abstract skinnable components into a single file
...
Generally we don't want localisation files with only one to two
translations. It makes it harder for translators to handle in crowdin (a
lot of file changes for small results).
So for cases like this I believe we should be grouping translations
where it makes sense.
I've left individual components in their own files as I can see
potential for more settings to be added in the future. Plus it gives a
bit of extra context.
2023-02-03 16:02:18 +09:00
cf8cfe0d2c
Move skin component localisations to namespaces
2023-02-03 15:34:57 +09:00
32207dc9dd
Merge branch 'master' into locale/skin-editor-components
2023-02-03 15:24:00 +09:00
9c954a93e3
Update Save method xmldoc to make more sense
2023-02-03 15:18:01 +09:00
4d46a8f32d
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-02 19:36:23 +01:00
6c0aada86a
Merge pull request #22490 from peppy/skin-overlay-namespace
...
Move skin editor to overlays namespace
2023-02-02 18:14:16 +01:00
015f4f2b38
Avoid showing skin save message when changing scenes after making no changes
2023-02-02 18:42:37 +09:00
229fb518dc
Apply NRT to LegacyJudgementPieceOld
2023-02-02 14:19:00 +09:00
183d1c5bd6
Change version comparison to match other existing code as proposed in review
2023-02-02 14:18:49 +09:00
263a7e2766
Merge branch 'master' into misses-animation
2023-02-02 14:08:15 +09:00
8dc2e6872e
Move skin editor to overlays namespace
2023-02-02 14:00:31 +09:00
10df64467a
Merge pull request #22430 from peppy/skin-editor-nrt
...
Apply NRT to all skin editor classes
2023-02-02 13:57:57 +09:00
0fb6a63709
refactor: change namespacing to allow osu-localisation-analyzer to process all strings
2023-02-02 00:46:14 +00:00
8645e705fd
feat: add localisation for Skin editor components
2023-02-01 23:48:05 +00:00
c5e1f54185
Fix sample store creation mutating shared resource store
2023-01-30 20:48:52 +01:00
74ab036f3e
Refactor SkinnableSound.Samples to be non-nullable
2023-01-27 19:32:30 +09:00
8a9a6c733c
Apply missed cleanup to BackgroundDependencyLoader call
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com >
2023-01-27 13:55:34 +09:00
758b4c8cfc
Do the thing aka fix the if
2023-01-26 10:01:33 -03:00
4352c56c3e
Apply NRT to all simple auxiliary skin classes
2023-01-26 17:53:04 +09:00
2017ac1135
Apply NRT to all skin editor classes
2023-01-26 17:52:53 +09:00
64e7f6f138
Add more documentation around the implementation of FontAdjustableSkinComponent
2023-01-26 16:05:07 +09:00
d63719a602
Move and rename the base component class
2023-01-26 16:04:56 +09:00
48885d40cc
Merge branch 'master' into skin-fonts
2023-01-26 15:52:54 +09:00
f3c92749bf
Fix code quality issues
2023-01-26 15:43:03 +09:00
