463774d4f2
add ShowPage method in WikiOverlay
2021-05-19 19:12:16 +07:00
a32f1ef35a
Merge pull request #12811 from PercyDan54/hidden-code-cleanup
...
Remove obsolete methods in `ModHidden` and apply few touches
2021-05-16 22:07:45 +09:00
0f82eb464f
Merge branch 'master' into single-bind-reset-button
2021-05-16 15:02:01 +10:00
90f00a7663
Fixes ResotreDefaultValue to use the BindableWithCurrent correctly
2021-05-16 15:01:19 +10:00
5972e43bc2
Renamed TaikoModFlip to TaikoModInvert
2021-05-16 12:51:40 +08:00
264d8b9b86
Finishing requested changes, and tidy up
2021-05-16 14:48:00 +10:00
422a3b76b6
Remove unused using statements
2021-05-16 13:21:19 +09:00
cbc2a38b59
Move new mod to end to avoid reordering
2021-05-16 13:21:06 +09:00
3d83741a23
Separate Flip and Random
2021-05-16 12:03:03 +08:00
da13be6dd0
Trimmed trailing white space
2021-05-16 11:28:11 +08:00
3519398a22
Added "flip" mod for taiko
2021-05-16 11:16:12 +08:00
9010cd0839
Merge pull request #12833 from Henry-YSLin/master
2021-05-16 12:12:20 +09:00
a91f2d3dba
Change "judgment" to "judgement"
2021-05-16 10:17:04 +08:00
3e1b1c6c3e
Improve statement readability
2021-05-15 19:14:58 +03:00
e479db9186
Clear transforms in PostsContainer for all children
2021-05-15 19:14:02 +03:00
881d82ccb6
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-15 19:08:48 +03:00
f00799cc64
Remove unused using directive
...
...damn it
2021-05-15 18:36:47 +03:00
243c8aa585
Add test coverage
2021-05-15 18:02:38 +03:00
102842bcf1
Expire legacy combo counters on catch ruleset
2021-05-15 16:55:15 +03:00
4c25fe750f
Disallow beatmap skin to fall back to default HUD components
...
This should become a more generalized `AllowDefaultSkinFallback` when default legacy skin fallback is supported.
2021-05-15 14:32:16 +03:00
b5e1f78c06
Merge branch 'master' into single-bind-reset-button
2021-05-15 20:29:56 +10:00
c282f0e603
Fixing tests
...
For some reason moving the mouse and clicking doesn't work with "dotnet test", but works when you run the osu.Game.Tests project.
2021-05-15 19:42:33 +10:00
50a3775a22
Merge pull request #12717 from frenzibyte/player-loader-star-rating
...
Add star rating to the beatmap metadata in player loading screen
2021-05-15 18:25:58 +09:00
34d1490754
Remove null conditional
...
Shouldn't guard against that here.
2021-05-15 10:00:05 +03:00
dc56250a3c
Merge branch 'master' into player-loader-star-rating
2021-05-15 15:39:57 +09:00
94b7e89ac0
Merge pull request #12747 from frenzibyte/current-star-rating
...
Allow changing current star difficulty of a `StarRatingDisplay`
2021-05-15 15:39:39 +09:00
bdcb1a624e
Merge pull request #12759 from Naxesss/beatmap-verifier-context
...
Encapsulate check arguments in context object
2021-05-15 15:39:12 +09:00
166974506e
Duplicate implementions
2021-05-15 11:55:50 +08:00
6e5c4ed7c6
Revert "Remove empty override"
...
This reverts commit a86a4bab91
2021-05-15 11:45:14 +08:00
63ac430386
Rename startTime in parameters
2021-05-15 11:26:16 +08:00
ecc260030a
Merge branch 'master' into single-bind-reset-button
2021-05-15 12:05:42 +10:00
50d5af9662
Removed unused method
2021-05-15 12:05:22 +10:00
d988194dd3
Formatting
2021-05-15 11:40:42 +10:00
d85f17159f
Formatting
2021-05-15 11:25:56 +10:00
304caf8bdf
Adding Requested changed
2021-05-15 11:24:08 +10:00
878182fbdf
Fix slider ticks not being shifted along with their parent sliders
2021-05-15 02:07:24 +02:00
7632b8621e
Merge pull request #12805 from peppy/add-user-id-beatmap-metadata
...
Add database tracking of beatmap creator `user_id`s
2021-05-15 09:03:52 +09:00
cb9db0da0a
Merge pull request #12801 from peppy/null-assignment-warning-enable
...
Switch null assignment to non-nullable entity warnings on
2021-05-15 09:03:03 +09:00
7665bdfbbb
Merge branch 'master' into null-assignment-warning-enable
2021-05-15 01:08:34 +02:00
69fc072429
Ignore skin component json data if deserialisation fails instead
...
Crashing was not really the best thing to do there given the preceding
code that already allowed a few continues in case of a missing file.
2021-05-15 01:08:11 +02:00
ae71389ebe
Ignore possible nulls from stream reader in IPC
...
Any failures will be caught. They're not logged, but they also weren't
before. Error handling can be improved at a future date, this series of
changes is primarily intending to unblock a new inspection.
2021-05-15 00:09:34 +02:00
d581e0a252
Ignore possible nulls in NotifyCollectionChangedArgs
...
Safe to access by the virtue of the preceding case labels on
`args.Action`. And they're in test code anyways.
2021-05-15 00:09:34 +02:00
e62e473bb2
Ignore possible null in multiplayer test
...
A null value will fail the test anyhow.
2021-05-15 00:09:34 +02:00
b51d038088
Ignore possible path-related nulls
...
They're all in test code anyway, so any issue there will cause a test to
fail.
2021-05-15 00:09:34 +02:00
fa6b5515b7
Ignore possible null from JsonConvert.DeserializeObject()
...
Nothing better can be done if a `null` is indeed returned.
2021-05-15 00:09:34 +02:00
5b2b701915
Ignore possible null in GetResponseString()
...
A null there indicates a deserialisation error and therefore due to the
catch block immediately succeeding the changed line everything will
continue to work as intended.
2021-05-15 00:09:34 +02:00
628e7a71ed
Ignore possible nulls in Type.GetType() calls
...
They're mostly used in extensibility scenarios, so everything happens in
runtime. There is no better resolution than to crash with a null
reference exception.
2021-05-15 00:09:34 +02:00
43c73f9583
Mark access to exception if task faulted as safe
...
There are seemingly no C#-side compile-time guarantees that it is safe,
but if the task's state is `Faulted` (as is checked right before), the
exception cannot be null as per the documentation.
2021-05-15 00:09:34 +02:00
f2d0f7db99
Remove list null-checks in LogoTrackingContainer test
...
If the null-checks were tripped, the test would crash anyway. It is not
possible to call `.Any()` and get a valid result instead of an exception
on a null reference.
2021-05-15 00:09:34 +02:00
483e0dd943
Pass placeholder hitobject instead of null
2021-05-15 00:09:34 +02:00
