Commit Graph

1867 Commits

Author SHA1 Message Date
a426ff1d5b Refactor gameplay menu overlay to fix regression 2020-08-15 14:18:50 +02:00
b7ae70ff96 Merge branch 'master' into fix-skinnable-sound-mute 2020-08-14 19:01:32 +09:00
99bea6b8e9 Add missing null check (player construction is potentially delayed now) 2020-08-13 12:52:35 +09:00
27cd9e119a Delay beatmap load until after transition has finished
Previously the beatmap would begin loading at the same time the
`PlayerLoader` class was. This can cause a horribly visible series of
stutters, especially when a storyboard is involved.

Obviously we should be aiming to reduce the stutters via changes to the
beatmap load process (such as incremental storyboard loading,
`DrawableHitObject` pooling, etc.) but this improves user experience
tenfold in the mean time.
2020-08-13 12:04:32 +09:00
365aae799e Merge branch 'master' into fix-skinnable-sound-mute 2020-08-10 23:55:51 +09:00
e3105fd4c8 Add more resilient logic for whether to avoid playing SkinnableSound on no volume 2020-08-06 19:16:26 +09:00
9a00ad48c6 Update components to use extension methods 2020-08-06 14:43:39 +09:00
e795b1ea31 Failing effect displays vertically 2020-07-28 00:42:48 -07:00
ee05d5cb14 Remove no-longer-necessary play trigger on skin change 2020-07-23 09:06:15 +09:00
a39c4236c7 Fix multiple issues and standardise transforms 2020-07-17 19:08:50 +09:00
aa992f2e34 Merge branch 'master' into Issue#9170 2020-07-17 18:29:40 +09:00
ecbd8067e9 Add ability to seek replays/auto with arrow keys 2020-07-14 20:18:47 -07:00
c49ce65326 Merge pull request #9540 from peppy/gameplay-pause-via-middle-mouse
Allow pausing gameplay via middle mouse button
2020-07-14 21:13:31 +09:00
2626ab41c3 Add implicit braces for clarity 2020-07-14 20:15:31 +09:00
c7d3b025ad Rename variable and change default to true 2020-07-14 20:11:54 +09:00
690f2fd482 Merge branch 'master' into always-combo-break 2020-07-14 20:11:02 +09:00
f442df75a9 Add missing released conditional 2020-07-13 09:00:10 +09:00
c1aafe83fa Add note about future behaviour 2020-07-12 23:05:47 +09:00
08696b9bca Allow pausing gameplay via middle mouse button 2020-07-12 23:03:03 +09:00
f03303573e formating 2020-07-08 13:54:22 +02:00
e8f23e35a5 WIP : replaced TransformBindableTo by VolumeTo
Currently, the VolumeTO calls taht use a fading does not do anything.
calling VolumeTo calls pauseLoop.samplesContainer.TransformBindableTo(....), while i used to call pauseLoop.TransformBindableTo(....)
2020-07-03 14:33:42 +02:00
ab1eb469af removed unneeded null checks 2020-07-01 13:30:23 +02:00
ab134c0ed7 removed unneeded information in a comment 2020-07-01 13:27:33 +02:00
946fcf75ac Merge branch 'master' of https://github.com/ppy/osu into Issue#9170
update local code
2020-07-01 13:06:44 +02:00
0e80d6629b Merge branch 'master' into red-tint 2020-06-30 15:44:22 +09:00
678767918e Centralise logic further 2020-06-28 23:32:04 +02:00
3637bf2f9b Clean up member order & access modifiers 2020-06-26 19:39:55 +02:00
02f590309d Add xmldoc for public property 2020-06-26 19:39:55 +02:00
a63b6a3ddf Simplify binding 2020-06-26 19:39:55 +02:00
415e1c05ff Simplify implementation 2020-06-26 19:39:55 +02:00
3783fe8d6a Rename fields for clarity 2020-06-26 19:39:53 +02:00
798e8e7a8d Fix CI fail 2020-06-26 15:12:01 +02:00
efeaa1cc10 Make some changes, fix and add tests 2020-06-26 14:58:42 +02:00
97a212a7f6 Hide red tint based on "Show health display even when you can't fail" setting 2020-06-26 14:32:01 +02:00
a4bb238c45 fixed bug preventing the pause loop from playing during the first pause after changing a skin 2020-06-26 14:07:27 +02:00
7d2d6a52c9 now uses SkinnableSample instead of Drawable sample
Still does not support switching skins after Pause overlay loading,
there will be no sound for the first pause (works fine the the nexts)

Also, the pause loop seems to play for approximately 1 second when exiting the
screens via restart or quit

finally, since SkinnableSound does not play a sound if its aggregate
volume is at 0, i had turn up the volume a bit before playing the loop
2020-06-25 18:58:04 +02:00
9e5cc1b7a2 added skin support for the pause loop 2020-06-25 13:26:42 +02:00
2e8f30461f play/stops music when entering the pause overlay, instead of letting it play silently in the background 2020-06-24 14:22:12 +02:00
53107973a3 merged 2 lines
Co-authored-by: Salman Ahmed <email@iisalman.me>
2020-06-24 14:01:13 +02:00
9119f41604 Merge branch 'master' into results-screen-statistics-overlapping-transition 2020-06-24 18:22:51 +09:00
43be75d481 Merge branch 'master' into Issue#9170 2020-06-23 20:49:13 +02:00
624ad65806 formating 2020-06-23 13:09:24 +02:00
a6c6e391ca Fix player not exiting immediately on Alt-F4 2020-06-23 17:38:30 +09:00
579d7cedcc Merge branch 'master' of https://github.com/ppy/osu into Issue#9170
updated local source
2020-06-22 15:29:05 +02:00
836386d03b removed duplicate lines 2020-06-22 15:22:13 +02:00
9dea96e5fd added pause sound with fading 2020-06-22 14:02:21 +02:00
a4eb6c81c5 undid changes to the file 2020-06-22 13:40:31 +02:00
261adfc4e6 Create a local playable beatmap instead 2020-06-22 18:38:41 +09:00
33fdd7466c Merge branch 'master' into results-screen-statistics-overlapping-transition 2020-06-22 15:38:48 +09:00
49bdd89775 Cleanup ReplayPlayer adjustments 2020-06-19 21:54:09 +09:00