Commit Graph

22934 Commits

Author SHA1 Message Date
cbd99cc767 Resolve link-in-link edge case
Testing with #6542 surfaced a crash scenario, caused by formatted links
that had URLs in the display text, for example

    [mean example - https://osu.ppy.sh](https://osu.ppy.sh)

In that case the outer Markdown link would get picked up once, and then
reduced to the link text when looking for other links, leading to it
being picked up again the second time when the raw link is found.

Add a check in the raw link parsing path that ensures that the found
URL is not a part of a bigger, pre-existing link.
2019-10-24 15:52:55 +02:00
24b7160522 Add support for parsing Markdown inline links
Extend the Markdown parsing regex to allow parsing so-called inline
links. Within the parenthesis () part of the Markdown URL syntax,
introduce a new capturing group:

    (
      \s+              // whitespace between actual URL and inline title
      (?<title>        // start of "title" named group
        ""             // opening double quote (doubled inside @ string)
        (
          [^""]        // any character but a double quote
          |            // or
          (?<=\\)      // the next character should be preceded by a \
          ""           // a double quote
        )*             // zero or more times
        ""             // closing double quote
      )
    )?                 // the whole group is optional

This allows for parsing the inline links as-provided by web. Correctness
is displayed by the passing tests.
2019-10-24 15:52:55 +02:00
a89ea78a7a Add extended testing for Markdown links
While reviewing #6542 it became apparent that there was another Markdown
link format variant, used in comments that came from the web API, called
the "inline link" style. It allows to specify the tooltip title within
the actual URL portion, as such:

    [link text](https://osu.ppy.sh "tooltip text")

Add tests with a couple of easy and trickier examples of such a format.
Moreover, add a new edge case of a Markdown link with a link inside
the display text, which during tests was detected to be problematic.
2019-10-24 15:52:55 +02:00
ef4dd3e028 Merge pull request #6580 from smoogipoo/remove-controlpoint-snap
Don't snap slider control point placement
2019-10-24 10:27:16 +09:00
fa9690d16c Merge pull request #6582 from smoogipoo/grid-centre
Show centre point of distance snap grid
2019-10-23 18:28:05 +09:00
8250e94ad8 Merge pull request #6581 from smoogipoo/fix-grid-update
Fix distance snapping grid not updating on scroll
2019-10-23 18:20:15 +09:00
436941cda3 Add comment 2019-10-23 17:58:44 +09:00
f61d7e4fbe Add smoothing and tidy code a touch 2019-10-23 17:56:09 +09:00
c03fa01fd9 Remove unnecessary set 2019-10-23 17:51:16 +09:00
2c9b11cdfd Move variable outside of if block 2019-10-23 17:49:21 +09:00
02efd0e943 Merge pull request #6556 from smoogipoo/fix-slider-stack-change
Fix sliders not moving with stacking changes
2019-10-23 17:48:06 +09:00
c9fec50f63 Remove unnecessary whitespace 2019-10-23 17:00:17 +09:00
97383b4a37 Show centre point of distance snap grid 2019-10-23 16:58:56 +09:00
64682611bb Fix distance snapping grid not updating on scroll 2019-10-23 16:39:14 +09:00
b903edca45 Don't snap slider control point placement 2019-10-23 16:03:16 +09:00
54f23cbd0d Update stacking test case values 2019-10-23 15:49:36 +09:00
1c6a775338 Merge pull request #6575 from smoogipoo/apply-framework-fixes
Apply adjustments for framework changes
2019-10-23 15:33:41 +09:00
e836364add Update framework 2019-10-23 15:13:52 +09:00
21e0bd2a5a Merge branch 'fix-wave-container' into apply-framework-fixes 2019-10-23 15:13:41 +09:00
851773a842 Apply adjustments for framework changes 2019-10-23 14:04:06 +09:00
75beba66d5 Merge pull request #6574 from Joehuu/fix-registration-textbox-focus
Fix registration textboxes always focusing after pressing escape
2019-10-23 12:18:08 +09:00
7b7a87afa8 Put back mobile conditional 2019-10-22 19:51:29 -07:00
8154cc1b16 Fix registration textboxes always focusing after pressing escape 2019-10-22 14:40:56 -07:00
e7290c433b Implement day divider for chat (#6569)
Implement day divider for chat

Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-10-23 01:06:46 +09:00
c3375071ad Fix formatting issue 2019-10-23 00:26:47 +09:00
e9aa7f3218 Subclass and use yellow for stand-alone chat display 2019-10-23 00:24:19 +09:00
3b4823abe7 Use foreach 2019-10-23 00:17:37 +09:00
0ba287a7fd Rename variable 2019-10-23 00:14:22 +09:00
7084aa7b81 Merge branch 'master' into chat-day-separator 2019-10-22 15:48:42 +09:00
f43e4bfd70 Merge pull request #6523 from Joehuu/make-most-textbox-carets-movable
Make most textbox carets movable
2019-10-22 15:33:22 +09:00
001eae2c02 Merge remote-tracking branch 'upstream/master' into make-most-textbox-carets-movable 2019-10-22 15:04:16 +09:00
5d0d83b6bf Add basic xmldoc 2019-10-22 15:04:10 +09:00
09b2f11bd5 Remove unused variable 2019-10-22 03:14:20 +03:00
b1eac6b400 Apply suggested changes 2019-10-22 03:11:19 +03:00
e9ae838f46 CI fixes 2019-10-22 02:16:52 +03:00
f7924d3bad Rename "FixedSearchTextBox" to "SeekLimitedSearchTextBox" 2019-10-21 16:00:09 -07:00
2896ed90e2 Fix incorrect date comparison 2019-10-22 01:55:26 +03:00
bb7af1e39c Fix some margin/padding issues 2019-10-22 01:45:04 +03:00
a3ab6d33c1 Add test 2019-10-22 01:37:30 +03:00
d19041fa53 Implement DaySeparator class 2019-10-22 01:30:37 +03:00
75f444e431 Basic implementation 2019-10-22 00:44:58 +03:00
6b50d2194a Integrate osu! distance snapping grid (#6539)
Integrate osu! distance snapping grid

Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-10-21 19:54:49 +09:00
0bf35faae8 Update incorrect reference 2019-10-21 19:25:56 +09:00
e3fa5f1da3 Merge branch 'master' into beatsnap-grid-integration 2019-10-21 18:44:34 +09:00
ed8b8e3ad0 Merge pull request #6557 from smoogipoo/fix-hitcircle-selection-size
Fix hitcircle selection area being too large
2019-10-21 18:43:48 +09:00
8210759039 Merge pull request #6560 from peppy/dho-ho-not-null
Ensure DrawableHitObject's HitObject is not null
2019-10-21 18:42:17 +09:00
1bf5f9313f Fix failing test 2019-10-21 18:10:00 +09:00
9f004186d5 Ensure DrawableHitObject's HitObject is not null 2019-10-21 17:56:39 +09:00
fa95422755 Merge remote-tracking branch 'upstream/master' into beatsnap-grid-integration 2019-10-21 17:53:25 +09:00
b5997f2231 Merge pull request #6558 from peppy/update-framework
Update framework
2019-10-21 17:52:10 +09:00