Commit Graph

32988 Commits

Author SHA1 Message Date
3d771c0fc7 Remove unnecessary loading hide call from PlaceholderState_Set and add more assertiveness 2022-01-30 02:34:31 +09:00
e408d8ef0e rename Frames to ReplayFrames 2022-01-29 23:19:51 +08:00
6f54f8ad78 Add more safety around CancellationToken usage 2022-01-29 23:58:57 +09:00
d0b74a91fb Fix edge cases with score drawable loading 2022-01-29 23:58:57 +09:00
0293d95f82 Simplify IsOnlineScope usage 2022-01-29 23:58:57 +09:00
daea13f491 Simplify flow of cancellation token 2022-01-29 23:58:57 +09:00
3d59bab7c6 Remove fetch callback logic completely 2022-01-29 23:58:57 +09:00
13f445ddd5 Move score update code into own method 2022-01-29 23:58:57 +09:00
c48e9f2bbd Remove more unnecessary schedule/cancel logic 2022-01-29 23:58:57 +09:00
a700ad3849 Remove scoresLoadedOnce weirdness 2022-01-29 23:58:57 +09:00
661fec7c8a Make score setter private 2022-01-29 23:58:57 +09:00
b85b2c01fb Reorder based on accessibility and add regions 2022-01-29 23:58:57 +09:00
c548658662 Remove move unused pieces 2022-01-29 23:58:57 +09:00
17aa9f3040 Remove pointless level of schedule/cancel logic 2022-01-29 23:58:57 +09:00
64925b3fea Remove unused Content override 2022-01-29 23:58:57 +09:00
b9dac6c3b2 Reorder and tidy up bindable flows 2022-01-29 23:58:57 +09:00
aee93934d5 Rename methods to make more sense (and always run through AddOnce) 2022-01-29 23:58:57 +09:00
c6d303a5b4 Add xmldoc to Leaderboard class 2022-01-29 23:58:57 +09:00
a8eb3f95df add readonly modifier 2022-01-29 22:54:17 +08:00
b4e516c535 allow test scenes to specify replays manually 2022-01-29 22:31:24 +08:00
1a14ccc7ee Run EF migrations before migrating to realm
Turns out that there are more than zero users that are upgrading from
old databases. I think we probably want to support this for now.

Tested against database in https://github.com/ppy/osu/discussions/16700
and one other I had locally, both work correctly.
2022-01-29 23:13:23 +09:00
d48fae1100 Revert "Remove all EF migrations"
This reverts commit bb5b9458e8.
2022-01-29 23:13:23 +09:00
98d8b26a9c move ModAlternate to OsuModAlternate and check if intro has ended 2022-01-29 21:49:40 +08:00
2326c36836 remove unused method and fix description 2022-01-29 21:09:36 +08:00
aa582fb0e1 add Alternate Mod 2022-01-29 20:38:12 +08:00
e7823982d8 Fix ruleset value not being transferred when FinaliseSelection is not called 2022-01-29 18:44:48 +09:00
b2ebcabdd5 Fix potential crash during stable install migration due to multiple configuration files
Apparently this can be a thing on windows.

Closes https://github.com/ppy/osu/discussions/16689.
2022-01-29 13:30:07 +09:00
3037a3a769 Purge final spectator frames before ending play 2022-01-28 22:26:05 +09:00
397971c631 Change FrameDataBundle.Frames into an IList 2022-01-28 22:06:34 +09:00
8883505eed Merge pull request #16686 from peppy/fix-ar-on-old-maps
Fix approach rate not being transferred from OD on older beatmaps
2022-01-28 20:17:37 +09:00
53ca597e2b Update framework 2022-01-28 19:12:32 +09:00
142a67e163 Fix approach rate not being transferred from OD on older beatmaps 2022-01-28 18:53:28 +09:00
4d9b61212b Add 'cursor tap' audio feedback 2022-01-28 18:13:51 +09:00
f021a274d2 Merge pull request #16681 from peppy/fix-delete-local-scores
Fix delete local scores via "Clear all scores" button crashing the game
2022-01-28 17:01:31 +09:00
bdc9ca40f2 Merge pull request #16676 from peppy/fix-editor-custom-ruleset
Fix editor crashing on custom rulesets due to `ChangeHandler` not being supported
2022-01-28 16:26:56 +09:00
c7f8528d63 Merge pull request #16673 from peppy/fix-polling-component-thread-safety
Fix occasional non-fatal errors from polling API requests incorrectly getting queued twice
2022-01-28 16:26:47 +09:00
b94984bd2d Merge pull request #16678 from peppy/hold-for-menu-always-fade
Ensure hold for menu button fades out if the cursor is never moved
2022-01-28 15:55:41 +09:00
0d3ac4fd9c Fix delete local scores crashing the game 2022-01-28 15:54:53 +09:00
778eebc94d Add test coverage of local score import and deletion 2022-01-28 15:50:36 +09:00
cb7ae413fe Ensure test game is always active 2022-01-28 15:50:35 +09:00
0bba8a52c6 Merge pull request #16663 from bdach/beatmap-info-defaults
Change some beatmap info/metadata defaults in a backwards compatible manner
2022-01-28 15:41:20 +09:00
28c8e07e3f Ensure hold for menu button fades out if the cursor is never moved
Closes https://github.com/ppy/osu/discussions/16669.
2022-01-28 14:48:35 +09:00
b7d8c9bf06 Fix a couple of cases of incorrect equality checks in the case both values are null 2022-01-28 14:29:56 +09:00
b3856c9005 Fix editor crashing on custom rulesets due to ChangeHandler not being supported
As per https://github.com/ppy/osu/discussions/16668, even without proper
saving support some ruleset developers do want to work on the editor.
This brings things back into a workable state.
2022-01-28 14:03:31 +09:00
91be77ad3d Fix null ref in ComposeScreen when ruleset doesn't provide a composer 2022-01-28 14:01:10 +09:00
c953a5d503 Ensure PollingComponent.Poll is always called from the update thread
Not strictly required since all `Poll` implementations are now
threadsafe, but extra safety is never a bad thing?
2022-01-28 13:44:11 +09:00
c44af4853d Add thread safety to PollingComponent.Poll implementations 2022-01-28 13:43:53 +09:00
f59828e2d9 Add audio feedback to song select 'random' 2022-01-28 13:43:37 +09:00
6674567af1 Use -1 as the default preview time globally in metadata 2022-01-27 21:51:51 +01:00
1b8136e3e0 Change some BeatmapInfo defaults in a backwards compatible manner 2022-01-27 21:49:37 +01:00