1a715b2926
Append "classic" mod to legacy scores
2021-04-21 09:16:28 +03:00
e3398d8f1f
Implement "classic" mod for all other legacy rulesets
...
Currently empty, automatically handled in game to not be selectable (see `Mod.HasImplementation`)
2021-04-21 09:14:33 +03:00
e90d791754
Add base "classic" mod
2021-04-21 09:14:19 +03:00
3fbeadf318
Deprecate old overload of Apply
2021-04-21 14:32:37 +09:00
73d3da1687
Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.
...
HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.
2021-04-21 11:32:01 +09:00
6164902eba
Merge pull request #12510 from smoogipoo/fix-wiggle-slider-tails
...
Fix slider tails wiggling independently
2021-04-21 11:30:13 +09:00
e454037d82
Add to comment
2021-04-21 10:32:13 +09:00
397df41570
Merge pull request #12507 from peppy/fix-cursor-position-rotated
...
Fix click-to-resume cursor location being incorrect when playfield is transformed
2021-04-21 10:29:35 +09:00
9d423201ed
Fix slider tails wiggling independently
2021-04-21 10:29:18 +09:00
be71b383f5
Merge pull request #12506 from peppy/fix-mod-customisation-input-blocking-padding
...
Fix mod settings blocking input outside its visible area
2021-04-21 10:11:35 +09:00
44ff08cce4
Revert "Fix wrong InitialLifetimeOffset is used for a non-pooled DHO."
...
This reverts commit 67fcfd9d
2021-04-21 10:02:50 +09:00
67fcfd9dbc
Fix wrong InitialLifetimeOffset is used for a non-pooled DHO.
...
HitObjectLifetimeEntry's InitialLifetimeOffset is different from DrawableHitObject's InitialLifetimeOffset.
2021-04-21 09:48:16 +09:00
e80c3c317a
Rename UnmanagedHitObjectEntry -> SyntheticHitObjectEntry
...
"Unmanaged" was confusing because its lifetime is still managed by the HitObjectContainer.
2021-04-21 09:23:23 +09:00
a2afa38a3f
Merge branch 'master' into fix-mod-customisation-input-blocking-padding
2021-04-20 19:41:25 +02:00
881043bc5d
Fix failing test after mod settings layout changes
...
The slight hack which was used in the test to ensure that the mod
settings overlay covered the entire width of the mod overlay broke after
adjustments to the layout in the previous commit.
Locally adjust the hack to use the parent of the `ModSettingsContainer`
rather than the container itself.
2021-04-20 19:38:25 +02:00
4910d8f56c
Fix click-to-resume cursor location being incorrect when playfield is transformed
...
Closes #12501 .
2021-04-21 00:12:49 +09:00
26430e3cb5
Merge pull request #12492 from Naxesss/bg-audio-quality-checks
...
Add background and audio checks
2021-04-21 00:10:32 +09:00
7fc450c620
Fix mod settings blocking input outside its visible area
...
Closes #12502 .
2021-04-20 23:42:56 +09:00
4cc3321d54
Fix potential doubling of events
2021-04-20 21:20:08 +09:00
a9e4a0ed50
Fix potentially starting play when finished
...
The UserFinishedPlaying event may trigger before the event is subscribed
to by SpectatorScreen. For such cases, an extra check is done to make
sure the user is _actually_ playing.
2021-04-20 21:19:08 +09:00
156a518068
Merge branch 'master' into fix-initial-spectator-state-callback
2021-04-20 21:16:05 +09:00
e9dfa2860a
Add xmldoc note about path being relative
2021-04-20 13:44:06 +02:00
d7a81471c8
Add xmldoc to GetPathForFile
2021-04-20 13:40:38 +02:00
86772869da
Merge pull request #12498 from peppy/barrel-roll-faster-spin
...
Allow faster roll speed selection in "Barrel Roll" mod
2021-04-20 20:39:45 +09:00
1edda5878c
Merge pull request #12499 from peppy/barrel-roll-keep-numbers-aligned
...
Keep hitcircles aligned with view in "Barrel Roll" mod
2021-04-20 20:39:17 +09:00
65efb7ca4e
Merge pull request #12497 from peppy/remove-catch-hyperdash-glow-fade
...
Remove catcher fade during hyperdash
2021-04-20 20:36:17 +09:00
3e1b6b3b34
Simplify verifier run call args
...
Uses the resolved working beatmap instead of resolving it every time.
Also uses the EditorBeatmap itself as playable beatmap, as it is of type `IBeatmap` already, and `.PlayableBeatmap` forwards everything anyway.
2021-04-20 13:34:12 +02:00
c0318a4d3e
Fix usage of _ in Moq lambdas
2021-04-20 13:29:14 +02:00
6a1e4ff99f
Add file hash to file presence test
...
Necessary because we now find the storage path of the file rather than just the file itself.
2021-04-20 13:28:32 +02:00
5262d94e21
Fix wrong assert in offscreen test
2021-04-20 13:21:57 +02:00
c5d6b6ea8d
Fix tests failing intermittently
...
This was due to this code happening in UpdateAfterChildren(), after the
GCC has processed one frame. During this time, the clock could have
advanced an arbitrary amount.
The cause of this is the removal of the Task.Run() to set the clock in
Restart() (now called Reset()) which changed the timing, so it only worked before due to pure
luck.
2021-04-20 18:41:09 +09:00
ac0ed72d04
Keep hitcircles aligned with view in "Barrel Roll" mod
2021-04-20 18:36:11 +09:00
f144661c31
Fix storyboard sample test scene
2021-04-20 18:26:30 +09:00
ec080fcb32
Move seekOffset back to MasterGameplayClockContainer
2021-04-20 18:25:46 +09:00
f11b068dee
Allow faster roll speed selection in "Barrel Roll" mod
2021-04-20 18:22:58 +09:00
ddf1b560f3
Remove catcher fade during hyperdash
...
Closes https://github.com/ppy/osu/issues/12472 .
2021-04-20 18:18:51 +09:00
3932f6c3e3
Merge pull request #12496 from smoogipoo/fix-pre-seek-sample-lifetime
...
Fix storyboard samples not getting a lifetime end if initially seeked past
2021-04-20 18:07:15 +09:00
a683e5ec34
Seek using local method
2021-04-20 17:40:11 +09:00
97fb90d9f4
Move clock processing to base.Seek()
2021-04-20 17:35:59 +09:00
5da18c51a4
Fix compile error
2021-04-20 17:27:37 +09:00
80473a356e
Merge branch 'fix-pre-seek-sample-lifetime' into gcc-abstraction
2021-04-20 17:27:01 +09:00
d28eb399a4
Fix storyboard sample lifetimes not set if seeked past
2021-04-20 17:14:48 +09:00
281c2041b2
Add failing test
2021-04-20 16:51:00 +09:00
c6ee4e900e
Ensure a non-null hitobject entry has a non-null Result
2021-04-20 15:18:36 +09:00
3d6d26039a
Remove unused usings
2021-04-20 14:09:54 +09:00
88ded95e75
Ensure clock is set in GCC.Start()
2021-04-20 13:56:13 +09:00
8dd9134e3d
Move source clock adjustment application to Start()
2021-04-20 13:09:49 +09:00
a92ae8ce76
Fix Reset() potentially not resetting to the intended start position
2021-04-20 13:01:42 +09:00
e227c076e5
Merge pull request #12478 from bdach/combo-colours-display
...
Add read-only combo colour display to setup screen
2021-04-20 11:55:35 +09:00
8a8b9084ef
Make single-argument overloead of DHO.Apply public
2021-04-20 10:11:36 +09:00
