a854ce429a
add blank line between method
2021-04-18 23:49:13 -04:00
f9f514ffec
Add basic xmldoc to show how the two colour classes interact
2021-04-19 12:37:56 +09:00
999f2d810c
Fix accidentally removed code
2021-04-18 23:30:07 -04:00
e44d11667c
Merge remote-tracking branch 'upstream'
2021-04-18 23:04:35 -04:00
c39ab2c692
Add SessionStaticsTest
2021-04-18 23:04:28 -04:00
b727faace3
Revert changes to IdleTracker
2021-04-18 23:03:43 -04:00
f74904f0aa
Merge pull request #12481 from Joehuu/fix-download-button-check-scaling
...
Fix download button check icon not scaling on mouse down
2021-04-19 11:49:39 +09:00
dbb8f7f4a9
Tidy up initialisation code and avoid using DI on inherited class
2021-04-19 11:30:55 +09:00
2b6caf9b65
Fix duplicate code in setting default logic
2021-04-19 11:25:43 +09:00
89940e7bb9
Fix download button check icon not scaling on mouse down
2021-04-18 19:05:33 -07:00
6f2ebb20a7
Fix test failing due to null beatmap skin
...
Also annotate the field on `EditorBeatmap` as nullable for future
travelers.
2021-04-18 20:46:42 +02:00
07a00cd681
Add colours section with combo colour display
2021-04-18 20:46:42 +02:00
577755ee19
Add placeholder when no colours are visible
...
Will be removed once combo colours are mutable.
2021-04-18 20:46:42 +02:00
0cd1aa8c1c
Add support for custom colour prefixes
2021-04-18 20:44:55 +02:00
a8027d87b6
Fix unreadable colour hex code text due to low contrast
...
Logic is shared with the timeline blueprints which also have the same
problem of displaying text on top of a combo colour.
Slightly modified the formula. Seems to yield better results on a
subjective check.
2021-04-18 20:44:55 +02:00
67c19df000
Add test coverage for adding/removing colours
2021-04-18 19:35:42 +02:00
1b2c43b92c
Add basic structure of colour palette
2021-04-18 19:29:04 +02:00
0988af5449
Merge pull request #12476 from peppy/fix-volume-sideways-scroll
2021-04-18 18:34:43 +02:00
91b3a7ccf9
Merge branch 'master' into fix-volume-sideways-scroll
2021-04-18 17:52:40 +02:00
1a2679df4c
Merge pull request #12473 from peppy/fix-selection-after-paste
2021-04-18 17:40:52 +02:00
af79ad537c
Avoid unnecessary debounce triggers on zero-delta scrolls
2021-04-19 00:05:44 +09:00
e63edf5b49
Fix volume control displaying on non-vertical scroll events
...
Closes #12475 .
2021-04-19 00:05:44 +09:00
cfc7664094
Use full path
2021-04-18 21:05:23 +09:00
e76565dbc5
Fix selection box not displaying after pasting a selection in the editor
...
Closes #12471 .
2021-04-18 20:28:39 +09:00
2678089e0b
Add test case failing on selection after paste
2021-04-18 20:28:39 +09:00
9a69ca34a6
Add audio presence check
2021-04-18 02:07:57 +02:00
010720de74
Factor out general file presence checking
...
This allows us to use the same method of checking for other files that should exist, for example the audio file.
By using the same method, they all share test cases too.
2021-04-18 02:07:33 +02:00
0502fbb429
Add background quality check tests
2021-04-18 01:21:51 +02:00
56bf49c85c
Take IWorkingBeatmap instead of WorkingBeatmap
...
This makes testing much easier, and allows for checking of any class deriving from that interface, including `WorkingBeatmap`.
2021-04-18 01:21:20 +02:00
abf512532e
Clean up check logic
...
Makes use of the new `BeatmapSet.GetPathForFile` method and removes dependency on `WorkingBeatmap` specifically, allowing us to switch to `IWorkingBeatmap` later.
2021-04-18 01:19:25 +02:00
ef65c8910f
Fix resolved fields
2021-04-18 01:15:13 +02:00
bf8789528a
Add GetStream to IWorkingBeatmap
2021-04-18 01:13:57 +02:00
eec77b0527
replace icon
2021-04-17 23:55:39 +02:00
cb41c89935
Don't return low res and too low res at the same time
2021-04-17 20:10:07 +02:00
62c54e00cb
Add check for background resolution and filesize
2021-04-17 18:01:04 +02:00
b36da2664c
Add GetPathForFile to BeatmapSetInfo
...
This is used in several places, and so should probably have a function rather than remaining as duplicated code.
Also applies this together with the previous commit to `BeatmapManagerWorkingBeatmap`.
2021-04-17 17:49:10 +02:00
400f8b3938
Add GetStream to IWorkingBeatmap
...
This is necessary to obtain the filesize of the audio and background files.
2021-04-17 17:47:13 +02:00
448574e7e6
Use WorkingBeatmap instead of IBeatmap
...
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
Also improves the structure of the `CheckBackgroundTest` class in the process.
2021-04-17 17:33:53 +02:00
5d274dbce8
replace IApplicableToPlayer with IApplicableToDrawableRuleset
2021-04-17 16:38:28 +02:00
cf3aaff7bd
Add floating fruits mod
2021-04-17 16:01:23 +02:00
1e56f14f5b
Merge remote-tracking branch 'upstream'
2021-04-17 09:35:24 -04:00
1832f624e2
Merge pull request #12460 from bdach/fix-idle-tracker-assumption
2021-04-17 15:31:54 +02:00
6773162f17
Implicitly set defaults when resetting values
2021-04-17 08:47:27 -04:00
f3ea51eeed
Adjust tests to not rely on invalid assumption
2021-04-17 14:23:32 +02:00
250c7403e8
Fix idle tracker assuming time starts at 0
...
`IdleTracker` in its construction quietly assumed that the clock it
receives from its parent starts ticking from 0 at the point at which it
is passed down. This is not necessarily the case when headless
executions are involved, which means that the initial state of the
tracker could be computed as idle incorrectly.
Resolve by explicitly reading the clock time at the point of
`LoadComplete()`.
2021-04-17 13:50:00 +02:00
3eb2fb7e89
Merge pull request #12456 from frenzibyte/improve-br-tooltip
...
Improve "barrel roll" mod settings description
2021-04-17 13:19:24 +09:00
c1082ddb9a
Add space before the unit
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com >
2021-04-17 06:28:07 +03:00
892a8a7cd2
Remove unnecessary comma
2021-04-17 04:23:48 +03:00
78c8508784
Remove unused using directive
...
gotta git gud
2021-04-17 03:52:08 +03:00
d5a1e00feb
Improve "barrel roll" mod settings description
2021-04-17 03:32:47 +03:00
