ceed3606cd
Remove redundant comment
...
Co-authored-by: Dean Herbert <pe@ppy.sh >
2023-02-17 13:46:06 +03:00
372b6b794c
I don't know what .ots is but let's not use random file extension that make no sense
2023-02-17 13:46:27 +09:00
8ef3fb26e0
More constants and assert fixes
2023-02-17 13:46:27 +09:00
86d110e893
Simplify test storage by removing nested storage
2023-02-17 13:43:42 +09:00
4560ae6b02
Mark test as fixture
2023-02-17 13:39:31 +09:00
99236f0ae8
Move long filename to fixture level
2023-02-17 13:39:24 +09:00
8c772a723f
Expose constant publicly rather than reexposing business
2023-02-17 13:34:19 +09:00
96b1498932
Rename max length variable to make sense (it's a filename limit, not path)
2023-02-17 13:33:22 +09:00
415220a447
Tidy up new test method code quality
2023-02-17 13:30:00 +09:00
810712386d
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-17 01:51:24 +03:00
f4038a49a1
Fix inspectCode issues
2023-02-17 01:50:24 +03:00
1d8b348e4c
Improve naming
2023-02-17 01:46:15 +03:00
6cb00cd42f
Add more test cases
2023-02-17 01:44:45 +03:00
9f9893d93a
Merge pull request #22338 from Pasi4K5/hide-resume-overlay
...
Hide `ResumeOverlay` when `OsuModAutopilot` is enabled
2023-02-16 22:22:19 +01:00
66e9bb2581
Merge branch 'master' into hide-resume-overlay
2023-02-16 21:33:23 +01:00
bba1722725
Merge pull request #22645 from peppy/adjust-song-select-background-dim
...
Adjust song select background dimming to be more evenly applied
2023-02-16 21:27:27 +01:00
b8084a15eb
Revert ResumeOverlay setter accessibility change
2023-02-16 21:26:01 +01:00
0186062246
Merge branch 'master' into adjust-song-select-background-dim
2023-02-16 20:52:36 +01:00
ad5132ed41
Remove redundant conditional access qualifier
...
It is impossible for the callback passed to `ApplyToBackground()` to
receive a null reference. See `OsuScreen.ApplyToBackground()` - if the
background to call the callback on were `null`, then an
`InvalidOperationException` would be thrown instead.
2023-02-16 20:47:51 +01:00
7d86f49fce
Merge pull request #22658 from peppy/gameplay-sample-trigger-source-test-fix
...
Refactor `GameplaySampleTriggerSource` test to not be realtime dependent
2023-02-16 19:39:18 +01:00
5bdc5dfadd
Add one more assert to keep coverage from previous implementation
2023-02-16 19:02:51 +01:00
6819a45a1b
Improve code slightly
2023-02-16 16:42:07 +03:00
f1da213bea
Add tests
2023-02-16 16:26:57 +03:00
3057ccb635
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-16 13:22:11 +03:00
394d368f16
Fix song select potentially updating background parameters when not the current screen
2023-02-16 18:45:22 +09:00
979c079f8b
Refactor GameplaySampleTriggerSource test to not be realtime dependent
2023-02-16 17:58:44 +09:00
9d02a2ef0e
Apply NRT to GamepleSampleTriggerSource tests
2023-02-16 17:58:44 +09:00
ce9ef3bc3c
Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not
2023-02-16 15:47:20 +09:00
7afdcb9383
Merge branch 'master' into hide-resume-overlay
2023-02-16 15:42:14 +09:00
87901bc8b1
Merge pull request #22292 from ekrctb/maximum-judgement-offset-in-hit-object
...
Move MaximumJudgementOffset to HitObject
2023-02-16 00:52:35 +01:00
c315113fde
Merge branch 'master' into maximum-judgement-offset-in-hit-object
2023-02-16 00:15:51 +01:00
1d5d34ba0e
Merge pull request #22647 from peppy/remove-target-component-container
...
Simplify and rename `SkinnableTargetComponentsContainer`
2023-02-15 21:25:49 +01:00
387a6f1330
Move logic to Export method
2023-02-15 22:43:43 +03:00
fb06a77e2b
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-15 22:29:38 +03:00
1f586c129c
fix applied
2023-02-15 22:15:44 +03:00
455fb7789c
Merge pull request #22646 from peppy/fix-skin-export-matching-directory
...
Fix exports failing if a directory exists with the proposed filename
2023-02-15 19:04:15 +01:00
d9b4d932c9
Fix test container lookup failure
2023-02-15 17:47:34 +09:00
ca75f0ec77
Apply NRT to TestSceneBeatmapSkinFallbacks
2023-02-15 17:30:21 +09:00
8bbd00822c
Simplify and rename SkinnableTargetComponentsContainer
2023-02-15 17:30:21 +09:00
e71dfd7555
Fix skin export failing if a directory exists with the proposed filename
2023-02-15 16:11:16 +09:00
da8ab7143b
Merge branch 'master' into maximum-judgement-offset-in-hit-object
2023-02-15 14:48:15 +09:00
9ed068c1e6
Only apply dim changes when background blur is disabled
2023-02-15 14:16:34 +09:00
19e3c5d33c
Adjust song select background dimming to be more evenly applied
2023-02-15 13:59:24 +09:00
24961d1ac0
Merge pull request #22599 from peppy/fix-mania-long-note-regression
...
Fix osu!mania long notes not displaying correctly since recent update
2023-02-14 22:14:08 +01:00
99b78c63a0
Merge branch 'master' into fix-mania-long-note-regression
2023-02-14 21:25:31 +01:00
e6f0a1dec9
Merge pull request #22632 from Joehuu/fix-beatmap-preview-progress
...
Fix beatmap card song preview progress sometimes showing past progress for one frame
2023-02-14 17:06:50 +09:00
215049a5f3
Merge pull request #22629 from Cootz/SkinSetOnNotificationClick
...
Select skin by clicking on an import notification
2023-02-14 17:06:35 +09:00
0217875f3f
Merge branch 'master' into SkinSetOnNotificationClick
2023-02-14 16:04:03 +09:00
0ad245e9e0
Rewrite implementation to match other implementations
2023-02-14 16:00:23 +09:00
21429e164f
Fix comment grammar
2023-02-14 15:55:32 +09:00
